Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8E63BC433EF for ; Tue, 23 Nov 2021 15:24:14 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 7C68E81918; Tue, 23 Nov 2021 16:24:11 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="I7kLjvpa"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id E4B78811DE; Tue, 23 Nov 2021 16:24:09 +0100 (CET) Received: from mail-qv1-xf36.google.com (mail-qv1-xf36.google.com [IPv6:2607:f8b0:4864:20::f36]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 8872281918 for ; Tue, 23 Nov 2021 16:24:06 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qv1-xf36.google.com with SMTP id g1so15201069qvd.2 for ; Tue, 23 Nov 2021 07:24:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=01zjo7chCCJQmmEOXIR0gAhcJwZQQjs8TjTeVwRPMhg=; b=I7kLjvpaMnBrwbzrwN4LkY82do/gqTW3n4Zb4CM0bTa+11yHgp+cNQDUu+D4xPE6JB e2OUw3m+D4Z7uz/+ch7B/S06Q5QcBRVO3iWsX/n5Fq/DiTcVpG70/DBqnhHhRbaShkZG tSEZgd38kX38Lc5MuQAoavL/2sqscOQbL0O8g= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=01zjo7chCCJQmmEOXIR0gAhcJwZQQjs8TjTeVwRPMhg=; b=liE9Px2KQDGcfh+J4GgJW/x39BBUnqaaj3/snDCFKS1rQRhHUWXrYdZvW2w1ggasp3 HcJk5lMjcN+GqrXf5kcoQPh00YiqE0A7vLbGYyrMPA4h0N7D0FlexmsY3ob+ljFAfeBH O6/k7RCc8kYEEbhG6Ov/VhV470+v/gH0+z6VT6XddH90sPjT0VyLWYi7LNEK+2Oq+NYD HSTvRerikM2PsjqzezMomEH/g7tujaNPQ116OXqX1v89zRnvQ7WKkE11IEyJ8O9h3JKe rU88dR7AV1OdiXM3k4JopiKKzSfxy3113i9RNTOIsx81dlmhrKTo+pHvLWxeASZe7efD T/mA== X-Gm-Message-State: AOAM530EDiwAs644ZOVyiE2W10/m5aACaZN6H9QMPaKUYwgbtGyqDzgW ElYyAXt5hZevmBreCSskyb95Dw== X-Google-Smtp-Source: ABdhPJwAeyLIJEAdWf5SslHLOJzzYElP0CAZV53sVcxgoui57H5a4BkWzeCKrQJ2rHR/+r5YvDUbGg== X-Received: by 2002:a05:6214:226c:: with SMTP id gs12mr7539957qvb.49.1637681045229; Tue, 23 Nov 2021 07:24:05 -0800 (PST) Received: from bill-the-cat (2603-6081-7b01-cbda-2132-1e2a-3644-57ec.res6.spectrum.com. [2603:6081:7b01:cbda:2132:1e2a:3644:57ec]) by smtp.gmail.com with ESMTPSA id bj1sm6491984qkb.75.2021.11.23.07.24.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Nov 2021 07:24:04 -0800 (PST) Date: Tue, 23 Nov 2021 10:24:01 -0500 From: Tom Rini To: Jim Posen Cc: u-boot@lists.denx.de, mbrugger@suse.com, Chia-Wei Wang , Harald Seiler , Minkyu Kang , Simon Glass Subject: Re: [RFC PATCH 0/5] Exception handling in HYP mode on ARMv7-A Message-ID: <20211123152401.GH24579@bill-the-cat> References: <20211024235808.1926508-1-jim.posen@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="0yIEv4ciajEKQOWx" Content-Disposition: inline In-Reply-To: <20211024235808.1926508-1-jim.posen@gmail.com> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.37 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --0yIEv4ciajEKQOWx Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Oct 24, 2021 at 07:58:03PM -0400, Jim Posen wrote: > Currently, when U-Boot is running in hypervisor mode on ARMv7-A CPUs > with virtualization extensions, the exception handling does not work. > A couple things need to change which are detailed in my earlier > message to the u-boot mailing list with the subject "Exception > handling in HYP mode on ARMv7-A". >=20 > I have verified that this patch series works on the ODroid XU4 and > the Raspberry Pi 3B in Aarch32 mode when running in hypervisor mode. > One simple way to verify is by running the miscellaneous "exception" > command (CMD_EXCEPTION). >=20 >=20 > Jim Posen (5): > Compile for ARMv7-A with virtualization extensions > Hypervisor mode interrupt vector table > Set HVBAR register correctly > Remove dead code > Fix PC adjustment logic in exception handlers >=20 > arch/arm/Makefile | 4 + > arch/arm/cpu/armv7/start.S | 5 ++ > arch/arm/include/asm/u-boot-arm.h | 14 ++-- > arch/arm/lib/interrupts.c | 26 +++--- > arch/arm/lib/relocate.S | 8 ++ > arch/arm/lib/vectors.S | 129 +++++++++++++++++++++++------- > arch/arm/mach-bcm283x/Kconfig | 3 + > arch/arm/mach-exynos/Kconfig | 1 + > 8 files changed, 139 insertions(+), 51 deletions(-) This all seems fine, but I don't know enough about the specifics here to comment on the implementation. Is there any we we could also test this via QEMU for example? --=20 Tom --0yIEv4ciajEKQOWx Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmGdB40ACgkQFHw5/5Y0 tyxFHQwAlEsvgm4YRVO1r/D07EfV0/+nAKj07F4uK2xdSKF3MlFbp6LYYUvDWvXr BRuNwKp3l96qbuEc3NMR+Q4+KK+8AUKfRIMsQ3DL7Hc13UITLXNmf6T89LBCtFRa QHG7cuFheLOVxk6l1+gUDKda9Kb4Zoy7EqTCT9qVeKClk6P01P8e3hhV7ZHNrkJY TGLouNsn3ezwcAoZmv7GGr2/BMO4zjPsFBUZtciYFKBm9dApeNRz6C+/E+/ma52H aCemyJwE1DLozebLoy8EgIlGpqwksp5SIe/eOxdfA9g820VdPrMrG9he/+roK1SI 0p/W0dcgxYebwOPadyymkXc+ES5C0s3Xzt4ZJ3idWWWJvUCq5LQ+CSV+W4pZjWdT YYUz7T1p2KUB4m2HIvNeOCaRAfARwxroPfbCHMmUWtEXfC5prhEqA51B9m3Yd6IQ MRkajez+vvfHPf01HcffhDS+YX/kFFJzbkTOxy2FEUNxRs6AsG/l1C645B54JEPf CLigNN1u =BLxc -----END PGP SIGNATURE----- --0yIEv4ciajEKQOWx--