Content-Type: multipart/mixed; boundary="===============2184188872881007459==" MIME-Version: 1.0 From: kernel test robot To: kbuild-all@lists.01.org Subject: Re: [PATCH v1 1/3] fs: add parameter use_fpos to iterate_dir function Date: Thu, 25 Nov 2021 03:58:11 +0800 Message-ID: <202111250356.yBAHK4KL-lkp@intel.com> In-Reply-To: <20211123181010.1607630-2-shr@fb.com> List-Id: --===============2184188872881007459== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Hi Stefan, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v5.16-rc2 next-20211124] [cannot apply to mszeredi-vfs/overlayfs-next] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Stefan-Roesch/io_uring-add= -getdents64-support/20211124-022809 base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git = 136057256686de39cc3a07c2e39ef6bc43003ff6 config: x86_64-randconfig-r006-20211124 (https://download.01.org/0day-ci/ar= chive/20211125/202111250356.yBAHK4KL-lkp(a)intel.com/config) compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 67a1c4= 5def8a75061203461ab0060c75c864df1c) reproduce (this is a W=3D1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/= make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/94fab53b56d471270b8b7b9af= e6d73a8098448be git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Stefan-Roesch/io_uring-add-getdent= s64-support/20211124-022809 git checkout 94fab53b56d471270b8b7b9afe6d73a8098448be # save the config file to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=3D$HOME/0day COMPILER=3Dclang make.cross W=3D= 1 O=3Dbuild_dir ARCH=3Dx86_64 SHELL=3D/bin/bash fs/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All errors (new ones prefixed by >>): >> fs/ksmbd/vfs.c:1139:47: error: too few arguments to function call, expec= ted 3, have 2 err =3D iterate_dir(fp->filp, &readdir_data.ctx); ~~~~~~~~~~~ ^ include/linux/fs.h:3346:12: note: 'iterate_dir' declared here extern int iterate_dir(struct file *file, struct dir_context *ctx, bool = use_fpos); ^ fs/ksmbd/vfs.c:1189:44: error: too few arguments to function call, expec= ted 3, have 2 ret =3D iterate_dir(dfilp, &readdir_data.ctx); ~~~~~~~~~~~ ^ include/linux/fs.h:3346:12: note: 'iterate_dir' declared here extern int iterate_dir(struct file *file, struct dir_context *ctx, bool = use_fpos); ^ 2 errors generated. -- >> fs/ksmbd/smb2pdu.c:3926:58: error: too few arguments to function call, e= xpected 3, have 2 rc =3D iterate_dir(dir_fp->filp, &dir_fp->readdir_data.ctx); ~~~~~~~~~~~ ^ include/linux/fs.h:3346:12: note: 'iterate_dir' declared here extern int iterate_dir(struct file *file, struct dir_context *ctx, bool = use_fpos); ^ 1 error generated. vim +1139 fs/ksmbd/vfs.c f44158485826c0 fs/cifsd/vfs.c Namjae Jeon 2021-03-16 1122 = f44158485826c0 fs/cifsd/vfs.c Namjae Jeon 2021-03-16 1123 /** f44158485826c0 fs/cifsd/vfs.c Namjae Jeon 2021-03-16 1124 * ksmbd_vfs_em= pty_dir() - check for empty directory f44158485826c0 fs/cifsd/vfs.c Namjae Jeon 2021-03-16 1125 * @fp: ksmbd f= ile pointer f44158485826c0 fs/cifsd/vfs.c Namjae Jeon 2021-03-16 1126 * f44158485826c0 fs/cifsd/vfs.c Namjae Jeon 2021-03-16 1127 * Return: true= if directory empty, otherwise false f44158485826c0 fs/cifsd/vfs.c Namjae Jeon 2021-03-16 1128 */ f44158485826c0 fs/cifsd/vfs.c Namjae Jeon 2021-03-16 1129 int ksmbd_vfs_e= mpty_dir(struct ksmbd_file *fp) f44158485826c0 fs/cifsd/vfs.c Namjae Jeon 2021-03-16 1130 { f44158485826c0 fs/cifsd/vfs.c Namjae Jeon 2021-03-16 1131 int err; f44158485826c0 fs/cifsd/vfs.c Namjae Jeon 2021-03-16 1132 struct ksmbd_r= eaddir_data readdir_data; f44158485826c0 fs/cifsd/vfs.c Namjae Jeon 2021-03-16 1133 = f44158485826c0 fs/cifsd/vfs.c Namjae Jeon 2021-03-16 1134 memset(&readdi= r_data, 0, sizeof(struct ksmbd_readdir_data)); f44158485826c0 fs/cifsd/vfs.c Namjae Jeon 2021-03-16 1135 = f44158485826c0 fs/cifsd/vfs.c Namjae Jeon 2021-03-16 1136 set_ctx_actor(= &readdir_data.ctx, __dir_empty); f44158485826c0 fs/cifsd/vfs.c Namjae Jeon 2021-03-16 1137 readdir_data.d= irent_count =3D 0; f44158485826c0 fs/cifsd/vfs.c Namjae Jeon 2021-03-16 1138 = e8c061917133dd fs/cifsd/vfs.c Namjae Jeon 2021-06-22 @1139 err =3D iterat= e_dir(fp->filp, &readdir_data.ctx); f44158485826c0 fs/cifsd/vfs.c Namjae Jeon 2021-03-16 1140 if (readdir_da= ta.dirent_count > 2) f44158485826c0 fs/cifsd/vfs.c Namjae Jeon 2021-03-16 1141 err =3D -ENOT= EMPTY; f44158485826c0 fs/cifsd/vfs.c Namjae Jeon 2021-03-16 1142 else f44158485826c0 fs/cifsd/vfs.c Namjae Jeon 2021-03-16 1143 err =3D 0; f44158485826c0 fs/cifsd/vfs.c Namjae Jeon 2021-03-16 1144 return err; f44158485826c0 fs/cifsd/vfs.c Namjae Jeon 2021-03-16 1145 } f44158485826c0 fs/cifsd/vfs.c Namjae Jeon 2021-03-16 1146 = --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org --===============2184188872881007459==--