Content-Type: multipart/mixed; boundary="===============1134866231808588448==" MIME-Version: 1.0 From: kernel test robot To: kbuild-all@lists.01.org Subject: Re: [PATCH v3 1/7] x86: clk: Add check for PCI root port for fch fixed clk support Date: Thu, 25 Nov 2021 20:50:41 +0800 Message-ID: <202111252001.0psIb0sd-lkp@intel.com> In-Reply-To: <20211125062036.1185994-2-AjitKumar.Pandey@amd.com> List-Id: --===============1134866231808588448== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Hi Ajit, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on clk/clk-next] [also build test WARNING on rafael-pm/linux-next linus/master v5.16-rc2 nex= t-20211125] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Ajit-Kumar-Pandey/x86-clk-= clk-fch-Enhanced-48Mhz-fixed-clk-support/20211125-142523 base: https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git clk-n= ext config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/202111= 25/202111252001.0psIb0sd-lkp(a)intel.com/config) compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 reproduce (this is a W=3D1 build): # https://github.com/0day-ci/linux/commit/ad72f6072b56c2ad466eef386= eca2d1a8ba48e2d git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Ajit-Kumar-Pandey/x86-clk-clk-fch-= Enhanced-48Mhz-fixed-clk-support/20211125-142523 git checkout ad72f6072b56c2ad466eef386eca2d1a8ba48e2d # save the config file to linux build tree make W=3D1 ARCH=3Dx86_64 = If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All warnings (new ones prefixed by >>): drivers/clk/x86/clk-fch.c: In function 'fch_clk_remove': >> drivers/clk/x86/clk-fch.c:97:23: warning: variable 'fch_data' set but no= t used [-Wunused-but-set-variable] 97 | struct fch_clk_data *fch_data; | ^~~~~~~~ vim +/fch_data +97 drivers/clk/x86/clk-fch.c 421bf6a1f061a6e drivers/clk/x86/clk-st.c Akshu Agrawal 2018-05-09 93= = d9b77361c1a5155 drivers/clk/x86/clk-fch.c Akshu Agrawal 2020-07-31 94= static int fch_clk_remove(struct platform_device *pdev) 421bf6a1f061a6e drivers/clk/x86/clk-st.c Akshu Agrawal 2018-05-09 95= { 19fe87fd854a92c drivers/clk/x86/clk-fch.c Akshu Agrawal 2020-07-31 96= int i, clks; 19fe87fd854a92c drivers/clk/x86/clk-fch.c Akshu Agrawal 2020-07-31 @97= struct fch_clk_data *fch_data; ad72f6072b56c2a drivers/clk/x86/clk-fch.c Ajit Kumar Pandey 2021-11-25 98= struct pci_dev *fch_dev; 19fe87fd854a92c drivers/clk/x86/clk-fch.c Akshu Agrawal 2020-07-31 99= = 19fe87fd854a92c drivers/clk/x86/clk-fch.c Akshu Agrawal 2020-07-31 100= fch_data =3D dev_get_platdata(&pdev->dev); 421bf6a1f061a6e drivers/clk/x86/clk-st.c Akshu Agrawal 2018-05-09 101= = ad72f6072b56c2a drivers/clk/x86/clk-fch.c Ajit Kumar Pandey 2021-11-25 102= fch_dev =3D pci_get_domain_bus_and_slot(0, 0, PCI_DEVFN(0, 0)); ad72f6072b56c2a drivers/clk/x86/clk-fch.c Ajit Kumar Pandey 2021-11-25 103= if (!fch_dev) ad72f6072b56c2a drivers/clk/x86/clk-fch.c Ajit Kumar Pandey 2021-11-25 104= return -ENODEV; ad72f6072b56c2a drivers/clk/x86/clk-fch.c Ajit Kumar Pandey 2021-11-25 105= = ad72f6072b56c2a drivers/clk/x86/clk-fch.c Ajit Kumar Pandey 2021-11-25 106= clks =3D pci_match_id(fch_pci_ids, fch_dev) ? CLK_MAX_FIXED : ST_MAX_CLK= S; 19fe87fd854a92c drivers/clk/x86/clk-fch.c Akshu Agrawal 2020-07-31 107= = 19fe87fd854a92c drivers/clk/x86/clk-fch.c Akshu Agrawal 2020-07-31 108= for (i =3D 0; i < clks; i++) 421bf6a1f061a6e drivers/clk/x86/clk-st.c Akshu Agrawal 2018-05-09 109= clk_hw_unregister(hws[i]); 19fe87fd854a92c drivers/clk/x86/clk-fch.c Akshu Agrawal 2020-07-31 110= = 421bf6a1f061a6e drivers/clk/x86/clk-st.c Akshu Agrawal 2018-05-09 111= return 0; 421bf6a1f061a6e drivers/clk/x86/clk-st.c Akshu Agrawal 2018-05-09 112= } 421bf6a1f061a6e drivers/clk/x86/clk-st.c Akshu Agrawal 2018-05-09 113= = --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org --===============1134866231808588448==--