Content-Type: multipart/mixed; boundary="===============3311392340905362635==" MIME-Version: 1.0 From: kernel test robot To: kbuild-all@lists.01.org Subject: Re: [PATCH 1/2] misc: fastrpc: Add fdlist implementation Date: Wed, 01 Dec 2021 04:20:48 +0800 Message-ID: <202112010402.quLlpjqn-lkp@intel.com> In-Reply-To: <1638277072-6459-3-git-send-email-jeyr@codeaurora.org> List-Id: --===============3311392340905362635== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Hi Jeya, Thank you for the patch! Yet something to improve: [auto build test ERROR on char-misc/char-misc-testing] [also build test ERROR on v5.16-rc3 next-20211130] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Jeya-R/misc-fastrpc-Add-fd= list-implementation/20211130-215833 base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.gi= t 5d331b5922551637c586cdf5fdc1778910fc937f config: sh-allmodconfig (https://download.01.org/0day-ci/archive/20211201/2= 02112010402.quLlpjqn-lkp(a)intel.com/config) compiler: sh4-linux-gcc (GCC) 11.2.0 reproduce (this is a W=3D1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/= make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/d9eaed76074c94c9751c3a587= ef2409fa7ce153e git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Jeya-R/misc-fastrpc-Add-fdlist-imp= lementation/20211130-215833 git checkout d9eaed76074c94c9751c3a587ef2409fa7ce153e # save the config file to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=3D$HOME/0day COMPILER=3Dgcc-11.2.0 make.cross= O=3Dbuild_dir ARCH=3Dsh SHELL=3D/bin/bash drivers/misc/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All errors (new ones prefixed by >>): drivers/misc/fastrpc.c: In function 'fastrpc_put_args': >> drivers/misc/fastrpc.c:923:39: error: 'fl' undeclared (first use in this= function); did you mean 'fd'? 923 | if (!fastrpc_map_find(fl, (int)fdlist[i], &mmap)) | ^~ | fd drivers/misc/fastrpc.c:923:39: note: each undeclared identifier is repor= ted only once for each function it appears in vim +923 drivers/misc/fastrpc.c 886 = 887 static int fastrpc_put_args(struct fastrpc_invoke_ctx *ctx, 888 u32 kernel) 889 { 890 struct fastrpc_remote_arg *rpra =3D ctx->rpra; 891 struct fastrpc_map *mmap =3D NULL; 892 struct fastrpc_invoke_buf *list; 893 struct fastrpc_phy_page *pages; 894 u64 *fdlist; 895 int i, inbufs, outbufs, handles; 896 = 897 inbufs =3D REMOTE_SCALARS_INBUFS(ctx->sc); 898 outbufs =3D REMOTE_SCALARS_OUTBUFS(ctx->sc); 899 handles =3D REMOTE_SCALARS_INHANDLES(ctx->sc) + REMOTE_SCALARS_OUTH= ANDLES(ctx->sc); 900 list =3D ctx->buf->virt + ctx->nscalars * sizeof(*rpra); 901 pages =3D ctx->buf->virt + ctx->nscalars * (sizeof(*list) + 902 sizeof(*rpra)); 903 fdlist =3D (uint64_t *)(pages + inbufs + outbufs + handles); 904 = 905 for (i =3D inbufs; i < ctx->nbufs; ++i) { 906 if (!ctx->maps[i]) { 907 void *src =3D (void *)(uintptr_t)rpra[i].pv; 908 void *dst =3D (void *)(uintptr_t)ctx->args[i].ptr; 909 u64 len =3D rpra[i].len; 910 = 911 if (!kernel) { 912 if (copy_to_user((void __user *)dst, src, len)) 913 return -EFAULT; 914 } else { 915 memcpy(dst, src, len); 916 } 917 } 918 } 919 = 920 for (i =3D 0; i < FASTRPC_MAX_FDLIST; i++) { 921 if (!fdlist[i]) 922 break; > 923 if (!fastrpc_map_find(fl, (int)fdlist[i], &mmap)) 924 fastrpc_map_put(mmap); 925 } 926 = 927 return 0; 928 } 929 = --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org --===============3311392340905362635==--