Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4F3D3C433F5 for ; Wed, 15 Dec 2021 16:47:35 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 1459C83047; Wed, 15 Dec 2021 17:47:32 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="VYkcyc4T"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 577D683230; Wed, 15 Dec 2021 17:47:29 +0100 (CET) Received: from mail-qv1-xf2c.google.com (mail-qv1-xf2c.google.com [IPv6:2607:f8b0:4864:20::f2c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id E49B783047 for ; Wed, 15 Dec 2021 17:47:25 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=seanga2@gmail.com Received: by mail-qv1-xf2c.google.com with SMTP id u16so20819555qvk.4 for ; Wed, 15 Dec 2021 08:47:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=2L5Hr6P8DTPhqkqTf/e0VoHVyUr3RccmqpoL0tSFRcw=; b=VYkcyc4TPJt/ohUkJj9l9H7vWPeuujk7p7JKBns4j3C/JR1uBy2BfKjbXhmYK98Fck gJlQg12xpOy8unVj3+CVaHJruucFQPcfRKeJGIC5QSqEeeZTJqHpFcepHBUE6rXMVlCg rngEIs3wK/JYR17WHhTe7R7D8RQiWfn1tcInpoQxwYhCgZUxcq2b5oybqFCSYdJ47Afy tTEN2eS0TRBYG07Hy5TeKvgmViX1C6b1IaK5uvFUBDvnnltqIcPdFOPyuDQ/SeE758g5 Wdv7JQLS/U1fdxykJYsdcD7UxC+ZCvffbPl5cXdE/GS8awootb32JKNNdiAYmOUj8A4V IQoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=2L5Hr6P8DTPhqkqTf/e0VoHVyUr3RccmqpoL0tSFRcw=; b=mZNvKYVLyj9USNKLNnDIAZsDUrlkMoVrMWA+nq1xIOVsnExB3RV4s+HvTDEc96yPMC c1G+DIQhcpDBvwqNxGJoArIMCDOxbg51iniz1LmCJPWqpknrxNSDNkTvc7JTwkXqtVh/ 83yXbSGD8HuoSxqJwln4fiUrvZPN8oz8IBV6eaSapBf0229q8hk+9k98RFRul8XnEPjj nZ5sJOn9NsmOyvTkWVgWt10u1efOjXch9wekGEJ7X8zew4HmOJs+OL1G0luCohpITrGZ fZB/jsboFl8CE3++NVsBIs+Ygjbs9g5EeJCCfk2M2/bRLcGPQ+RGdV7AcrAdw5TFrZin JMUw== X-Gm-Message-State: AOAM5322SXiuCLXRXsHsUX6JlJHMkW0Buxt0vsIBk6INR3/KV6WkwZ0D RUdbHb/YEVKgII8Vf+3tE1IE28kEIGw= X-Google-Smtp-Source: ABdhPJweP99Vcoo7jKkYNoiH/7D4uA/ABFIG76vgz/+IpZ3gD3O5MJBQHvUMmGkvuHzTVjb4tjh5+g== X-Received: by 2002:a05:6214:c65:: with SMTP id t5mr11906596qvj.27.1639586844404; Wed, 15 Dec 2021 08:47:24 -0800 (PST) Received: from godwin.fios-router.home (pool-108-18-207-184.washdc.fios.verizon.net. [108.18.207.184]) by smtp.gmail.com with ESMTPSA id t11sm1328115qkp.56.2021.12.15.08.47.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Dec 2021 08:47:23 -0800 (PST) From: Sean Anderson To: u-boot@lists.denx.de Cc: Tero Kristo , Lukasz Majewski , Tom Rini , Sean Anderson Subject: [PATCH v2 1/2] clk: cdce9xx: Convert .of_xlate to .request Date: Wed, 15 Dec 2021 11:47:17 -0500 Message-Id: <20211215164718.2778664-1-seanga2@gmail.com> X-Mailer: git-send-email 2.33.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.38 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean This xlate function just performs some checking. We can do this in request() instead and use the default xlate. Signed-off-by: Sean Anderson --- Changes in v2: - Fix build error caused by mismatched function name drivers/clk/clk-cdce9xx.c | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/drivers/clk/clk-cdce9xx.c b/drivers/clk/clk-cdce9xx.c index 6634b7b799..f23465d7e1 100644 --- a/drivers/clk/clk-cdce9xx.c +++ b/drivers/clk/clk-cdce9xx.c @@ -86,19 +86,13 @@ static int cdce9xx_reg_write(struct udevice *dev, u8 addr, u8 val) return ret; } -static int cdce9xx_clk_of_xlate(struct clk *clk, - struct ofnode_phandle_args *args) +static int cdce9xx_clk_request(struct clk *clk) { struct cdce9xx_clk_data *data = dev_get_priv(clk->dev); - if (args->args_count != 1) + if (clk->id > data->chip->num_outputs) return -EINVAL; - if (args->args[0] > data->chip->num_outputs) - return -EINVAL; - - clk->id = args->args[0]; - return 0; } @@ -241,7 +235,7 @@ static const struct udevice_id cdce9xx_clk_of_match[] = { }; static const struct clk_ops cdce9xx_clk_ops = { - .of_xlate = cdce9xx_clk_of_xlate, + .request = cdce9xx_clk_request, .get_rate = cdce9xx_clk_get_rate, .set_rate = cdce9xx_clk_set_rate, }; -- 2.33.0