Content-Type: multipart/mixed; boundary="===============3585217165486722903==" MIME-Version: 1.0 From: kernel test robot To: kbuild-all@lists.01.org Subject: Re: [PATCH v3] drm/amdgpu: introduce new amdgpu_fence object to indicate the job embedded fence Date: Wed, 15 Dec 2021 21:30:31 +0800 Message-ID: <202112152115.sqAqnvG7-lkp@intel.com> In-Reply-To: <20211215063551.2810601-1-ray.huang@amd.com> List-Id: --===============3585217165486722903== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Hi Huang, I love your patch! Perhaps something to improve: [auto build test WARNING on drm/drm-next] [also build test WARNING on drm-intel/for-linux-next drm-tip/drm-tip v5.16-= rc5 next-20211214] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Huang-Rui/drm-amdgpu-intro= duce-new-amdgpu_fence-object-to-indicate-the-job-embedded-fence/20211215-14= 3731 base: git://anongit.freedesktop.org/drm/drm drm-next config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/202112= 15/202112152115.sqAqnvG7-lkp(a)intel.com/config) compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 reproduce (this is a W=3D1 build): # https://github.com/0day-ci/linux/commit/a47becf231b123760625c4524= 2e89f5e5b5b4915 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Huang-Rui/drm-amdgpu-introduce-new= -amdgpu_fence-object-to-indicate-the-job-embedded-fence/20211215-143731 git checkout a47becf231b123760625c45242e89f5e5b5b4915 # save the config file to linux build tree mkdir build_dir make W=3D1 O=3Dbuild_dir ARCH=3Dx86_64 SHELL=3D/bin/bash drivers/gp= u/drm/amd/amdgpu/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All warnings (new ones prefixed by >>): >> drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c:631: warning: expecting protot= ype for amdgpu_fence_clear_job_fences(). Prototype was for amdgpu_fence_dri= ver_clear_job_fences() instead vim +631 drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c 623 = 624 /** 625 * amdgpu_fence_clear_job_fences - clear job embedded fences of ring 626 * 627 * @ring: fence of the ring to be cleared 628 * 629 */ 630 void amdgpu_fence_driver_clear_job_fences(struct amdgpu_ring *ring) > 631 { 632 int i; 633 struct dma_fence *old, **ptr; 634 = 635 for (i =3D 0; i <=3D ring->fence_drv.num_fences_mask; i++) { 636 ptr =3D &ring->fence_drv.fences[i]; 637 old =3D rcu_dereference_protected(*ptr, 1); 638 if (old && old->ops =3D=3D &amdgpu_job_fence_ops) 639 RCU_INIT_POINTER(*ptr, NULL); 640 } 641 } 642 = --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org --===============3585217165486722903==--