Content-Type: multipart/mixed; boundary="===============6506604500052585769==" MIME-Version: 1.0 From: kernel test robot To: kbuild-all@lists.01.org Subject: Re: [PATCH v5 07/11] powerpc/mm: Use generic_get_unmapped_area() and call it from arch_get_unmapped_area() Date: Thu, 16 Dec 2021 05:26:25 +0800 Message-ID: <202112160557.ANnYN1ZQ-lkp@intel.com> In-Reply-To: <686895764befff16e9dbc2989e8f8eb2284b38d6.1639550392.git.christophe.leroy@csgroup.eu> List-Id: --===============6506604500052585769== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Hi Christophe, I love your patch! Perhaps something to improve: [auto build test WARNING on powerpc/next] [also build test WARNING on next-20211214] [cannot apply to hnaz-mm/master arm64/for-next/core linus/master v5.16-rc5] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Christophe-Leroy/Convert-p= owerpc-to-default-topdown-mmap-layout/20211215-144700 base: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git n= ext config: powerpc64-randconfig-m031-20211214 (https://download.01.org/0day-ci= /archive/20211216/202112160557.ANnYN1ZQ-lkp(a)intel.com/config) compiler: powerpc64-linux-gcc (GCC) 11.2.0 reproduce (this is a W=3D1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/= make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/6b1717476e74918c79cc7d76b= 009a9e0424a4414 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Christophe-Leroy/Convert-powerpc-t= o-default-topdown-mmap-layout/20211215-144700 git checkout 6b1717476e74918c79cc7d76b009a9e0424a4414 # save the config file to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=3D$HOME/0day COMPILER=3Dgcc-11.2.0 make.cross= O=3Dbuild_dir ARCH=3Dpowerpc SHELL=3D/bin/bash If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All warnings (new ones prefixed by >>): In file included from arch/powerpc/include/asm/processor.h:71, from arch/powerpc/include/asm/thread_info.h:40, from include/linux/thread_info.h:60, from include/asm-generic/preempt.h:5, from ./arch/powerpc/include/generated/asm/preempt.h:1, from include/linux/preempt.h:78, from include/linux/spinlock.h:55, from include/linux/mmzone.h:8, from include/linux/gfp.h:6, from include/linux/slab.h:15, from mm/mmap.c:13: mm/mmap.c: In function 'generic_get_unmapped_area': >> arch/powerpc/include/asm/task_size_64.h:84:32: warning: suggest parenthe= ses around '&&' within '||' [-Wparentheses] 84 | ((flags) & MAP_FIXED) && ((addr) + (len) > DEFAULT_MAP_= WINDOW) ? TASK_SIZE : \ | ~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~= ~~~~~~~ mm/mmap.c:2142:40: note: in expansion of macro 'arch_get_mmap_end' 2142 | const unsigned long mmap_end =3D arch_get_mmap_end(addr,= len, flags); | ^~~~~~~~~~~~~~~~~ mm/mmap.c: In function 'generic_get_unmapped_area_topdown': >> arch/powerpc/include/asm/task_size_64.h:84:32: warning: suggest parenthe= ses around '&&' within '||' [-Wparentheses] 84 | ((flags) & MAP_FIXED) && ((addr) + (len) > DEFAULT_MAP_= WINDOW) ? TASK_SIZE : \ | ~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~= ~~~~~~~ mm/mmap.c:2190:40: note: in expansion of macro 'arch_get_mmap_end' 2190 | const unsigned long mmap_end =3D arch_get_mmap_end(addr,= len, flags); | ^~~~~~~~~~~~~~~~~ vim +84 arch/powerpc/include/asm/task_size_64.h 78 = 79 #define arch_get_mmap_base(addr, base) \ 80 (((addr) > DEFAULT_MAP_WINDOW) ? (base) + TASK_SIZE - DEFAULT_MAP_W= INDOW : (base)) 81 = 82 #define arch_get_mmap_end(addr, len, flags) \ 83 (((addr) > DEFAULT_MAP_WINDOW) || \ > 84 ((flags) & MAP_FIXED) && ((addr) + (len) > DEFAULT_MAP_WINDOW) ? T= ASK_SIZE : \ 85 DEFAULT_MAP_WINDOW) 86 = --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org --===============6506604500052585769==--