Content-Type: multipart/mixed; boundary="===============6277971101029493258==" MIME-Version: 1.0 From: kernel test robot To: kbuild-all@lists.01.org Subject: Re: [PATCH] pinctrl: add one more "const" for generic function groups Date: Thu, 16 Dec 2021 09:00:05 +0800 Message-ID: <202112160816.btxt2IyR-lkp@intel.com> In-Reply-To: <20211215174821.21668-1-zajec5@gmail.com> List-Id: --===============6277971101029493258== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Hi "Rafa=C5=82, I love your patch! Yet something to improve: [auto build test ERROR on linusw-pinctrl/devel] [also build test ERROR on v5.16-rc5 next-20211214] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Rafa-Mi-ecki/pinctrl-add-o= ne-more-const-for-generic-function-groups/20211216-014859 base: https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctr= l.git devel config: arm64-randconfig-r031-20211215 (https://download.01.org/0day-ci/arc= hive/20211216/202112160816.btxt2IyR-lkp(a)intel.com/config) compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project dd245b= ab9fbb364faa1581e4f92ba3119a872fba) reproduce (this is a W=3D1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/= make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install arm64 cross compiling tool for clang build # apt-get install binutils-aarch64-linux-gnu # https://github.com/0day-ci/linux/commit/e4338a6ad34998afb60c5ad29= 4aafa06cd7110a7 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Rafa-Mi-ecki/pinctrl-add-one-more-= const-for-generic-function-groups/20211216-014859 git checkout e4338a6ad34998afb60c5ad294aafa06cd7110a7 # save the config file to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=3D$HOME/0day COMPILER=3Dclang make.cross W=3D= 1 O=3Dbuild_dir ARCH=3Darm64 SHELL=3D/bin/bash drivers/pinctrl/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All errors (new ones prefixed by >>): >> drivers/pinctrl/pinctrl-keembay.c:1594:8: error: assigning to 'const cha= r **' from 'const char *const *' discards qualifiers [-Werror,-Wincompatibl= e-pointer-types-discards-qualifiers] grp =3D func->group_names; ^ ~~~~~~~~~~~~~~~~~ 1 error generated. -- >> drivers/pinctrl/freescale/pinctrl-imx.c:672:24: error: read-only variabl= e is not assignable func->group_names[i] =3D child->name; ~~~~~~~~~~~~~~~~~~~~ ^ 1 error generated. vim +1594 drivers/pinctrl/pinctrl-keembay.c ffd4e739358be0 Lakshmi Sowjanya D 2021-08-06 1556 = ffd4e739358be0 Lakshmi Sowjanya D 2021-08-06 1557 static int keembay_add_= functions(struct keembay_pinctrl *kpc, ffd4e739358be0 Lakshmi Sowjanya D 2021-08-06 1558 struct function_de= sc *function) ffd4e739358be0 Lakshmi Sowjanya D 2021-08-06 1559 { ffd4e739358be0 Lakshmi Sowjanya D 2021-08-06 1560 unsigned int i; ffd4e739358be0 Lakshmi Sowjanya D 2021-08-06 1561 = ffd4e739358be0 Lakshmi Sowjanya D 2021-08-06 1562 /* Assign the groups f= or each function */ ffd4e739358be0 Lakshmi Sowjanya D 2021-08-06 1563 for (i =3D 0; i < kpc-= >npins; i++) { ffd4e739358be0 Lakshmi Sowjanya D 2021-08-06 1564 const struct pinctrl_= pin_desc *pdesc =3D keembay_pins + i; ffd4e739358be0 Lakshmi Sowjanya D 2021-08-06 1565 struct keembay_mux_de= sc *mux =3D pdesc->drv_data; ffd4e739358be0 Lakshmi Sowjanya D 2021-08-06 1566 = ffd4e739358be0 Lakshmi Sowjanya D 2021-08-06 1567 while (mux->name) { ffd4e739358be0 Lakshmi Sowjanya D 2021-08-06 1568 struct function_desc= *func; ffd4e739358be0 Lakshmi Sowjanya D 2021-08-06 1569 const char **grp; ffd4e739358be0 Lakshmi Sowjanya D 2021-08-06 1570 size_t grp_size; ffd4e739358be0 Lakshmi Sowjanya D 2021-08-06 1571 u32 j, grp_num; ffd4e739358be0 Lakshmi Sowjanya D 2021-08-06 1572 = ffd4e739358be0 Lakshmi Sowjanya D 2021-08-06 1573 for (j =3D 0; j < kp= c->nfuncs; j++) { ffd4e739358be0 Lakshmi Sowjanya D 2021-08-06 1574 if (!strcmp(mux->na= me, function[j].name)) ffd4e739358be0 Lakshmi Sowjanya D 2021-08-06 1575 break; ffd4e739358be0 Lakshmi Sowjanya D 2021-08-06 1576 } ffd4e739358be0 Lakshmi Sowjanya D 2021-08-06 1577 = ffd4e739358be0 Lakshmi Sowjanya D 2021-08-06 1578 if (j =3D=3D kpc->nf= uncs) ffd4e739358be0 Lakshmi Sowjanya D 2021-08-06 1579 return -EINVAL; ffd4e739358be0 Lakshmi Sowjanya D 2021-08-06 1580 = ffd4e739358be0 Lakshmi Sowjanya D 2021-08-06 1581 func =3D function + = j; ffd4e739358be0 Lakshmi Sowjanya D 2021-08-06 1582 grp_num =3D func->nu= m_group_names; ffd4e739358be0 Lakshmi Sowjanya D 2021-08-06 1583 grp_size =3D sizeof(= *func->group_names); ffd4e739358be0 Lakshmi Sowjanya D 2021-08-06 1584 = ffd4e739358be0 Lakshmi Sowjanya D 2021-08-06 1585 if (!func->group_nam= es) { ffd4e739358be0 Lakshmi Sowjanya D 2021-08-06 1586 func->group_names = =3D devm_kcalloc(kpc->dev, ffd4e739358be0 Lakshmi Sowjanya D 2021-08-06 1587 grp_num, ffd4e739358be0 Lakshmi Sowjanya D 2021-08-06 1588 grp_size, ffd4e739358be0 Lakshmi Sowjanya D 2021-08-06 1589 GFP_KERNEL); ffd4e739358be0 Lakshmi Sowjanya D 2021-08-06 1590 if (!func->group_na= mes) ffd4e739358be0 Lakshmi Sowjanya D 2021-08-06 1591 return -ENOMEM; ffd4e739358be0 Lakshmi Sowjanya D 2021-08-06 1592 } ffd4e739358be0 Lakshmi Sowjanya D 2021-08-06 1593 = ffd4e739358be0 Lakshmi Sowjanya D 2021-08-06 @1594 grp =3D func->group_= names; ffd4e739358be0 Lakshmi Sowjanya D 2021-08-06 1595 while (*grp) ffd4e739358be0 Lakshmi Sowjanya D 2021-08-06 1596 grp++; ffd4e739358be0 Lakshmi Sowjanya D 2021-08-06 1597 = ffd4e739358be0 Lakshmi Sowjanya D 2021-08-06 1598 *grp =3D pdesc->name; ffd4e739358be0 Lakshmi Sowjanya D 2021-08-06 1599 mux++; ffd4e739358be0 Lakshmi Sowjanya D 2021-08-06 1600 } ffd4e739358be0 Lakshmi Sowjanya D 2021-08-06 1601 } ffd4e739358be0 Lakshmi Sowjanya D 2021-08-06 1602 = ffd4e739358be0 Lakshmi Sowjanya D 2021-08-06 1603 /* Add all functions */ ffd4e739358be0 Lakshmi Sowjanya D 2021-08-06 1604 for (i =3D 0; i < kpc-= >nfuncs; i++) { ffd4e739358be0 Lakshmi Sowjanya D 2021-08-06 1605 pinmux_generic_add_fu= nction(kpc->pctrl, ffd4e739358be0 Lakshmi Sowjanya D 2021-08-06 1606 function[i].na= me, ffd4e739358be0 Lakshmi Sowjanya D 2021-08-06 1607 function[i].gr= oup_names, ffd4e739358be0 Lakshmi Sowjanya D 2021-08-06 1608 function[i].nu= m_group_names, ffd4e739358be0 Lakshmi Sowjanya D 2021-08-06 1609 function[i].da= ta); ffd4e739358be0 Lakshmi Sowjanya D 2021-08-06 1610 } ffd4e739358be0 Lakshmi Sowjanya D 2021-08-06 1611 = ffd4e739358be0 Lakshmi Sowjanya D 2021-08-06 1612 return 0; ffd4e739358be0 Lakshmi Sowjanya D 2021-08-06 1613 } ffd4e739358be0 Lakshmi Sowjanya D 2021-08-06 1614 = --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org --===============6277971101029493258==--