Content-Type: multipart/mixed; boundary="===============1832315502986068839==" MIME-Version: 1.0 From: kernel test robot To: kbuild-all@lists.01.org Subject: Re: [PATCH] pinctrl: add one more "const" for generic function groups Date: Fri, 17 Dec 2021 12:04:06 +0800 Message-ID: <202112171229.i6D3onAx-lkp@intel.com> In-Reply-To: <20211215174821.21668-1-zajec5@gmail.com> List-Id: --===============1832315502986068839== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Hi "Rafa=C5=82, I love your patch! Perhaps something to improve: [auto build test WARNING on linusw-pinctrl/devel] [also build test WARNING on v5.16-rc5 next-20211215] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Rafa-Mi-ecki/pinctrl-add-o= ne-more-const-for-generic-function-groups/20211216-014859 base: https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctr= l.git devel config: arm64-randconfig-s031-20211216 (https://download.01.org/0day-ci/arc= hive/20211217/202112171229.i6D3onAx-lkp(a)intel.com/config) compiler: aarch64-linux-gcc (GCC) 11.2.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/= make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # apt-get install sparse # sparse version: v0.6.4-dirty # https://github.com/0day-ci/linux/commit/e4338a6ad34998afb60c5ad29= 4aafa06cd7110a7 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Rafa-Mi-ecki/pinctrl-add-one-more-= const-for-generic-function-groups/20211216-014859 git checkout e4338a6ad34998afb60c5ad294aafa06cd7110a7 # save the config file to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=3D$HOME/0day COMPILER=3Dgcc-11.2.0 make.cross= C=3D1 CF=3D'-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=3Dbuild_dir ARCH=3Da= rm64 SHELL=3D/bin/bash drivers/pinctrl/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot sparse warnings: (new ones prefixed by >>) >> drivers/pinctrl/pinctrl-keembay.c:1594:29: sparse: sparse: incorrect typ= e in assignment (different modifiers) @@ expected char const **grp @@ = got char const *const *group_names @@ drivers/pinctrl/pinctrl-keembay.c:1594:29: sparse: expected char con= st **grp drivers/pinctrl/pinctrl-keembay.c:1594:29: sparse: got char const *c= onst *group_names vim +1594 drivers/pinctrl/pinctrl-keembay.c ffd4e739358be03 Lakshmi Sowjanya D 2021-08-06 1556 = ffd4e739358be03 Lakshmi Sowjanya D 2021-08-06 1557 static int keembay_add= _functions(struct keembay_pinctrl *kpc, ffd4e739358be03 Lakshmi Sowjanya D 2021-08-06 1558 struct function_d= esc *function) ffd4e739358be03 Lakshmi Sowjanya D 2021-08-06 1559 { ffd4e739358be03 Lakshmi Sowjanya D 2021-08-06 1560 unsigned int i; ffd4e739358be03 Lakshmi Sowjanya D 2021-08-06 1561 = ffd4e739358be03 Lakshmi Sowjanya D 2021-08-06 1562 /* Assign the groups = for each function */ ffd4e739358be03 Lakshmi Sowjanya D 2021-08-06 1563 for (i =3D 0; i < kpc= ->npins; i++) { ffd4e739358be03 Lakshmi Sowjanya D 2021-08-06 1564 const struct pinctrl= _pin_desc *pdesc =3D keembay_pins + i; ffd4e739358be03 Lakshmi Sowjanya D 2021-08-06 1565 struct keembay_mux_d= esc *mux =3D pdesc->drv_data; ffd4e739358be03 Lakshmi Sowjanya D 2021-08-06 1566 = ffd4e739358be03 Lakshmi Sowjanya D 2021-08-06 1567 while (mux->name) { ffd4e739358be03 Lakshmi Sowjanya D 2021-08-06 1568 struct function_des= c *func; ffd4e739358be03 Lakshmi Sowjanya D 2021-08-06 1569 const char **grp; ffd4e739358be03 Lakshmi Sowjanya D 2021-08-06 1570 size_t grp_size; ffd4e739358be03 Lakshmi Sowjanya D 2021-08-06 1571 u32 j, grp_num; ffd4e739358be03 Lakshmi Sowjanya D 2021-08-06 1572 = ffd4e739358be03 Lakshmi Sowjanya D 2021-08-06 1573 for (j =3D 0; j < k= pc->nfuncs; j++) { ffd4e739358be03 Lakshmi Sowjanya D 2021-08-06 1574 if (!strcmp(mux->n= ame, function[j].name)) ffd4e739358be03 Lakshmi Sowjanya D 2021-08-06 1575 break; ffd4e739358be03 Lakshmi Sowjanya D 2021-08-06 1576 } ffd4e739358be03 Lakshmi Sowjanya D 2021-08-06 1577 = ffd4e739358be03 Lakshmi Sowjanya D 2021-08-06 1578 if (j =3D=3D kpc->n= funcs) ffd4e739358be03 Lakshmi Sowjanya D 2021-08-06 1579 return -EINVAL; ffd4e739358be03 Lakshmi Sowjanya D 2021-08-06 1580 = ffd4e739358be03 Lakshmi Sowjanya D 2021-08-06 1581 func =3D function += j; ffd4e739358be03 Lakshmi Sowjanya D 2021-08-06 1582 grp_num =3D func->n= um_group_names; ffd4e739358be03 Lakshmi Sowjanya D 2021-08-06 1583 grp_size =3D sizeof= (*func->group_names); ffd4e739358be03 Lakshmi Sowjanya D 2021-08-06 1584 = ffd4e739358be03 Lakshmi Sowjanya D 2021-08-06 1585 if (!func->group_na= mes) { ffd4e739358be03 Lakshmi Sowjanya D 2021-08-06 1586 func->group_names = =3D devm_kcalloc(kpc->dev, ffd4e739358be03 Lakshmi Sowjanya D 2021-08-06 1587 grp_num, ffd4e739358be03 Lakshmi Sowjanya D 2021-08-06 1588 grp_size, ffd4e739358be03 Lakshmi Sowjanya D 2021-08-06 1589 GFP_KERNEL); ffd4e739358be03 Lakshmi Sowjanya D 2021-08-06 1590 if (!func->group_n= ames) ffd4e739358be03 Lakshmi Sowjanya D 2021-08-06 1591 return -ENOMEM; ffd4e739358be03 Lakshmi Sowjanya D 2021-08-06 1592 } ffd4e739358be03 Lakshmi Sowjanya D 2021-08-06 1593 = ffd4e739358be03 Lakshmi Sowjanya D 2021-08-06 @1594 grp =3D func->group= _names; ffd4e739358be03 Lakshmi Sowjanya D 2021-08-06 1595 while (*grp) ffd4e739358be03 Lakshmi Sowjanya D 2021-08-06 1596 grp++; ffd4e739358be03 Lakshmi Sowjanya D 2021-08-06 1597 = ffd4e739358be03 Lakshmi Sowjanya D 2021-08-06 1598 *grp =3D pdesc->nam= e; ffd4e739358be03 Lakshmi Sowjanya D 2021-08-06 1599 mux++; ffd4e739358be03 Lakshmi Sowjanya D 2021-08-06 1600 } ffd4e739358be03 Lakshmi Sowjanya D 2021-08-06 1601 } ffd4e739358be03 Lakshmi Sowjanya D 2021-08-06 1602 = ffd4e739358be03 Lakshmi Sowjanya D 2021-08-06 1603 /* Add all functions = */ ffd4e739358be03 Lakshmi Sowjanya D 2021-08-06 1604 for (i =3D 0; i < kpc= ->nfuncs; i++) { ffd4e739358be03 Lakshmi Sowjanya D 2021-08-06 1605 pinmux_generic_add_f= unction(kpc->pctrl, ffd4e739358be03 Lakshmi Sowjanya D 2021-08-06 1606 function[i].n= ame, ffd4e739358be03 Lakshmi Sowjanya D 2021-08-06 1607 function[i].g= roup_names, ffd4e739358be03 Lakshmi Sowjanya D 2021-08-06 1608 function[i].n= um_group_names, ffd4e739358be03 Lakshmi Sowjanya D 2021-08-06 1609 function[i].d= ata); ffd4e739358be03 Lakshmi Sowjanya D 2021-08-06 1610 } ffd4e739358be03 Lakshmi Sowjanya D 2021-08-06 1611 = ffd4e739358be03 Lakshmi Sowjanya D 2021-08-06 1612 return 0; ffd4e739358be03 Lakshmi Sowjanya D 2021-08-06 1613 } ffd4e739358be03 Lakshmi Sowjanya D 2021-08-06 1614 = --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org --===============1832315502986068839==--