Content-Type: multipart/mixed; boundary="===============7988250703515634911==" MIME-Version: 1.0 From: kernel test robot To: kbuild-all@lists.01.org Subject: Re: [RFC Patch v3 3/3] net_sched: introduce eBPF based Qdisc Date: Sun, 26 Dec 2021 16:47:46 +0800 Message-ID: <202112261603.pryQwYQT-lkp@intel.com> In-Reply-To: <20211224200059.161979-4-xiyou.wangcong@gmail.com> List-Id: --===============7988250703515634911== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Hi Cong, [FYI, it's a private test report for your RFC patch.] [auto build test WARNING on bpf-next/master] [also build test WARNING on net-next/master next-20211224] [cannot apply to bpf/master net/master horms-ipvs/master linus/master v5.16= -rc6] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Cong-Wang/net_sched-introd= uce-eBPF-based-Qdisc/20211225-040205 base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git ma= ster config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/202112= 26/202112261603.pryQwYQT-lkp(a)intel.com/config) compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 reproduce (this is a W=3D1 build): # https://github.com/0day-ci/linux/commit/3281415061bcf1a15f10b0a75= 0d35ad9de23b469 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Cong-Wang/net_sched-introduce-eBPF= -based-Qdisc/20211225-040205 git checkout 3281415061bcf1a15f10b0a750d35ad9de23b469 # save the config file to linux build tree mkdir build_dir make W=3D1 O=3Dbuild_dir ARCH=3Dx86_64 SHELL=3D/bin/bash drivers/gp= io/ net/key/ net/sched/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All warnings (new ones prefixed by >>): >> net/sched/sch_bpf.c:458:5: warning: no previous prototype for 'bpf_skb_c= lassify' [-Wmissing-prototypes] 458 | u32 bpf_skb_classify(struct sk_buff *skb, int ifindex, u32 handl= e) | ^~~~~~~~~~~~~~~~ vim +/bpf_skb_classify +458 net/sched/sch_bpf.c 457 = > 458 u32 bpf_skb_classify(struct sk_buff *skb, int ifindex, u32 handle) 459 { 460 struct net *net =3D dev_net(skb->dev); 461 struct tcf_result res =3D {}; 462 struct sch_bpf_qdisc *q; 463 struct net_device *dev; 464 struct tcf_proto *tcf; 465 struct Qdisc *sch; 466 int result; 467 = 468 rcu_read_lock(); 469 dev =3D dev_get_by_index_rcu(net, ifindex); 470 if (!dev) { 471 rcu_read_unlock(); 472 return 0; 473 } 474 sch =3D qdisc_lookup_rcu(dev, handle); 475 if (!sch) { 476 rcu_read_unlock(); 477 return 0; 478 } 479 if (sch->ops !=3D &sch_bpf_qdisc_ops) { 480 rcu_read_unlock(); 481 return 0; 482 } 483 q =3D qdisc_priv(sch); 484 tcf =3D rcu_dereference_bh(q->filter_list); 485 if (!tcf) { 486 rcu_read_unlock(); 487 return 0; 488 } 489 result =3D tcf_classify(skb, NULL, tcf, &res, false); 490 if (result >=3D 0) { 491 #ifdef CONFIG_NET_CLS_ACT 492 switch (result) { 493 case TC_ACT_QUEUED: 494 case TC_ACT_STOLEN: 495 case TC_ACT_TRAP: 496 fallthrough; 497 case TC_ACT_SHOT: 498 rcu_read_unlock(); 499 return 0; 500 } 501 #endif 502 } 503 rcu_read_unlock(); 504 return res.class; 505 } 506 = --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org --===============7988250703515634911==--