Content-Type: multipart/mixed; boundary="===============2580605190819062054==" MIME-Version: 1.0 From: kernel test robot To: kbuild-all@lists.01.org Subject: Re: [PATCH v1 19/23] cachefiles: implement .demand_read() for demand read Date: Mon, 27 Dec 2021 23:32:21 +0800 Message-ID: <202112272340.1ho7sEjG-lkp@intel.com> In-Reply-To: <20211227125444.21187-20-jefflexu@linux.alibaba.com> List-Id: --===============2580605190819062054== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Hi Jeffle, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on dhowells-fs/fscache-next] [cannot apply to xiang-erofs/dev-test ceph-client/for-linus linus/master v5= .16-rc7 next-20211224] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Jeffle-Xu/fscache-erofs-fs= cache-based-demand-read-semantics/20211227-205742 base: https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.g= it fscache-next config: csky-defconfig (https://download.01.org/0day-ci/archive/20211227/20= 2112272340.1ho7sEjG-lkp(a)intel.com/config) compiler: csky-linux-gcc (GCC) 11.2.0 reproduce (this is a W=3D1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/= make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/54c300b4598e3f2836d823368= 1da387fe388cfda git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Jeffle-Xu/fscache-erofs-fscache-ba= sed-demand-read-semantics/20211227-205742 git checkout 54c300b4598e3f2836d8233681da387fe388cfda # save the config file to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=3D$HOME/0day COMPILER=3Dgcc-11.2.0 make.cross= O=3Dbuild_dir ARCH=3Dcsky SHELL=3D/bin/bash fs/cachefiles/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All warnings (new ones prefixed by >>): fs/cachefiles/io.c:564:5: warning: no previous prototype for 'cachefiles= _demand_read' [-Wmissing-prototypes] 564 | int cachefiles_demand_read(struct netfs_cache_resources *cres, | ^~~~~~~~~~~~~~~~~~~~~~ In function 'cachefiles_alloc_req', inlined from 'cachefiles_demand_read' at fs/cachefiles/io.c:575:8: >> fs/cachefiles/io.c:557:9: warning: 'strncpy' specified bound 255 equals = destination size [-Wstringop-truncation] 557 | strncpy(req_in->path, object->d_name, sizeof(req_in->pat= h)); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~= ~~~ vim +/strncpy +557 fs/cachefiles/io.c 541 = 542 static struct cachefiles_req *cachefiles_alloc_req(struct cachefiles= _object *object, 543 loff_t start_pos, 544 size_t len) 545 { 546 struct cachefiles_req *req; 547 struct cachefiles_req_in *req_in; 548 = 549 req =3D kzalloc(sizeof(*req), GFP_KERNEL); 550 if (!req) 551 return NULL; 552 = 553 req_in =3D &req->req_in; 554 = 555 req_in->off =3D start_pos; 556 req_in->len =3D len; > 557 strncpy(req_in->path, object->d_name, sizeof(req_in->path)); 558 = 559 init_completion(&req->done); 560 = 561 return req; 562 } 563 = --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org --===============2580605190819062054==--