Content-Type: multipart/mixed; boundary="===============0573787530728316004==" MIME-Version: 1.0 From: kernel test robot To: kbuild-all@lists.01.org Subject: Re: [PATCH v1 19/23] cachefiles: implement .demand_read() for demand read Date: Mon, 27 Dec 2021 23:55:48 +0800 Message-ID: <202112272353.ekKESQX6-lkp@intel.com> In-Reply-To: <20211227125444.21187-20-jefflexu@linux.alibaba.com> List-Id: --===============0573787530728316004== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Hi Jeffle, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on dhowells-fs/fscache-next] [cannot apply to xiang-erofs/dev-test ceph-client/for-linus linus/master v5= .16-rc7 next-20211224] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Jeffle-Xu/fscache-erofs-fs= cache-based-demand-read-semantics/20211227-205742 base: https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.g= it fscache-next config: i386-randconfig-r005-20211227 (https://download.01.org/0day-ci/arch= ive/20211227/202112272353.ekKESQX6-lkp(a)intel.com/config) compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 511726= c64d3b6cca66f7c54d457d586aa3129f67) reproduce (this is a W=3D1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/= make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/54c300b4598e3f2836d823368= 1da387fe388cfda git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Jeffle-Xu/fscache-erofs-fscache-ba= sed-demand-read-semantics/20211227-205742 git checkout 54c300b4598e3f2836d8233681da387fe388cfda # save the config file to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=3D$HOME/0day COMPILER=3Dclang make.cross W=3D= 1 O=3Dbuild_dir ARCH=3Di386 SHELL=3D/bin/bash fs/cachefiles/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All warnings (new ones prefixed by >>): >> fs/cachefiles/io.c:564:5: warning: no previous prototype for function 'c= achefiles_demand_read' [-Wmissing-prototypes] int cachefiles_demand_read(struct netfs_cache_resources *cres, ^ fs/cachefiles/io.c:564:1: note: declare 'static' if the function is not = intended to be used outside of this translation unit int cachefiles_demand_read(struct netfs_cache_resources *cres, ^ static = 1 warning generated. vim +/cachefiles_demand_read +564 fs/cachefiles/io.c 563 = > 564 int cachefiles_demand_read(struct netfs_cache_resources *cres, 565 loff_t start_pos, size_t len) 566 { 567 struct cachefiles_object *object; 568 struct cachefiles_cache *cache; 569 struct cachefiles_req *req; 570 int ret; 571 = 572 object =3D cachefiles_cres_object(cres); 573 cache =3D object->volume->cache; 574 = 575 req =3D cachefiles_alloc_req(object, start_pos, len); 576 if (!req) 577 return -ENOMEM; 578 = 579 spin_lock(&cache->reqs_lock); 580 ret =3D idr_alloc(&cache->reqs, req, 0, 0, GFP_KERNEL); 581 if (ret >=3D 0) 582 req->req_in.id =3D ret; 583 spin_unlock(&cache->reqs_lock); 584 if (ret < 0) { 585 kfree(req); 586 return -ENOMEM; 587 } 588 = 589 wake_up_all(&cache->daemon_pollwq); 590 = 591 wait_for_completion(&req->done); 592 kfree(req); 593 = 594 return 0; 595 } 596 = --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org --===============0573787530728316004==--