Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A4023C433F5 for ; Fri, 7 Jan 2022 22:43:01 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 6FB74830BE; Fri, 7 Jan 2022 23:42:59 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="a6aDFtda"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id A25B8834DE; Fri, 7 Jan 2022 23:42:57 +0100 (CET) Received: from mail-qt1-x829.google.com (mail-qt1-x829.google.com [IPv6:2607:f8b0:4864:20::829]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 496A88309C for ; Fri, 7 Jan 2022 23:42:53 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x829.google.com with SMTP id q14so6967233qtx.10 for ; Fri, 07 Jan 2022 14:42:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=FbxuvvnGDsjNkUFfZsjN4V1t20740re/kXNwkf3QQbI=; b=a6aDFtda5vyYtmbQ7iymvtgVBXfKxY13gwBAMNGVIYRMfvyeXmFPoys+mOXDBAOOnK V99vbrc2QAR6EuGXZb9m/UMQKt3RxJ/fqKgejSvT2QV4H+91jT3zC9462vEklUtowb6t r6TGCNOQdck0ggRs88aSzSyN1yDnnO6USxTrE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=FbxuvvnGDsjNkUFfZsjN4V1t20740re/kXNwkf3QQbI=; b=MdrBj2ltVWGeh46oWRCS/KM7tdA/fsjF19xTQ+SSseGQ0pXI8JoJQ70ti90DNrkBCL s5o5Ctr2ATMZ91mbkAvSBHiX+DHLIr7dWCjA3TEZEckEOoKlKd933wTcigXWigNB853a TCBk8QtYjasYBGhZeD7QMJat8DJFGSNiqO+avLrCLsMlVs2h5+h+d/1FmzQUF42A3loS NY1TAg4fuxwPGS+/QezG34EcUKmHW/Q/ffbfKY46Ont062LtEjwrLw2Dv3TF3249Nwi+ Oad0W0QJRoOQQHd53Q/bkQbdHCpLw+x89P5cifnyTMUQLeM4V+lAW1yXk/ojuY9mELC5 v8SA== X-Gm-Message-State: AOAM533jnnq9vBj+2qm93rn4Ad/StTgDI/+BzZ9EokLxl/luHfbiHjOI J1vvF6u4fkIeb+ROmcA7rHtwGg== X-Google-Smtp-Source: ABdhPJzSskcVppA38bNSXgCO2Lm1RnwLa5LYx4moyhy2cbH9lnvhPWPJg+1nKERJfKRf8ICb0RrWMg== X-Received: by 2002:a05:622a:4ca:: with SMTP id q10mr6368371qtx.238.1641595371832; Fri, 07 Jan 2022 14:42:51 -0800 (PST) Received: from bill-the-cat (2603-6081-7b01-cbda-f174-9b83-85b8-612f.res6.spectrum.com. [2603:6081:7b01:cbda:f174:9b83:85b8:612f]) by smtp.gmail.com with ESMTPSA id u11sm5055398qtw.29.2022.01.07.14.42.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Jan 2022 14:42:51 -0800 (PST) Date: Fri, 7 Jan 2022 17:42:49 -0500 From: Tom Rini To: Marcel Ziswiler Cc: Tim Harvey , Adam Ford , ZHIZHIKIN Andrey , "u-boot@lists.denx.de" Subject: Re: [PATCH] Revert "tree: imx: remove old fit generator script" Message-ID: <20220107224249.GK2773246@bill-the-cat> References: <20220107173751.GE2773246@bill-the-cat> <20220107182550.GF2773246@bill-the-cat> <20220107202700.GH2773246@bill-the-cat> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="+cK5/nwePh61TnYD" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.38 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --+cK5/nwePh61TnYD Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jan 07, 2022 at 11:26:49PM +0100, Marcel Ziswiler wrote: > Hi Tim and Tom >=20 > On Fri, 2022-01-07 at 12:37 -0800, Tim Harvey wrote: > > On Fri, Jan 7, 2022 at 12:27 PM Tom Rini wrote: > > >=20 > > > On Fri, Jan 07, 2022 at 12:24:57PM -0800, Tim Harvey wrote: > > > > On Fri, Jan 7, 2022 at 12:08 PM Adam Ford wrot= e: > > > > >=20 > > > > >=20 > > > > >=20 > > > > > On Fri, Jan 7, 2022 at 12:25 PM Tom Rini wro= te: > > > > > >=20 > > > > > > On Fri, Jan 07, 2022 at 12:21:18PM -0600, Adam Ford wrote: > > > > > > > On Fri, Jan 7, 2022 at 11:38 AM Tom Rini = wrote: > > > > > > >=20 > > > > > > > > On Fri, Jan 07, 2022 at 09:27:05AM -0800, Tim Harvey wrote: > > > > > > > > > On Thu, Jan 6, 2022 at 12:27 PM Tim Harvey > > > > > > > > wrote: > > > > > > > > > >=20 > > > > > > > > > > On Thu, Jan 6, 2022 at 11:18 AM ZHIZHIKIN Andrey > > > > > > > > > > wrote: > > > > > > > > > > >=20 > > > > > > > > > > > Hello Tom, > > > > > > > > > > >=20 > > > > > > > > > > > > -----Original Message----- > > > > > > > > > > > > From: U-Boot On Beha= lf Of Tom Rini > > > > > > > > > > > > Sent: Thursday, January 6, 2022 7:52 PM > > > > > > > > > > > > To: u-boot@lists.denx.de > > > > > > > > > > > > Cc: Tim Harvey > > > > > > > > > > > > Subject: [PATCH] Revert "tree: imx: remove old fit = generator > > > > > > > > script" > > > > > > > > > > > >=20 > > > > > > > > > > > > This reverts commit d9a6f0eed66a39206b13513ec914f14= 084c3bb73. > > > > > > > > > > > >=20 > > > > > > > > > > > > For right now, it's too close to the release to mer= ge the series > > > > > > > > that > > > > > > > > > > > > allows for binman to be used to generate the final = images, and > > > > > > > > also not > > > > > > > > > > > > break CI, and then also merge all of the series tha= t convert > > > > > > > > currently > > > > > > > > > > > > broken platforms to use binman instead.=A0 So, brin= g back this > > > > > > > > script now > > > > > > > > > > > > and remove it again for real after the release. > > > > > > > > > > >=20 > > > > > > > > > > > Please note that this might not work, as the FIT gene= rator script > > > > > > > > would > > > > > > > > > > > generate ITS with '@' symbols which are not compatibl= e with mkimage > > > > > > > > due > > > > > > > > > > > to CVE-2021-27138. This revert should be complemented= with the fix to > > > > > > > > > > > remove those '@' symbols as well. > > > > > > > > > >=20 > > > > > > > > > > Correct, the revert is not enough anymore: > > > > > > > > > > =A0 MKIMAGE u-boot.itb > > > > > > > > > > u-boot.its:7.11-15.5: Warning (unit_address_vs_reg): /i= mages/uboot@1: > > > > > > > > > > node has a unit name, but no reg property > > > > > > > > > > u-boot.its:16.9-21.5: Warning (unit_address_vs_reg): /i= mages/fdt@1: > > > > > > > > > > node has a unit name, but no reg property > > > > > > > > > > u-boot.its:22.9-27.5: Warning (unit_address_vs_reg): /i= mages/fdt@2: > > > > > > > > > > node has a unit name, but no reg property > > > > > > > > > > u-boot.its:28.9-33.5: Warning (unit_address_vs_reg): /i= mages/fdt@3: > > > > > > > > > > node has a unit name, but no reg property > > > > > > > > > > u-boot.its:34.9-39.5: Warning (unit_address_vs_reg): /i= mages/fdt@4: > > > > > > > > > > node has a unit name, but no reg property > > > > > > > > > > u-boot.its:40.9-45.5: Warning (unit_address_vs_reg): /i= mages/fdt@5: > > > > > > > > > > node has a unit name, but no reg property > > > > > > > > > > u-boot.its:46.9-55.5: Warning (unit_address_vs_reg): /i= mages/atf@1: > > > > > > > > > > node has a unit name, but no reg property > > > > > > > > > > u-boot.its:60.12-65.5: Warning (unit_address_vs_reg): > > > > > > > > > > /configurations/config@1: node has a unit name, but no = reg property > > > > > > > > > > u-boot.its:66.12-71.5: Warning (unit_address_vs_reg): > > > > > > > > > > /configurations/config@2: node has a unit name, but no = reg property > > > > > > > > > > u-boot.its:72.12-77.5: Warning (unit_address_vs_reg): > > > > > > > > > > /configurations/config@3: node has a unit name, but no = reg property > > > > > > > > > > u-boot.its:78.12-83.5: Warning (unit_address_vs_reg): > > > > > > > > > > /configurations/config@4: node has a unit name, but no = reg property > > > > > > > > > > u-boot.its:84.12-89.5: Warning (unit_address_vs_reg): > > > > > > > > > > /configurations/config@5: node has a unit name, but no = reg property > > > > > > > > > > ./tools/mkimage: verify_header failed for FIT Image sup= port with exit > > > > > > > > code 1 > > > > > > > > > > Makefile:1433: recipe for target 'u-boot.itb' failed > > > > > > > > > > make: *** [u-boot.itb] Error 1 > > > > > > > > > > make: *** Deleting file 'u-boot.itb' > > > > > > > > > > make: *** Waiting for unfinished jobs.... > > > > > > > > > >=20 > > > > > > > > > > I don't know what had changed to cause this or when (ag= ain, I stopped > > > > > > > > > > worrying about it because I thought we were moving to b= inman for this > > > > > > > > > > release). There was a patch that resolved this from Oli= ver at > > > > > > > > > > https://lists.denx.de/pipermail/u-boot/2021-August/4579= 97.html=A0but I > > > > > > > > > > don't think that fully solves anything 'at this point' = either. > > > > > > > > > >=20 > > > > > > > > > > Even with that applied to current master I then end up = with: > > > > > > > > > > =A0 MKIMAGE flash.bin > > > > > > > > > > ./tools/mkimage: Can't open spl/u-boot-spl-ddr.bin: No = such file or > > > > > > > > directory > > > > > > > > > > arch/arm/mach-imx/Makefile:167: recipe for target 'flas= h.bin' failed > > > > > > > > > > make[1]: *** [flash.bin] Error 1 > > > > > > > > > > make[1]: *** Deleting file 'flash.bin' > > > > > > > > > > Makefile:1526: recipe for target 'flash.bin' failed > > > > > > > > > >=20 > > > > > > > > > > At some point over the past couple of months that patch= resolved the > > > > > > > > > > building issue when using the FIT generator but I also = don't know what > > > > > > > > > > else has changed that now causes that to not work. > > > > > > > > > >=20 > > > > > > > > > > As Tom pointed out in another thread these build failur= es did not get > > > > > > > > > > caught by CI apparently because CI does a 'make all' wh= ich did not > > > > > > > > > > include the FIT images (that was accomplished with the = 'flash.bin' > > > > > > > > > > target prior to binman conversion). > > > > > > > > > >=20 > > > > > > > > > > Is it too late to apply the CI fix and the pending binm= an conversions? > > > > > > > > > >=20 > > > > > > > > > > I know that my series has been reviewed by Marcel [1] a= nd as far as I > > > > > > > > > > know didn't get merged simply because of the CI issue. = It still > > > > > > > > > > applies and produces a valid flash.bin image. > > > > > > > > > > I was also able to merge Peng's series [2] which conver= ts > > > > > > > > > > imx8mq_evk/imx8mq_phanbell/pico-imx8mq to binman and wa= s able to build > > > > > > > > > > flash.bin images for them > > > > > > > > > >=20 > > > > > > > > > > I tried to merge Adam's series that moves imx8mm_beacon= to binman [3] > > > > > > > > > > and imx8mn_beacon to binman [4] but they no longer appl= y due to > > > > > > > > > > defconfig/Kconfig changes > > > > > > > > > >=20 > > > > > > > > > > That still leaves the following unbuildable with > > > > > > > > > > CONFIG_SPL_FIT_GENERATOR =3D "arch/arm/mach-imx/mkimage= _fit_atf.sh": > > > > > > > > > >=20 > > > > > > > > configs/cgtqmx8_defconfig:CONFIG_SPL_FIT_GENERATOR=3D"arch/= arm/mach-imx/mkimage_fit_atf.sh" > > > > > > > > > >=20 > > > > > > > > configs/imx8mm-icore-mx8mm-ctouch2_defconfig:CONFIG_SPL_FIT= _GENERATOR=3D"arch/arm/mach- > > > > > > > > imx/mkimage_fit_atf.sh" > > > > > > > > > >=20 > > > > > > > > configs/imx8mm-icore-mx8mm-edimm2.2_defconfig:CONFIG_SPL_FI= T_GENERATOR=3D"arch/arm/mach- > > > > > > > > imx/mkimage_fit_atf.sh" > > > > > > > > > >=20 > > > > > > > > configs/imx8mm_beacon_defconfig:CONFIG_SPL_FIT_GENERATOR=3D= "arch/arm/mach-imx/mkimage_fit_atf.sh" > > > > > > > > > >=20 > > > > > > > > configs/imx8mn_beacon_2g_defconfig:CONFIG_SPL_FIT_GENERATOR= =3D"arch/arm/mach- > > > > > > > > imx/mkimage_fit_atf.sh" > > > > > > > > > >=20 > > > > > > > > configs/imx8mn_beacon_defconfig:CONFIG_SPL_FIT_GENERATOR=3D= "arch/arm/mach-imx/mkimage_fit_atf.sh" > > > > > > > > > >=20 > > > > > > > > configs/imx8qm_rom7720_a1_4G_defconfig:CONFIG_SPL_FIT_GENER= ATOR=3D"arch/arm/mach- > > > > > > > > imx/mkimage_fit_atf.sh" > > > > > > > > > >=20 > > > > > > > > > > Tim > > > > > > > > > > [1] https://patchwork.ozlabs.org/project/uboot/list/?se= ries=3D265765 > > > > > > > > > > [2] https://patchwork.ozlabs.org/project/uboot/list/?se= ries=3D268380 > > > > > > > > > > [3] https://patchwork.ozlabs.org/project/uboot/list/?se= ries=3D261640 > > > > > > > > > > [4] https://patchwork.ozlabs.org/project/uboot/list/?se= ries=3D261822 > > > > > > > > > >=20 > > > > > > > > >=20 > > > > > > > > > Tom, > > > > > > > > >=20 > > > > > > > > > I'm not familiar with the U-boot CI tool. > > > > > > > >=20 > > > > > > > > It's at https://u-boot.readthedocs.io/en/latest/develop/ci_= testing.html > > > > > > > > (and in-tree under doc/develop/ci_testing.rst). > > > > > > > >=20 > > > > > > > > > Is it a show-stopper that it > > > > > > > > > does not build for boards using binman for release? From = what you > > > > > > > > > mentioned in another thread it was never building the fla= sh.bin target > > > > > > > > > for the boards using the FIT generator anyway. > > > > > > > >=20 > > > > > > > > Yes, breaking CI is a ship-stopper.=A0 That all of these bo= ards were not > > > > > > > > previously building the final image as part of "all" is a p= roblem. > > > > > > > >=20 > > > > > > > > So, here's what I'm at right now.=A0 I've grabbed Heiko's p= atch. > > > > > > > > Everything is currently visible at > > > > > > > >=20 > > > > > > > > https://patchwork.ozlabs.org/bundle/trini/2022-01-07-imx8-a= nd-binman-updates/ > > > > > > > > and with this, we get some boards building and complaining = as expected: > > > > > > > > =A0=A0 aarch64:=A0 w+=A0=A0 imx8mn_evk > > > > > > > > +(imx8mn_evk) Image 'main-section' is missing external blob= s and is > > > > > > > > non-functional: blob-ext@1 > > > > > > > > blob-ext@2 blob-ext@3 blob-ext@4 > > > > > > > > +(imx8mn_evk) Image 'main-section' is missing external blob= s and is > > > > > > > > non-functional: blob-ext > > > > > > > > +(imx8mn_evk) > > > > > > > > +(imx8mn_evk) Some images are invalid > > > > > > > >=20 > > > > > > > > But others are: > > > > > > > > =A0=A0 aarch64:=A0 +=A0=A0 imx8mn_beacon_2g > > > > > > > > +(imx8mn_beacon_2g) =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D WARNING =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D > > > > > > > > +(imx8mn_beacon_2g) This board uses CONFIG_SPL_FIT_GENERATO= R. Please > > > > > > > > migrate > > > > > > > > +(imx8mn_beacon_2g) to binman instead, to avoid the prolife= ration of > > > > > > > > +(imx8mn_beacon_2g) arch-specific scripts with no tests. > > > > > > > > +(imx8mn_beacon_2g) =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > > > > > > > > +(imx8mn_beacon_2g) Image 'main-section' is missing externa= l blobs and is > > > > > > > > non-functional: blob- > > > > > > > > ext@1 blob-ext@2 blob-ext@3 blob-ext@4 > > > > > > > > +(imx8mn_beacon_2g) binman: Error 1 running 'mkimage -d > > > > > > > > ./mkimage.spl.mkimage -n spl/u-boot-spl > > > > > > > > .cfgout -T imx8mimage -e 0x912000 ./mkimage-out.spl.mkimage= ': > > > > > > > > spl/u-boot-spl-ddr.bin: Can't ope > > > > > > > > n: No such file or directory > > > > > > > > +(imx8mn_beacon_2g) > > > > > > > > +(imx8mn_beacon_2g) make[1]: *** [Makefile:1088: all] Error= 1 > > > > > > > > +(imx8mn_beacon_2g) make: *** [Makefile:177: sub-make] Erro= r 2 > > > > > > > >=20 > > > > > > >=20 > > > > > > > The beacon boards are mine.=A0 I can work on this one today.= =A0 Do I just grab > > > > > > > the binman updates and apply it to master and fix it from tha= t starting > > > > > > > point? > > > > > >=20 > > > > > > So, yes, grabbing the series from the above link and applying i= t on top > > > > > > of master, and making builds work with fake binaries would be v= ery > > > > > > helpful.=A0 As best I can tell there's still something missing = with making > > > > > > fake blobs link and not fail.=A0 For example, imx8mm_venice is = part of the > > > > > > series above but still fails with 'make BINMAN_FAKE_EXT_BLOBS= =3D1 ...': > > > > > > Image 'main-section:u-boot-spl-ddr' has faked external blobs an= d is non-functional: > > > > > > lpddr4_pmu_train_1d_imem.bin lpddr4_pmu_train_1d_dmem.bin lpddr= 4_pmu_train_2d_imem.bin > > > > > > lpddr4_pmu_train_2d_dmem.bin > > > > > > Image 'main-section' is missing external blobs and is non-funct= ional: atf_blob blob-ext > > > > > > Wrote map file './imx-boot.map' to show errors > > > > > > binman: Node '/binman/imx-boot/blob-ext@1': Offset 0x0 (0) over= laps with previous entry '/binman/imx- > > > > > > boot/uboot' ending at 0x1aee08 (1764872) > > > > > >=20 > > > > >=20 > > > > > From what I can tell looking at the imx8mm_venice board is that t= he imx8mm-u-boot.dtsi has the binman > > > > > nodes to build the image, but arch/arm/dts/imx8mm-venice-u-boot.d= tsi duplicates that work, so there are > > > > > two copies trying to occupy the same space.=A0 Deleting the &binm= an node from the venice-u-boot.dtsi file > > > > > appears to make the problem go away, and binman is still making t= he image. > > > > >=20 > > > >=20 > > > > Adam, > > > >=20 > > > > I don't quite follow. I don't see any binman nodes in > > > > arch/arm/dts/imx8mm-u-boot.dtsi. > > > >=20 > > > > I know that Marcel submitted a patch that added them (and I'm not s= ure > > > > if he added them yet in a way that was compatible with multiple fdt= 's) > > > > but this hasn't been merged yet so I don't see any duplicate binman > > > > nodes for venice. > > >=20 > > > Right, so this is with > > > https://patchwork.ozlabs.org/bundle/trini/2022-01-07-imx8-and-binman-= updates/ > > > applied and I did have to manually apply Marcel's 4/7 and 7/7, so may= be > > > I mismerged something there too?=A0 The tree is also at > > > https://github.com/trini/u-boot/tree/WIP/2022-01-07-imx8-and-buildman= -updates > > >=20 > >=20 > > Tom, > >=20 > > Thank you for helping with this. During the merge window we had a lot > > of collisions because of things moving to defconfig that I think > > caused a lot of imx patches to have to be rebased. Then as most of us > > were submitting binman patches this CI issue popped up and as Stefano > > was unavailable I think it all got left hanging. In the middle of that > > Marcel's patch moved binman nodes to a common place so some rebasing > > is needed there as well. Fun times! > >=20 > > Yes, I couldn't get all from your patchwork bundle to apply - I didn't > > try as hard as you to manually merge :) > >=20 > > I pulled your tree and see Marcel's patches there now. With the binman > > node removed from arch/arm/dts/imx8mm-venice-u-boot.dtsi venice works. >=20 > I also quickly double checked everything and indeed somehow the removal o= f the binman stuff from > arch/arm/dts/imx8mm-venice-u-boot.dtsi which I had in my 4th patch "[PATC= H v3 4/7] arm64: dts: imx8mm: use > common binman configuration" got lost. Otherwise it all looks good. Thank= s! I must have messed it up, sorry. I'm doing one more CI run right now of Adam's versions of the patches (just to be extra safe) and then I'll merge the branch. Thanks all! --=20 Tom --+cK5/nwePh61TnYD Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmHYwekACgkQFHw5/5Y0 tyy/Lwv+MRTjrWno3m2Tv0bWKsWYARjcPOvX8RGL2GnTAG3JlglaObs35RqxyOY/ vWLhgOV2ueqRn+q4SIWnaO8MlVUa3dRZvyewfJSxrDl1e3N5Rs7ad8+Xk7jbFq2+ 7OX5U4LVNF3LjDgyiJfqCx8w+/Aqu5xGEWBhZ/d+idP0GP0Dpy8ZYBWXaOvk3qsX 4e5r45ySTQum5uCc5B6aanPfiNWH5HgE3M6clIkTaHRr2pK1Y1b1jzDgPf18TXfi a+qn/T2h4eWpwj58h3FBOjRlBBgL+EvRqKwR5Lsr2CakXmIz8ZJp2AkWshB7wOJg P50vyrHBF8GkvkXaHVZgIBuylu3FLFEXVXKeG/WCc/JscXintEPxF3eRQw2EEaN7 6QG/c6rQliIrVdQnewaG3jUefGgHeMQO8/nnKJ1Mw1r4bIpuOtzK8ub7zSv5mOSz dLpWQKbAtImUJuWGfjvgrfhlLxXQ38f/CKkg+KPH77IYuEBGbTO79DzySVAshwOB yWngGL17 =Z9xq -----END PGP SIGNATURE----- --+cK5/nwePh61TnYD--