Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A8D36C433F5 for ; Tue, 11 Jan 2022 19:09:28 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id B3CC981E3E; Tue, 11 Jan 2022 20:09:25 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="g2Mhmyr0"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 6C00580882; Tue, 11 Jan 2022 20:09:24 +0100 (CET) Received: from mail-qt1-x82c.google.com (mail-qt1-x82c.google.com [IPv6:2607:f8b0:4864:20::82c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 6DB0581D5D for ; Tue, 11 Jan 2022 20:09:21 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x82c.google.com with SMTP id s19so332479qtc.5 for ; Tue, 11 Jan 2022 11:09:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=e8EjNn+EGbMQQjxwuJS2FckNf8Iezu36Dd4NufmZqsc=; b=g2Mhmyr0bnf19eZoXirau9ZKmHM7lJbvwCbc181bBO+EdqBvLCg+ZemNJRSzBLEFAb RquxsOzb8LyLuxjfpTCL29J4cPHo2QOgVjB14XweyaR+7vK0LJlY0fb9UWipv+rWlTny wvaJYN55GOZ2UpljTeY3/XHd0A2dmA9V39feQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=e8EjNn+EGbMQQjxwuJS2FckNf8Iezu36Dd4NufmZqsc=; b=27+FWKqe1tS6dwE25bZrkYC6fBHRqjoQ8Lc3BoAHfk/qGu+2IPrOeIbQuAid+83864 +hcZaRCJoNX8uuxRBO2ffVY6hD0GeuRMi7ttA38d8r5e8hh6BdZ5HOFwwJ2QvMWjmx+h QZ1OD3DhEmJz4yqXl4RL2Jq05AUdxFYOajRhI0EVU9bK1NAnmOrw6v1JnZ7mgghn2fQY g/F1HwVVfj5puWXD5nC+JuCx5c50XSl7uynsaVShpXB/K7BlWjr8AFkReUDF6kzMkRfP bJgJYz6uOMMnua6f33FG8rAQr4kBm19+o9mk3SRnr8IaQpGK/EkdK9ozkCRGxnNPRZ5Z 878w== X-Gm-Message-State: AOAM5337E3du1EfiV+/C0Py01Q362KatB4v9xhtrcHEHmykx5HQslNT8 7MbqPCxvpMiNnK39iDUziLS2fQ== X-Google-Smtp-Source: ABdhPJwwgWRhpLfG9jLn4+2oVOSHp7KRPXBIuzOKVmUXZDT9xKV1npLEl7ZTCWVhh4ekdM8IyshqgQ== X-Received: by 2002:a05:622a:1911:: with SMTP id w17mr4831163qtc.185.1641928160103; Tue, 11 Jan 2022 11:09:20 -0800 (PST) Received: from bill-the-cat (2603-6081-7b01-cbda-456a-4482-4d5b-efcf.res6.spectrum.com. [2603:6081:7b01:cbda:456a:4482:4d5b:efcf]) by smtp.gmail.com with ESMTPSA id l9sm6930910qkj.37.2022.01.11.11.09.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Jan 2022 11:09:19 -0800 (PST) Date: Tue, 11 Jan 2022 14:09:17 -0500 From: Tom Rini To: Marek Vasut Cc: Pali =?iso-8859-1?Q?Roh=E1r?= , u-boot@lists.denx.de, Heinrich Schuchardt , Marek =?iso-8859-1?Q?Beh=FAn?= , Stefan Roese Subject: Re: [PATCH] tools: Do not build kwbimage if CONFIG_TOOLS_LIBCRYPTO=n Message-ID: <20220111190917.GM2773246@bill-the-cat> References: <20220111153120.1276641-1-marex@denx.de> <20220111153634.k5ajrgf2orzdhnar@pali> <20220111161647.GF2773246@bill-the-cat> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="dVgwEdLh8Z9xsR+V" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --dVgwEdLh8Z9xsR+V Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jan 11, 2022 at 07:58:05PM +0100, Marek Vasut wrote: > On 1/11/22 17:16, Tom Rini wrote: > > On Tue, Jan 11, 2022 at 04:36:34PM +0100, Pali Roh=E1r wrote: > > > On Tuesday 11 January 2022 16:31:20 Marek Vasut wrote: > > > > The kwbimage has hard dependency on OpenSSL, do not build it > > > > in case TOOLS_LIBCRYPTO is disabled. > > >=20 > > > This patch does not work as kwbimage is required for 32-bit Armada > > > platforms. So kwbimage.o cannot be disabled on these platforms. > > >=20 > > > There is already proposal for fixing this issue: > > > https://patchwork.ozlabs.org/project/uboot/patch/20211021093304.25399= -1-pali@kernel.org/ > >=20 > > And needs to be respun to not have Kconfig issues. To answer something > > noted in that thread, yes, it would be good if Kconfig did, or had an > > option to make WARNING like that fatal. Or is the problem really that > > no, it's non-optional, really, to have OpenSSL installed? >=20 > OpenSSL should be optional, I got this bug report where someone tried to > build u-boot on ancient debian oldoldstable with openssl 1.1.0 (without > ecdsa support), for a platform which doesn't need any of this crypto stuf= f. > So, disabling TOOLS_LIBCRYPTO was a sufficient for that platform to build= in > that setup (with this patch). And there are plenty of such platforms in t= he > U-Boot tree (all that are not marvell I think). Right. So your patch is a step in the right direction, but we also need to have the appropriate platforms depend'ing on TOOLS_LIBCRYPTO and updating the help to note that some platforms require it as well, to build their images. --=20 Tom --dVgwEdLh8Z9xsR+V Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmHd1doACgkQFHw5/5Y0 tyxtbgv+MZab1ALAKEH8Ou3akFzNxgYw36IEHsoR4XaWYxuk8yPfTLaTnB48P0u2 QubpeyJ3PZJd0DQ0lU/KFW1HqPQjCgqTuLMPkuwtue9IdMPKALQgpEPRePROXrFK CKug1oIA1tpl0a4XSCjfp7oBsuqS0JEakLU1SDEuGyvw8/5lhy2SseJA5SJEvidE zeXc2sHFOBSMmoKUakeK4kXMEK4kSA8KQZqNniS/FuGP+BaBUgaYVdZw6HE207dp wqUhmuYB0tH+/1+WOx1L4jpu31P30nlCYikjvj3Ey/b+Z15PzWUB9p7vguCyPY9h iRxwbh2E2Pi2TB1Tx0VnNXUl7O0yD2tcQ+DlETZKEWcXbQrTI72xAyf8WovGXDlr R1/OcUWS4O4bWpfN8deI0ZMak7unnhv8Xqt/9pNY6+V3i32E3QUq1fGq8XWpCsb9 UeMIfnwMso0O8mChhwl8w+2K75II061NAl/Z+LM49KqdBWSwzPiKyjA9jyxGIiMP Wyv8aIph =wpSc -----END PGP SIGNATURE----- --dVgwEdLh8Z9xsR+V--