Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C4CFBC433EF for ; Wed, 12 Jan 2022 22:00:17 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 83B2B83180; Wed, 12 Jan 2022 23:00:15 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="mkIcYU42"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id BFFD9832E9; Wed, 12 Jan 2022 23:00:13 +0100 (CET) Received: from mail-qv1-xf32.google.com (mail-qv1-xf32.google.com [IPv6:2607:f8b0:4864:20::f32]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id CDFB5832D8 for ; Wed, 12 Jan 2022 23:00:09 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qv1-xf32.google.com with SMTP id p12so4521373qvj.6 for ; Wed, 12 Jan 2022 14:00:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=m7KMT9XkpSA/fyqCAz9qISsVpmAj/XDup6y5hyU7zlQ=; b=mkIcYU42rWax0mitaK9vOUTVz2CME5odBB4Mze+NsLFkFSu5NTcxXn8iG87RG0Drc7 JDiH9J0H5g9h/yu61+rsoH0RcB2D/IEIlEj0m96O+h8jXsH3Ytnpma0Sj+BdrlGeoCJf Lxu5Tc3pVZz8lAGPDcugshtj0oxW7g9vFUjgA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=m7KMT9XkpSA/fyqCAz9qISsVpmAj/XDup6y5hyU7zlQ=; b=jwR+2DXs8LfmcRUyIaeMEgTho9Li2WKttZwJOj94/BolKZU6Bkc6cG2MW03t9Hfdnt YkD61hq251ONrV8WYopZ6xdGJ2tfQX7cZbIMJYZw3VXIlKUjtlR8AJZN8DgRQAPMmwcB C+O8WKss6GlpDEVARSC0K832S3Eqqx1j/JKeyTF2AbycZ0At7pPOiqliBSK0OHXHVXJw dzBN70zAschHkD1jo6F9KWVAbbARllAvyro37v/Nvoxfc0D6IBLBm0xY57TKDzI+NUvx T4uWU/Bmsz0SO3V5zYlEwsGATfMsd6DyEmplJ/Aa2ko98G5cSiNjeuDZYRZd69g8OC23 KYeg== X-Gm-Message-State: AOAM533ru8l/pb9OIwWVob8airZ+u1l1f6gTpELW7z6Hla6cjj+baxoU cWmuWvQbj1n4qH/1LKu6TFnWGA== X-Google-Smtp-Source: ABdhPJzvhvJB/r9BOCp1TjvqDuZJsbQZ+XmopAYOg+1kvqjjItNdQ0CKhqxZzOkA9cNT3KcQOpPNGg== X-Received: by 2002:a05:6214:c28:: with SMTP id a8mr1723135qvd.67.1642024808433; Wed, 12 Jan 2022 14:00:08 -0800 (PST) Received: from bill-the-cat (2603-6081-7b01-cbda-2440-966a-5ce3-c6d0.res6.spectrum.com. [2603:6081:7b01:cbda:2440:966a:5ce3:c6d0]) by smtp.gmail.com with ESMTPSA id t20sm623434qto.94.2022.01.12.14.00.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Jan 2022 14:00:07 -0800 (PST) Date: Wed, 12 Jan 2022 17:00:06 -0500 From: Tom Rini To: Patrick Wildt Cc: Fabio Estevam , Stefano Babic , U-Boot-Denx , "Lukas F. Hartmann" , Heiko Thiery , Vagrant Cascadian Subject: Re: [PATCH v4 2/2] board: mntre: imx8mq: Add MNT Reform 2 board support Message-ID: <20220112220006.GE9207@bill-the-cat> References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="RhUH2Ysw6aD5utA4" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --RhUH2Ysw6aD5utA4 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jan 12, 2022 at 06:47:38PM -0300, Fabio Estevam wrote: > Hi Patrick, >=20 > On Sat, Jan 8, 2022 at 12:05 PM Patrick Wildt wrote: > > > > The MNT Reform 2 is a modular DIY laptop. In its initial version it > > is based on the BoundaryDevices i.MX8MQ SoM. Some parts have been > > lifted from BoundaryDevices official U-Boot downstream project. > > > > Signed-off-by: Patrick Wildt >=20 > Patch looks, only minor comments: >=20 > Reviewed-by: Fabio Estevam >=20 > > --- /dev/null > > +++ b/arch/arm/dts/imx8mq-mnt-reform2-u-boot.dtsi > > @@ -0,0 +1,13 @@ > > +// SPDX-License-Identifier: (GPL-2.0 OR MIT) > > + > > +#include "imx8mq-u-boot.dtsi" > > + > > +&usdhc1 { > > + mmc-hs400-1_8v; > > +}; > > + > > +&usdhc2 { > > + cd-gpios =3D <&gpio2 12 GPIO_ACTIVE_LOW>; > > + sd-uhs-sdr104; > > + sd-uhs-ddr50; >=20 > It is Ok to put them in the u-boot.dtsi for now, but what about adding > it to the mainline dts? >=20 > > +/* ENET1 */ > > +#if defined(CONFIG_CMD_NET) > > +#define CONFIG_ETHPRIME "FEC" > > + > > +#define CONFIG_FEC_XCV_TYPE RGMII > > +#define CONFIG_FEC_MXC_PHYADDR 4 > > +#define FEC_QUIRK_ENET_MAC > > + > > +#define IMX_FEC_BASE 0x30BE0000 >=20 > Not needed with DM. >=20 > > +#define CONFIG_MXC_GPIO >=20 > This should be in Kconfig. To be a little clearer here, CI now tests and fails if you have symbols that are in Kconfig listed in your board.h file. You can get CI run automatically as explained here: https://u-boot.readthedocs.io/en/latest/develop/ci_testing.html --=20 Tom --RhUH2Ysw6aD5utA4 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmHfT2UACgkQFHw5/5Y0 tyzSJgv7BbdOMu3t3e//hQ24Y6KBLH7+Cs21AF3IMdnt9CcdtF5K8tuICBHZUnLf t9ENGQEWF5RRx/MWMSfp4hGy5+/+YOZs16U7Rg8TccupNBpwl7A9VTbTfX3ur+H6 KxNfY2KmL3lT3UxOb1X7bgl7vhkrfGzxLcFP+StpLpwDGNAcysnwatQ6DRETyQUt eBHraHDdXs8YGpWlPzrVE7WteOX+w8VDXBWyfQgwvmR9CZKgVw/xw9yrs+7/Ktl7 DmHdxPKnNKNW9LRdYFDuajIvEKd7qUJVSvo7ejffpKIjJFOQumcGQkm0dIPbzQNb 9URt8Z9QkiKqJhwr1oF/zFqMAn/TWxSmej7YUSIFkES/yqn3+KobYXxbwLAao1WT U1AhFfOg1a6aY7W3y1NqSLAbFCAw1aRJM/MvyLHQWAtwXvlM/fhcu6A6MBwE7LTA yoq7UXc02/3t19CyKBajP1uTHLyqKu0d9WkXuh42RB4fYIbzcL5SuoR0EE1t/z1T klBaT6ee =Vhoe -----END PGP SIGNATURE----- --RhUH2Ysw6aD5utA4--