Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 167E9C433F5 for ; Thu, 13 Jan 2022 02:26:55 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 42B69833A2; Thu, 13 Jan 2022 03:26:54 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="bMDmCJnK"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 9D3B583373; Thu, 13 Jan 2022 03:26:53 +0100 (CET) Received: from mail-io1-xd2a.google.com (mail-io1-xd2a.google.com [IPv6:2607:f8b0:4864:20::d2a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id D74F18326B for ; Thu, 13 Jan 2022 03:26:50 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@chromium.org Received: by mail-io1-xd2a.google.com with SMTP id n137so451484iod.4 for ; Wed, 12 Jan 2022 18:26:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=wvwYTVGG2qu43YiHJ0aX/NfSN4W9tBY8oav59ujZQ/E=; b=bMDmCJnKw2e5gWHtiEjij8zQRpnL9l9VqgtqkiqzsF5of6x23PGIkFYjoGEk1lQ/4X 9yUTSsjR6ZOfb43HgHOQJ/p0sfNpYO7s+7JHNFPSmQ2MHzhCuczx8N43W33q/wqaL9/L u2Cd/XhlvQgVaioZDVZIWyJVZV4Phqk1vEOyk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=wvwYTVGG2qu43YiHJ0aX/NfSN4W9tBY8oav59ujZQ/E=; b=YzvyziTg75ib+NRU4J8Has7mngHXXHb2o9TkaVaF3h0J+M/oFLj+Xq4s38AvrFrDZ1 hW2lNM0aSqI21x1H4oLAaMIQn0q5iotxDrgEWniUGHXd+Ssib/+JpFFiJAdipvzQY0MO TSvzF+84k52EZuxV8h/BGRMmDqoGZqhXKrfUkuxY7opu1TKvaKXt8sHvK0ATSQ2seICt Yx7VutUswwdqIUQBay1eXWEacoSIRjIyO7GdVr7a7CegvnVSh5p+rzTvYxPsDAWMdU3v CqWO9O89BRJfRRh5XlQjrFhRzqBI1ipKpFv/0Kg9UaH/6izDOUPUAALlk1dRBp0QvaYg 6hRw== X-Gm-Message-State: AOAM532QebLNLYFQPBl6rx62k7NmXNAt1dyr09aWlyNrVkCLjPgX7F2t AxqEiYv24kmUmgzQGbOzl1pR95WAO06GJQ== X-Google-Smtp-Source: ABdhPJzDs1srV0uqIBcyStgnxl5sXQO6DYzGXM1pxrLIzFnSE63Mz8oOZg6Am6RQZVjMXsRZ0nWLYQ== X-Received: by 2002:a6b:6f0a:: with SMTP id k10mr1204557ioc.88.1642040809449; Wed, 12 Jan 2022 18:26:49 -0800 (PST) Received: from kiwi.bld.corp.google.com (c-67-190-101-114.hsd1.co.comcast.net. [67.190.101.114]) by smtp.gmail.com with ESMTPSA id e17sm965634ili.37.2022.01.12.18.26.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Jan 2022 18:26:49 -0800 (PST) From: Simon Glass To: U-Boot Mailing List Cc: Tom Rini , Simon Glass Subject: [PATCH v2 01/12] stddef: Avoid warning with clang with offsetof() Date: Wed, 12 Jan 2022 19:26:14 -0700 Message-Id: <20220113022625.413990-2-sjg@chromium.org> X-Mailer: git-send-email 2.34.1.575.g55b058a8bb-goog In-Reply-To: <20220113022625.413990-1-sjg@chromium.org> References: <20220113022625.413990-1-sjg@chromium.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Some bright sparks have decided that a cast on a constant cannot be a constant, so offsetof() produces this warning on clang-10: include/intel_gnvs.h:113:1: error: static_assert expression is not an integral constant expression check_member(acpi_global_nvs, unused2, GNVS_CHROMEOS_ACPI_OFFSET); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/kernel.h:284:2: note: expanded from macro 'check_member' offsetof(struct structure, member) == (offset), \ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/stddef.h:20:32: note: expanded from macro 'offsetof' ^ include/intel_gnvs.h:113:1: note: cast that performs the conversions of a reinterpret_cast is ot allowed in a constant expression include/linux/stddef.h:20:33: note: expanded from macro 'offsetof' Fix it by using the compiler built-in version, if available. Signed-off-by: Simon Glass --- (no changes since v1) include/linux/stddef.h | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/include/linux/stddef.h b/include/linux/stddef.h index c540f6100d4..a7f546fdfe5 100644 --- a/include/linux/stddef.h +++ b/include/linux/stddef.h @@ -1,6 +1,8 @@ #ifndef _LINUX_STDDEF_H #define _LINUX_STDDEF_H +#include + #undef NULL #if defined(__cplusplus) #define NULL 0 @@ -14,7 +16,11 @@ #ifndef __CHECKER__ #undef offsetof -#define offsetof(TYPE, MEMBER) ((size_t) &((TYPE *)0)->MEMBER) +#ifdef __compiler_offsetof +#define offsetof(TYPE, MEMBER) __compiler_offsetof(TYPE, MEMBER) +#else +#define offsetof(TYPE, MEMBER) ((size_t)&((TYPE *)0)->MEMBER) +#endif #endif #endif -- 2.34.1.575.g55b058a8bb-goog