Content-Type: multipart/mixed; boundary="===============5391557452501892898==" MIME-Version: 1.0 From: kernel test robot To: kbuild-all@lists.01.org Subject: Re: [PATCH v2 3/3] sched/core: Force idle accounting per cgroup Date: Thu, 13 Jan 2022 05:27:08 +0800 Message-ID: <202201130529.HUZtnC5G-lkp@intel.com> In-Reply-To: <1641894961-9241-4-git-send-email-CruzZhao@linux.alibaba.com> List-Id: --===============5391557452501892898== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Hi Cruz, Thank you for the patch! Yet something to improve: [auto build test ERROR on tip/sched/core] [also build test ERROR on tip/master linux/master linus/master next-2022011= 2] [cannot apply to tj-cgroup/for-next v5.16] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Cruz-Zhao/Accounting-force= d-idle-time-per-cpu-and-per-cgroup/20220111-175754 base: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git 82762d2= af31a60081162890983a83499c9c7dd74 config: ia64-randconfig-r024-20220112 (https://download.01.org/0day-ci/arch= ive/20220113/202201130529.HUZtnC5G-lkp(a)intel.com/config) compiler: ia64-linux-gcc (GCC) 11.2.0 reproduce (this is a W=3D1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/= make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/363ef949b487441383f2719bd= ff3dc9156779565 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Cruz-Zhao/Accounting-forced-idle-t= ime-per-cpu-and-per-cgroup/20220111-175754 git checkout 363ef949b487441383f2719bdff3dc9156779565 # save the config file to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=3D$HOME/0day COMPILER=3Dgcc-11.2.0 make.cross= O=3Dbuild_dir ARCH=3Dia64 SHELL=3D/bin/bash If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All errors (new ones prefixed by >>): kernel/sched/core_sched.c: In function '__sched_core_account_forceidle': >> kernel/sched/core_sched.c:287:17: error: implicit declaration of functio= n 'cpuacct_account_forceidle'; did you mean 'sched_core_account_forceidle'?= [-Werror=3Dimplicit-function-declaration] 287 | cpuacct_account_forceidle(i, p, delta); | ^~~~~~~~~~~~~~~~~~~~~~~~~ | sched_core_account_forceidle cc1: some warnings being treated as errors vim +287 kernel/sched/core_sched.c 240 = 241 /* REQUIRES: rq->core's clock recently updated. */ 242 void __sched_core_account_forceidle(struct rq *rq) 243 { 244 const struct cpumask *smt_mask =3D cpu_smt_mask(cpu_of(rq)); 245 u64 delta_per_idlecpu, delta, now =3D rq_clock(rq->core); 246 struct rq *rq_i; 247 struct task_struct *p; 248 int i; 249 = 250 lockdep_assert_rq_held(rq); 251 = 252 WARN_ON_ONCE(!rq->core->core_forceidle_count); 253 = 254 if (rq->core->core_forceidle_start =3D=3D 0) 255 return; 256 = 257 delta_per_idlecpu =3D delta =3D now - rq->core->core_forceidle_star= t; 258 if (unlikely((s64)delta <=3D 0)) 259 return; 260 = 261 rq->core->core_forceidle_start =3D now; 262 = 263 if (WARN_ON_ONCE(!rq->core->core_forceidle_occupation)) { 264 /* can't be forced idle without a running task */ 265 } else if (rq->core->core_forceidle_count > 1 || 266 rq->core->core_forceidle_occupation > 1) { 267 /* 268 * For larger SMT configurations, we need to scale the charged 269 * forced idle amount since there can be more than one forced 270 * idle sibling and more than one running cookied task. 271 */ 272 delta *=3D rq->core->core_forceidle_count; 273 delta =3D div_u64(delta, rq->core->core_forceidle_occupation); 274 } 275 = 276 for_each_cpu(i, smt_mask) { 277 rq_i =3D cpu_rq(i); 278 p =3D rq_i->core_pick ?: rq_i->curr; 279 = 280 if (rq_i->in_forcedidle) 281 rq->rq_forceidle_time +=3D delta_per_idlecpu; 282 = 283 if (p =3D=3D rq_i->idle) 284 continue; 285 = 286 __schedstat_add(p->stats.core_forceidle_sum, delta); > 287 cpuacct_account_forceidle(i, p, delta); 288 } 289 } 290 = --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org --===============5391557452501892898==--