Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0AF69C433F5 for ; Sat, 15 Jan 2022 12:38:47 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 0F6B28359C; Sat, 15 Jan 2022 13:38:21 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="qPOZM17q"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 2208C83458; Sat, 15 Jan 2022 13:38:17 +0100 (CET) Received: from mail-qk1-x731.google.com (mail-qk1-x731.google.com [IPv6:2607:f8b0:4864:20::731]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 875E083559 for ; Sat, 15 Jan 2022 13:38:13 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qk1-x731.google.com with SMTP id s12so9285853qkg.6 for ; Sat, 15 Jan 2022 04:38:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=jW2Z1+5vFZmYBGl5yrcPq/RCqEXgNsD5jB5kxXMD+Cs=; b=qPOZM17qyIzb3DmulmYd8/iRchitVQMp5m4SLMMOOOSOgsddDQr/qJ3vLSJy1UrEan MYfLr6pf4RCMUY0iO5hXm99SKAKM3Nhoi8duSAbVhgKDaPF5y+V8nNvm7PWZP3or5Sf0 PTOnWt6u9fiE9qZcyU7yai8x2jzYw0Ijmu6oA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=jW2Z1+5vFZmYBGl5yrcPq/RCqEXgNsD5jB5kxXMD+Cs=; b=G5CwCWcIc/OEOtgnyCzUC4+5+x8OXzpnhYrcdJGSr/NdjtZyMdVeUxHJWFIAmlvGgt Opr+LOBBWZep9w0wpqlVo6etE94nACqwHPsjwhz2YR434yxWPYnoNO7+6IPxKmofD1QE rHK2U1Eq7KoxOXwWxFRzIsN5jivEe0cHvvXu2X72myO/0WO27KXXGVy7Qn5FnHL0OAe6 WazGOKzBJRF4/zCUthCt/Viw3veWy0+blf62PuYAaei6h0FHFFEFl7b3MhRlBV6+uBeN GXXjIt31EjORSp4NoxkLBZQKiYlDKW2/D/S8vBG1E2KnNQ+2iYftuohCZMfNqmI1JM4x A03w== X-Gm-Message-State: AOAM532G6hW6cHfVx2HKiW8auFx7xD7CajBjoXP0e7gpb/Lh+fclgsjm 0QlVZrTJ8Rp+QHSSo+3sN3mgk+/YD+onOw== X-Google-Smtp-Source: ABdhPJxd0IzTd0O/JsLcLvMy5a2shtdEAfG63bUchJgAxTyV5K+FOmSKi5qT7E5SeaMU3Xb+GfsFGQ== X-Received: by 2002:a05:620a:284d:: with SMTP id h13mr9301398qkp.330.1642250292419; Sat, 15 Jan 2022 04:38:12 -0800 (PST) Received: from bill-the-cat (2603-6081-7b01-cbda-9533-0c51-a891-732b.res6.spectrum.com. [2603:6081:7b01:cbda:9533:c51:a891:732b]) by smtp.gmail.com with ESMTPSA id w85sm2251961qkb.3.2022.01.15.04.38.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 15 Jan 2022 04:38:11 -0800 (PST) Date: Sat, 15 Jan 2022 07:38:10 -0500 From: Tom Rini To: Samuel Dionne-Riel Cc: u-boot@lists.denx.de Subject: Re: [PATCH] cmd: adc: Report return value on error Message-ID: <20220115123810.GB9207@bill-the-cat> References: <20211220182345.52e0d6f9.samuel@dionne-riel.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="K93k+8rZqH7I0m/s" Content-Disposition: inline In-Reply-To: <20211220182345.52e0d6f9.samuel@dionne-riel.com> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --K93k+8rZqH7I0m/s Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Dec 20, 2021 at 06:23:45PM -0500, Samuel Dionne-Riel wrote: > Reporting the return value should always be done on error conditions, > this way the developer can start debugging issues with more knowledge > in-hand. >=20 > Signed-off-by: Samuel Dionne-Riel Applied to u-boot/master, thanks! --=20 Tom --K93k+8rZqH7I0m/s Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmHiwDIACgkQFHw5/5Y0 tyxIWgv+PJajouG+gy2ihpvDs5vnemqjZ6G+65pAVmqrDOqN9UGuGnNClZnIP9aj nn3s1sssq7CDR7Lv+eoTyqRbfWui9oAPlABVWrrj/9ocdG6HWtCI2vKK8DepMAD9 3AHpITDjqbXMXGzOkFjP0p7LNjw8H3XwpxHEFohenzEYelO41hYsft7GmvfvPwH/ xWTyU+OfInm0/Zv5kIw5kiK6A7tRvbRteujUVcI10TzrKv9ywrXBTPYMmQHdIUvy rW/ITIB464kLQkT1/nPBkaAiJV2fKIt/mvQHY4e70STaDeBPpLPBXGD9J6lReueA ZopBeH7Tmdmn7Rnit2aYbBzM0Z6dBBpHF6XZFr/OQVz7MNQAyN7YH7yQjOyihlmL ZUFQvErfWsnVOO6Z+yNH7GPkEhuzD/FHkbU0t1sHws5JaqFqCdJTJCfXdhQG9w/G HuCfrB1Tm2HpySZqbPITOTHHFUqGtyGrZxO7rsz71Dq/QUlqx2z+hnZyvA9+MxM0 s4B8QTCT =GcXk -----END PGP SIGNATURE----- --K93k+8rZqH7I0m/s--