Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67AF1C433EF for ; Thu, 20 Jan 2022 02:09:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 01AB96B00C5; Wed, 19 Jan 2022 21:09:56 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EE56E6B00C6; Wed, 19 Jan 2022 21:09:55 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DACF26B00C7; Wed, 19 Jan 2022 21:09:55 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0095.hostedemail.com [216.40.44.95]) by kanga.kvack.org (Postfix) with ESMTP id C53636B00C5 for ; Wed, 19 Jan 2022 21:09:55 -0500 (EST) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 8AF10813C1C4 for ; Thu, 20 Jan 2022 02:09:55 +0000 (UTC) X-FDA: 79049034750.06.7000B7E Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf31.hostedemail.com (Postfix) with ESMTP id 11D102000F for ; Thu, 20 Jan 2022 02:09:54 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 8C4E461522; Thu, 20 Jan 2022 02:09:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AE9EAC004E1; Thu, 20 Jan 2022 02:09:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1642644594; bh=V89IGnwPibMNEAd7a4UZ75xVtd1PT+OQiTs+DG/Gpvs=; h=Date:From:To:Subject:In-Reply-To:From; b=wfbxxGOVD+uJLrOSO3Ur/0jk5u8dFlYQYV+N8mAAQbKFRvHqK/wl1I1/j6P/g+zrO 2o3RwF3kDjkSgTdavpIJPtEbc8U+mV+BT/ftPkzyklFJSVgWoL6lyzbO6xfCY28H2w 8Rp7TPbsB0Rji7J1+wemPGx9Js7s4LKDYoSYgSyM= Date: Wed, 19 Jan 2022 18:09:53 -0800 From: Andrew Morton To: akpm@linux-foundation.org, chi.minghao@zte.com.cn, christian.brauner@ubuntu.com, gregkh@linuxfoundation.org, jack@suse.cz, linux-mm@kvack.org, mm-commits@vger.kernel.org, torvalds@linux-foundation.org, zealci@zte.com.cm Subject: [patch 41/55] fs/adfs: remove unneeded variable make code cleaner Message-ID: <20220120020953.ikMtjV7Qq%akpm@linux-foundation.org> In-Reply-To: <20220119180714.9e187ce100e4510de3cd9f7d@linux-foundation.org> User-Agent: s-nail v14.8.16 X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 11D102000F X-Stat-Signature: pnxdn8snor5qgqf7pb9qwuc3g7ooii8o Authentication-Results: imf31.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=wfbxxGOV; dmarc=none; spf=pass (imf31.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org X-HE-Tag: 1642644594-464623 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Minghao Chi Subject: fs/adfs: remove unneeded variable make code cleaner Return value directly instead of taking this in a variable. Link: https://lkml.kernel.org/r/20211210023211.424609-1-chi.minghao@zte.com.cn Signed-off-by: Minghao Chi Reported-by: Zeal Robot Cc: Christian Brauner Cc: Jan Kara Cc: Greg Kroah-Hartman Signed-off-by: Andrew Morton --- fs/adfs/inode.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) --- a/fs/adfs/inode.c~fs-adfs-remove-unneeded-variable-make-code-cleaner +++ a/fs/adfs/inode.c @@ -355,7 +355,6 @@ int adfs_write_inode(struct inode *inode { struct super_block *sb = inode->i_sb; struct object_info obj; - int ret; obj.indaddr = ADFS_I(inode)->indaddr; obj.name_len = 0; @@ -365,6 +364,5 @@ int adfs_write_inode(struct inode *inode obj.attr = ADFS_I(inode)->attr; obj.size = inode->i_size; - ret = adfs_dir_update(sb, &obj, wbc->sync_mode == WB_SYNC_ALL); - return ret; + return adfs_dir_update(sb, &obj, wbc->sync_mode == WB_SYNC_ALL); } _