Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2FCEC433EF for ; Thu, 20 Jan 2022 02:10:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 830C46B00C9; Wed, 19 Jan 2022 21:10:02 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7E0296B00CA; Wed, 19 Jan 2022 21:10:02 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6F6656B00CB; Wed, 19 Jan 2022 21:10:02 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0008.hostedemail.com [216.40.44.8]) by kanga.kvack.org (Postfix) with ESMTP id 618E76B00C9 for ; Wed, 19 Jan 2022 21:10:02 -0500 (EST) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 297D1181CBDCE for ; Thu, 20 Jan 2022 02:10:02 +0000 (UTC) X-FDA: 79049035044.28.BB86671 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf23.hostedemail.com (Postfix) with ESMTP id BB10B140003 for ; Thu, 20 Jan 2022 02:10:01 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1B049615E0; Thu, 20 Jan 2022 02:10:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3A80CC004E1; Thu, 20 Jan 2022 02:10:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1642644600; bh=k3l4WPprdN521D4cSqXMtBQBQ8+c2HPKPIPs2RPFBm8=; h=Date:From:To:Subject:In-Reply-To:From; b=yJcKETMQL4AjiTwDgEkZjVha9OI3R+IYGYuDhxOD3LnT738uuUwP7Xgdv4b3YMi8N mAF7Cov0/Bpw3WxG8dtg6Zj5kbvRoC+Jco3eKaBYxj+LOSXSlIDn9U8fjdsKeZD9cI lAmhvCWMQwszVvPGYd66NMlWoSizqmNlhIU96AFE= Date: Wed, 19 Jan 2022 18:09:59 -0800 From: Andrew Morton To: akpm@linux-foundation.org, arjan@linux.intel.com, bigeasy@linutronix.de, linux-mm@kvack.org, mingo@kernel.org, mm-commits@vger.kernel.org, peterz@infradead.org, tglx@linutronix.de, torvalds@linux-foundation.org Subject: [patch 43/55] panic: remove oops_id Message-ID: <20220120020959.FI9fF_AQ5%akpm@linux-foundation.org> In-Reply-To: <20220119180714.9e187ce100e4510de3cd9f7d@linux-foundation.org> User-Agent: s-nail v14.8.16 X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: BB10B140003 X-Stat-Signature: pqksa8oob9tacfikttk18fy5rtqcmp9e Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=yJcKETMQ; dmarc=none; spf=pass (imf23.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org X-HE-Tag: 1642644601-136980 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Sebastian Andrzej Siewior Subject: panic: remove oops_id The oops id has been added as part of the end of trace marker for the kerneloops.org project. The id is used to automatically identify duplicate submissions of the same report. Identical looking reports with different a id can be considered as the same oops occurred again. The early initialisation of the oops_id can create a warning if the random core is not yet fully initialized. On PREEMPT_RT it is problematic if the id is initialized on demand from non preemptible context. The kernel oops project is not available since 2017. Remove the oops_id and use 0 in the output in case parser rely on it. Link: https://bugs.debian.org/953172 Link: https://lkml.kernel.org/r/Ybdi16aP2NEugWHq@linutronix.de Signed-off-by: Sebastian Andrzej Siewior Cc: Arjan van de Ven Cc: Thomas Gleixner Cc: Ingo Molnar Cc: Peter Zijlstra Signed-off-by: Andrew Morton --- kernel/panic.c | 19 +------------------ 1 file changed, 1 insertion(+), 18 deletions(-) --- a/kernel/panic.c~panic-remove-oops_id +++ a/kernel/panic.c @@ -534,26 +534,9 @@ void oops_enter(void) trigger_all_cpu_backtrace(); } -/* - * 64-bit random ID for oopses: - */ -static u64 oops_id; - -static int init_oops_id(void) -{ - if (!oops_id) - get_random_bytes(&oops_id, sizeof(oops_id)); - else - oops_id++; - - return 0; -} -late_initcall(init_oops_id); - static void print_oops_end_marker(void) { - init_oops_id(); - pr_warn("---[ end trace %016llx ]---\n", (unsigned long long)oops_id); + pr_warn("---[ end trace %016llx ]---\n", 0ULL); } /* _