Date: Thu, 20 Jan 2022 14:57:16 +0100 (CET) Message-Id: <202201201357.20KDvGAf079283@...2054...> From: Gert Doering In-Reply-To: <20211214165928.30676-3-selva.nair@...277...> References: <20211214165928.30676-3-selva.nair@...277...> Subject: [Openvpn-devel] [PATCH applied] Re: Implement KEYMGMT in the xkey provider List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: Selva Nair Cc: openvpn-devel@lists.sourceforge.net Only compile-tested on Linux / OpenSSL 3.0.1 (and briefly glanced over the code to see what happens). It breaks... xkey_provider.c:223:16: error: 'XKEY_KEYDATA' has no member named 'free' 223 | key->free = (XKEY_PRIVKEY_FREE_fn *) EVP_PKEY_free; | ^~ xkey_provider.c:223:26: error: 'XKEY_PRIVKEY_FREE_fn' undeclared (first use in this function) 223 | key->free = (XKEY_PRIVKEY_FREE_fn *) EVP_PKEY_free; | ^~~~~~~~~~~~~~~~~~~~ *but* this is fixed in 03/18 - and as the whole patchset is basically a no-op before all is in (it will break compilation with 3.0.1, so might annoy someone doing bisect in the future, hitting just that commit by chance...) I'll still merge & push. Your patch has been applied to the master branch. commit 44509116da50b53a5588318fb27b2e4a3da4ab6c Author: Selva Nair Date: Tue Dec 14 11:59:12 2021 -0500 Implement KEYMGMT in the xkey provider Signed-off-by: Selva Nair Acked-by: Arne Schwabe Message-Id: <20211214165928.30676-3-selva.nair@...277...> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg23438.html Signed-off-by: Gert Doering -- kind regards, Gert Doering