Content-Type: multipart/mixed; boundary="===============2312801698486072882==" MIME-Version: 1.0 From: kernel test robot To: kbuild-all@lists.01.org Subject: Re: [PATCH 2/2] i2c: designware: Add AMD PSP I2C bus support Date: Thu, 20 Jan 2022 23:33:05 +0800 Message-ID: <202201202353.tVXCQlqh-lkp@intel.com> In-Reply-To: <20220120001621.705352-3-jsd@semihalf.com> List-Id: --===============2312801698486072882== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Hi Jan, I love your patch! Yet something to improve: [auto build test ERROR on wsa/i2c/for-next] [also build test ERROR on linux/master rafael-pm/linux-next linus/master v5= .16 next-20220120] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Jan-Dabros/i2c-designware-= Add-support-for-AMD-PSP-semaphore/20220120-081854 base: https://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git i2c/f= or-next config: i386-allyesconfig (https://download.01.org/0day-ci/archive/20220120= /202201202353.tVXCQlqh-lkp(a)intel.com/config) compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 reproduce (this is a W=3D1 build): # https://github.com/0day-ci/linux/commit/f21a75f68baddffd9c50ffdc9= 5d419ad7dbe3f68 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Jan-Dabros/i2c-designware-Add-supp= ort-for-AMD-PSP-semaphore/20220120-081854 git checkout f21a75f68baddffd9c50ffdc95d419ad7dbe3f68 # save the config file to linux build tree mkdir build_dir make W=3D1 O=3Dbuild_dir ARCH=3Di386 SHELL=3D/bin/bash If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All errors (new ones prefixed by >>): drivers/i2c/busses/i2c-designware-amdpsp.c: In function 'psp_send_cmd': >> drivers/i2c/busses/i2c-designware-amdpsp.c:130:2: error: implicit declar= ation of function 'writeq'; did you mean 'writel'? [-Werror=3Dimplicit-func= tion-declaration] 130 | writeq((uintptr_t)__psp_pa((void *)req), &mbox->i2c_req_addr); | ^~~~~~ | writel cc1: some warnings being treated as errors vim +130 drivers/i2c/busses/i2c-designware-amdpsp.c 117 = 118 static int psp_send_cmd(struct psp_i2c_req *req) 119 { 120 struct psp_mbox *mbox =3D (struct psp_mbox *)mbox_iomem; 121 union psp_mbox_cmd_reg cmd_reg =3D {0}; 122 = 123 if (psp_check_mbox_recovery(mbox)) 124 return -EIO; 125 = 126 if (psp_wait_cmd(mbox)) 127 return -EBUSY; 128 = 129 /* Fill address of command-response buffer */ > 130 writeq((uintptr_t)__psp_pa((void *)req), &mbox->i2c_req_addr); 131 = 132 /* Write command register to trigger processing */ 133 cmd_reg.fields.mbox_cmd =3D PSP_I2C_REQ_BUS_CMD; 134 writel(cmd_reg.val, &mbox->fields.val); 135 = 136 if (psp_wait_cmd(mbox)) 137 return -ETIMEDOUT; 138 = 139 if (psp_check_mbox_sts(mbox)) 140 return -EIO; 141 = 142 return 0; 143 } 144 = --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org --===============2312801698486072882==--