Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7AEA5C433EF for ; Fri, 21 Jan 2022 01:59:39 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id D4D328390B; Fri, 21 Jan 2022 02:59:37 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id 2529C8390B; Fri, 21 Jan 2022 02:59:37 +0100 (CET) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by phobos.denx.de (Postfix) with ESMTP id 1123383909 for ; Fri, 21 Jan 2022 02:59:34 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=andre.przywara@arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6F161ED1; Thu, 20 Jan 2022 17:59:33 -0800 (PST) Received: from slackpad.fritz.box (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id ABA2C3F774; Thu, 20 Jan 2022 17:59:30 -0800 (PST) Date: Fri, 21 Jan 2022 01:58:50 +0000 From: Andre Przywara To: Jesse Taube Cc: u-boot@lists.denx.de, jagan@amarulasolutions.com, hdegoede@redhat.com, sjg@chromium.org, icenowy@aosc.io, marek.behun@nic.cz, festevam@denx.de, narmstrong@baylibre.com, tharvey@gateworks.com, christianshewitt@gmail.com, pbrobinson@gmail.com, lokeshvutla@ti.com, jernej.skrabec@gmail.com, hs@denx.de, samuel@sholland.org, arnaud.ferraris@gmail.com, giulio.benetti@benettiengineering.com, thirtythreeforty@gmail.com Subject: Re: [PATCH 07/11] sunxi: board: Add support for SUNIV Message-ID: <20220121012825.5de3ad84@slackpad.fritz.box> In-Reply-To: <20220105003508.1143140-8-Mr.Bossman075@gmail.com> References: <20220105003508.1143140-1-Mr.Bossman075@gmail.com> <20220105003508.1143140-8-Mr.Bossman075@gmail.com> Organization: Arm Ltd. X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.31; x86_64-slackware-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Tue, 4 Jan 2022 19:35:04 -0500 Jesse Taube wrote: Hi, > From: Icenowy Zheng > > Generic Timer Extension is not available on SUNIV. Well, that, plus there are no ID registers with which we could query this. But that has the same effect, so: > Signed-off-by: Icenowy Zheng > Signed-off-by: Jesse Taube Reviewed-by: Andre Przywara Cheers, Andre > --- > board/sunxi/board.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/board/sunxi/board.c b/board/sunxi/board.c > index 2790a0f9e8..59eb195c26 100644 > --- a/board/sunxi/board.c > +++ b/board/sunxi/board.c > @@ -197,7 +197,7 @@ int board_init(void) > > gd->bd->bi_boot_params = (PHYS_SDRAM_0 + 0x100); > > -#ifndef CONFIG_ARM64 > +#if !defined(CONFIG_ARM64) && !defined(CONFIG_MACH_SUNIV) > asm volatile("mrc p15, 0, %0, c0, c1, 1" : "=r"(id_pfr1)); > debug("id_pfr1: 0x%08x\n", id_pfr1); > /* Generic Timer Extension available? */ > @@ -224,7 +224,7 @@ int board_init(void) > #endif > } > } > -#endif /* !CONFIG_ARM64 */ > +#endif /* !CONFIG_ARM64 && !CONFIG_MACH_SUNIV */ > > ret = axp_gpio_init(); > if (ret)