Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A8764C433F5 for ; Fri, 21 Jan 2022 21:18:34 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 96A04830B9; Fri, 21 Jan 2022 22:18:32 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="tiqeNFgB"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id E01C6835A8; Fri, 21 Jan 2022 22:18:29 +0100 (CET) Received: from mail-qv1-xf32.google.com (mail-qv1-xf32.google.com [IPv6:2607:f8b0:4864:20::f32]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 3678481E02 for ; Fri, 21 Jan 2022 22:18:27 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qv1-xf32.google.com with SMTP id g11so5842266qvu.3 for ; Fri, 21 Jan 2022 13:18:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=R2gkTQmVj5GjZ0j/CgyZhtkusE8RsswJYu2apPzD9SQ=; b=tiqeNFgBa9FF/yc4IFZhciw6u9TeA2RbQr6OSuLlmghn4ZOs0GY2Ra1CMOx26MjTwU 0IjzUhHr8tSE5vfDixuE9J4eqV3ip3u8RWN2Wo6Bi8GrC8LDYgMZqhgS+Pc0OoRBnuaX G54DZgpVY1coT6w5Z+CAsLCgALtfa5waVhoQw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=R2gkTQmVj5GjZ0j/CgyZhtkusE8RsswJYu2apPzD9SQ=; b=VhSZTIFj5DPejFHYD19n2VOynrVKONZqO2MptfwAc2HLwmAcG1JgehG21WkQLpgdzX VXibaxAD5sHoclfOYwYPlZaRPVjx/ZbpI7ohKx0LYGyP7SPjIRt/zaBfNJWdMOKeaRGO Hi4X1JqviqXGjBqZcKgH0ScbDfN9mtWNyBb0J6SzCM+g3F6Hqma8+saBA/UePeJdLZqF QjF8B+giX1wUpH2pm0HDHsy3iVSwn/Yx8Cd+WJm6HuH7YX0yGvnnOr/dbtLaY2E3kuIO BGsCgG2W57brjlpcQRbq6mg1GV8DSxA819qUnm+KcIQUi21iD3in4b5TGJiAOWVnHsL/ 8NVA== X-Gm-Message-State: AOAM5315xNCw4dR12ZP8P5hHVizOyHPBahjclj11agavZeilqJrSQA8Y UR2XIBOnRigSmtZQv1VemtvqeA== X-Google-Smtp-Source: ABdhPJxK3/CwIsXJrsSdzWqqD+knk53zmwkwOfovNAhbLr2KWOYUJwMtYLOaCRjCMGGyr5cgu6kQhw== X-Received: by 2002:a05:6214:d6b:: with SMTP id 11mr5552383qvs.69.1642799906023; Fri, 21 Jan 2022 13:18:26 -0800 (PST) Received: from bill-the-cat (2603-6081-7b01-cbda-2ef0-5dff-fedb-a8ba.res6.spectrum.com. [2603:6081:7b01:cbda:2ef0:5dff:fedb:a8ba]) by smtp.gmail.com with ESMTPSA id f9sm2211903qkp.94.2022.01.21.13.18.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Jan 2022 13:18:25 -0800 (PST) Date: Fri, 21 Jan 2022 16:18:23 -0500 From: Tom Rini To: Adam Ford Cc: u-boot@lists.denx.de, marex@denx.de, aford@beaconembedded.com Subject: Re: [PATCH V2] phy: nop-phy: Enable reset-gpios support Message-ID: <20220121211823.GA2797255@bill-the-cat> References: <20220117234559.108600-1-aford173@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="d6Gm4EdcadzBjdND" Content-Disposition: inline In-Reply-To: <20220117234559.108600-1-aford173@gmail.com> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean --d6Gm4EdcadzBjdND Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jan 17, 2022 at 05:45:59PM -0600, Adam Ford wrote: > Some usb-nop-xceiv devices use a gpio to put them in and > out of reset. Add a reset function to put them into that > state. This is similar to how Linux handles the > usb-nop-xceiv driver. >=20 > Signed-off-by: Adam Ford > --- > V2: Only use the GPIO functions when DM_GPIO is enabled > Add error handling so if the GPIO fails, it will shutdown > the clocks and return with the error code. > Call nop_phy_reset() instead of repeating the same code. drivers/phy/nop-phy.c:47:23: error: implicit declaration of function 'nop_phy_reset'; did you mean 'nop_phy_init'? [-Werror=3Dimplicit-function-declaration] is what I get now on those platforms. --=20 Tom --d6Gm4EdcadzBjdND Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmHrIxwACgkQFHw5/5Y0 tywSmwv9H7Sp/veX2/KCR8FkyBiEy+w/GrGvCLc9Ca9zLAAOvmFEs/89bQz6dulL chba4KO3RhoQRfRtTidQg7DtwkLNchnmsi5EQKbxHDF51QZVf8lYFrPkFtq3jxHJ Gd5Us58wTrPfIXzQlVEV6DRvaCo9N6sgf6GXhY5TrdhQn0+8z7UTilIuYbwdvchp PGter0FpBzIFE6YBCWM+405mqXybWtcub9+vNkNkBGl8qQcrrvjGDwf+LIeevEgy XF/4IRNZP1smlpzXHLdcBPQJdAI+GgR70y9WmcKEOHKc/dfDXOjEMWacR7KkE0Pe EwR9ojH7wXAaY/I3AOlL3WUH3NsuGKPRadvtwtHSS7FmzwSUiqMJaE6iBQJC1aHL Gr41s9gZsdFPWlYT7xYUNBgJkNO3vpS65BJ2xsEu+M7DCcxbVxMRpfyeAiWsRPYu 6HNPgjoB6B5q9+Q0AHoMrVNJtM6iYwpEDd34xKxACLkBlwvBqN8J7v+EAdcpGO4B TC55b2Qf =S4LN -----END PGP SIGNATURE----- --d6Gm4EdcadzBjdND--