Content-Type: multipart/mixed; boundary="===============8691174743557665936==" MIME-Version: 1.0 From: kernel test robot To: kbuild-all@lists.01.org Subject: Re: [Patch V3] memory: tegra: Add MC error logging on tegra186 onward Date: Sat, 22 Jan 2022 02:40:19 +0800 Message-ID: <202201220256.pOvahFTK-lkp@intel.com> In-Reply-To: <1642763962-32129-1-git-send-email-amhetre@nvidia.com> List-Id: --===============8691174743557665936== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Hi Ashish, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on tegra/for-next] [also build test WARNING on next-20220121] [cannot apply to v5.16] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Ashish-Mhetre/memory-tegra= -Add-MC-error-logging-on-tegra186-onward/20220121-192115 base: https://git.kernel.org/pub/scm/linux/kernel/git/tegra/linux.git for= -next config: arc-randconfig-r043-20220121 (https://download.01.org/0day-ci/archi= ve/20220122/202201220256.pOvahFTK-lkp(a)intel.com/config) compiler: arceb-elf-gcc (GCC) 11.2.0 reproduce (this is a W=3D1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/= make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/c76ed3ccfbb800c6a32b27d87= b2d5464ebdf1918 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Ashish-Mhetre/memory-tegra-Add-MC-= error-logging-on-tegra186-onward/20220121-192115 git checkout c76ed3ccfbb800c6a32b27d87b2d5464ebdf1918 # save the config file to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=3D$HOME/0day COMPILER=3Dgcc-11.2.0 make.cross= O=3Dbuild_dir ARCH=3Darc SHELL=3D/bin/bash If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All warnings (new ones prefixed by >>): drivers/memory/tegra/mc.c: In function 'tegra30_mc_handle_irq': >> drivers/memory/tegra/mc.c:530:21: warning: variable 'addr_hi_reg' set bu= t not used [-Wunused-but-set-variable] 530 | u32 addr_hi_reg =3D 0, status_reg, addr_reg; | ^~~~~~~~~~~ vim +/addr_hi_reg +530 drivers/memory/tegra/mc.c 516 = 517 irqreturn_t tegra30_mc_handle_irq(int irq, void *data) 518 { 519 struct tegra_mc *mc =3D data; 520 unsigned long status; 521 unsigned int bit; 522 = 523 /* mask all interrupts to avoid flooding */ 524 status =3D mc_readl(mc, MC_INTSTATUS) & mc->soc->intmask; 525 if (!status) 526 return IRQ_NONE; 527 = 528 for_each_set_bit(bit, &status, 32) { 529 const char *error =3D tegra_mc_status_names[bit] ?: "unknown"; > 530 u32 addr_hi_reg =3D 0, status_reg, addr_reg; 531 const char *client =3D "unknown", *desc; 532 const char *direction, *secure; 533 phys_addr_t addr =3D 0; 534 unsigned int i; 535 char perm[7]; 536 u8 id, type; 537 u32 value; 538 = 539 switch (bit) { 540 case MC_INT_DECERR_VPR: 541 status_reg =3D MC_ERR_VPR_STATUS; 542 addr_reg =3D MC_ERR_VPR_ADR; 543 break; 544 case MC_INT_SECERR_SEC: 545 status_reg =3D MC_ERR_SEC_STATUS; 546 addr_reg =3D MC_ERR_SEC_ADR; 547 break; 548 case MC_INT_DECERR_MTS: 549 status_reg =3D MC_ERR_MTS_STATUS; 550 addr_reg =3D MC_ERR_MTS_ADR; 551 break; 552 case MC_INT_DECERR_GENERALIZED_CARVEOUT: 553 status_reg =3D MC_ERR_GENERALIZED_CARVEOUT_STATUS; 554 addr_reg =3D MC_ERR_GENERALIZED_CARVEOUT_ADR; 555 break; 556 case MC_INT_DECERR_ROUTE_SANITY: 557 status_reg =3D MC_ERR_ROUTE_SANITY_STATUS; 558 addr_reg =3D MC_ERR_ROUTE_SANITY_ADR; 559 break; 560 default: 561 status_reg =3D MC_ERR_STATUS; 562 addr_reg =3D MC_ERR_ADR; 563 if (mc->soc->has_addr_hi_reg) 564 addr_hi_reg =3D MC_ERR_ADR_HI; 565 break; 566 } 567 = 568 value =3D mc_readl(mc, status_reg); 569 = --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org --===============8691174743557665936==--