Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A09CEC433F5 for ; Sun, 23 Jan 2022 16:02:01 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 782DA81F7E; Sun, 23 Jan 2022 17:01:59 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="tJnnJpvR"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 4036D811DF; Sun, 23 Jan 2022 17:01:57 +0100 (CET) Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id CF68282135 for ; Sun, 23 Jan 2022 17:01:54 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=pali@kernel.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0DF7360F66; Sun, 23 Jan 2022 16:01:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 56100C340E4; Sun, 23 Jan 2022 16:01:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1642953712; bh=TmMEPyRHXFs9FEl3Dp4l2EOOExmXVFwxgxFEVHwedHc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=tJnnJpvRPcFwkEIJVzRtrPbkm5hVeA43Yf8/ITZ34Hy4zbkM07rTemFF39TdNloT5 zfCSnnM59RJBczTPXJLkwrwq4/zRm9I5vI2bsHZGjj+yp9/FFkMgj3D4qPDgdlAFLu j2ZLckY7BaPqwrCamg0it0R1vyaGa1PUys/0dRg/g17GjxyaNxa/O9sRg2gXZLjNZB oLrR+7yKP69nCOMpoi4ezCKP2bti0uUj1oJXexwaZWEHa5zTPFF8XKGSvJheUlYJxt F9q85iEoiLDyFi/NOqT+0uS0ErsbqPf/lkQIiTbGFoymEtIN9NwHCu4dV43WDq2Mcg vxsdEQjF7EPjA== Received: by pali.im (Postfix) id CFB5E777; Sun, 23 Jan 2022 17:01:49 +0100 (CET) Date: Sun, 23 Jan 2022 17:01:49 +0100 From: Pali =?utf-8?B?Um9ow6Fy?= To: Simon Glass Cc: Merlijn Wajer , maemo-leste@lists.dyne.org, Ivaylo Dimitrov , U-Boot Mailing List , Anatolij Gustschin , Jagan Teki , Andre Przywara Subject: Re: [PATCH 02/14] video: nokia_rx51: Drop obsolete video code Message-ID: <20220123160149.idfi3bylfk2mogx5@pali> References: <20220123140415.3091482-1-sjg@chromium.org> <20220123140415.3091482-3-sjg@chromium.org> <20220123140820.lhzmqnwrnupwtd5s@pali> <20220123145745.72bmbb2stvg5d7kg@pali> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: NeoMutt/20180716 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean Hello! On Sunday 23 January 2022 08:54:24 Simon Glass wrote: > Hi Pali, > > On Sun, 23 Jan 2022 at 07:57, Pali Rohár wrote: > > > > On Sunday 23 January 2022 07:36:22 Simon Glass wrote: > > > Hi Pali, > > > > > > On Sun, 23 Jan 2022 at 07:08, Pali Rohár wrote: > > > > > > > > + Maemo > > > > > > > > On Sunday 23 January 2022 07:04:03 Simon Glass wrote: > > > > > Drop this code which uses a header that is about to be deleted. > > > > > > > > And what / where is the replacement? > > > > > > This is DM_VIDEO. There are quite a few example drivers in > > > drivers/video - perhaps the mxsfb.c one is a reasonable example. See > > > the top of video_uclass.c for how frame-buffer allocation works. > > > > I have already WIP patches for usage of video-uclass.c but because > > reviewing of N900 patches is slow, I have not sent them yet. > > Who is reviewing them? Lokesh is reviewing omap3 and n900 patches. > If you send the patches I can review them and > we can get them applied for this release. I have already wrote in other thread I do not want to send too many patches if I see that review process is slow. And also because I totally lost the track what was send, what was not and what depends on what. And I do not want to work on too many things in paralel if I see that it took half year or more to make patches in acceptable form. > > > > So could you please do NOT remove N900 support? I would really > > appreciative for reviewing pending patches instead of sending patches > > with board removal. > > This is not a board removal, just dropping a feature. ... feature which is essential and without which board is unusable. > > > > Note that there is some issue with video_post_bind(), it throws > > false-positive error "Video device '%s' cannot allocate frame buffer > > memory" with "return -ENOSPC". If I remove that "return -ENOSPC" it is > > working fine. > > Do you need U-Boot to allocate the frame buffer. If so, this is likely > because your driver is not bound before relocation. See the comment > around that message in the code. > > Regards, > Simon I did not spend too much time for investigation. I just saw that removing that comment and returning makes it fully working.