Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CDBF1C433EF for ; Mon, 24 Jan 2022 16:53:15 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 71A8680FC6; Mon, 24 Jan 2022 17:53:13 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="sm4Nfugt"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 0206D80FC6; Mon, 24 Jan 2022 17:53:12 +0100 (CET) Received: from mail-qk1-x736.google.com (mail-qk1-x736.google.com [IPv6:2607:f8b0:4864:20::736]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 1D024802DF for ; Mon, 24 Jan 2022 17:53:09 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qk1-x736.google.com with SMTP id t1so20853578qkt.11 for ; Mon, 24 Jan 2022 08:53:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=UDAsZwhetQG0PD/mNn7QNPhF5U0+c+yD1BLPk9li6sU=; b=sm4NfugtbWZswe9lzdJ69s5hFIz9nP9JWW2uQ7OFxO982uDB6EafaKXPWADF9w7taY 9CVnGSHWMZtv23r7sUa153IXBzfhuLCLwlk4ME9MvPSNtQDN6GKaJ3bhMh6yXVM+K2C5 rAQD3sqkHM2XGDBbh1wp0F3iKCi3F/VYV9Ud8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=UDAsZwhetQG0PD/mNn7QNPhF5U0+c+yD1BLPk9li6sU=; b=PE+Cv0aPi2haXeTM586z1QO+8qlbqtokzs6RwMUt+MCugIAp7BfFiiD56gnxSjspe2 CP3qT2CaMBYawnELy1jy1ylGNJnpM+chM5T16S5aJtsVom9JFDwwhs0SHS7rkmVlP+cm hF5RLq8V76m5oPfG2TFHwdq1L9qq/IwD7IdQAewAfc3VzdZ+qO/Bs/zcohu4hG9xDZWX e8Ji7wH4GtUstijiJOLEV9Wso1EgHxYKXYF02HMc0xg9pOVU+lzhYRP0sZU/3oJB6j2q fXC4D9ueJI3WwZUKuNRP9IWu95UaRy3yh4YAAqlrLpb5vqAvWdhuV8MQgEvHPHVNuXrF uvGg== X-Gm-Message-State: AOAM532klzk0s/6zkuOFI6xDzddS7aG02k3lv34rXArgskMmvPJ8bxOX rbXbZARAyxWDqz3f+7Tne36cpw== X-Google-Smtp-Source: ABdhPJzqDuUrLuZzYYabzWitrK5f3wLpVF89+9PZcNi8ubUm2ZMyPWhUvQf5u3/ldcDsaQ/PxSCQ1A== X-Received: by 2002:a05:620a:2404:: with SMTP id d4mr11453808qkn.397.1643043187916; Mon, 24 Jan 2022 08:53:07 -0800 (PST) Received: from bill-the-cat (2603-6081-7b01-cbda-2ef0-5dff-fedb-a8ba.res6.spectrum.com. [2603:6081:7b01:cbda:2ef0:5dff:fedb:a8ba]) by smtp.gmail.com with ESMTPSA id k6sm8958qko.68.2022.01.24.08.53.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Jan 2022 08:53:07 -0800 (PST) Date: Mon, 24 Jan 2022 11:53:05 -0500 From: Tom Rini To: Stefan Eichenberger Cc: devel-sven@geroedel.de, mr.nuke.me@gmail.com, sjg@chromium.org, u-boot@lists.denx.de Subject: Re: [PATCH 1/2] tools/fitimage: remove redundant format check Message-ID: <20220124165305.GW7515@bill-the-cat> References: <20220110174832.257300-1-eichest@gmail.com> <20220110174832.257300-2-eichest@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="1y1tiN5hVw5cPBDe" Content-Disposition: inline In-Reply-To: <20220110174832.257300-2-eichest@gmail.com> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean --1y1tiN5hVw5cPBDe Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jan 10, 2022 at 06:48:31PM +0100, Stefan Eichenberger wrote: > fit_extract_contents does a fit_check_format even thought it was already > checked during imagetool_verify_print_header. > Therefore, this check is not necessary. This commit removes the > redundancy. >=20 > Signed-off-by: Stefan Eichenberger > Reviewed-by: Simon Glass Applied to u-boot/master, thanks! --=20 Tom --1y1tiN5hVw5cPBDe Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmHu2W4ACgkQFHw5/5Y0 tyxPWwwApgLdWr7w2WKT64VwvHpH98UlcOmcR/16bjCbTRuMKqG9RnNHOyWjpH0X k7tb1OQVjhHKJH2QRX8PdJkv/Ydwc8+BikubVnbpK0cPpZTxpghJoBSJ9dPvDnWq h1P5HngfxeQgKZ3MV2+PHNABEnKBIkYoES/x28gy6gzMl94A5wpGX7+Bja3pdAQj rt/I7Ox/x36ZX86+0ik8y7BHBMCkIGfp4VuQ89Y9eIFrS8hsE+Y++fKG0KqAE4rC /dROP7HV6RGlnd1gTNBxtSVKDvWB22hKGWTSLGZyNYffK6s3B4loLFEi3LtmHT7h Vh3INUYjeiTb0dIo9q/T4KYgAw8/oVlmtVVQVFqSVXzlbAtI+LsKeU8fVj2/ZeuZ xCXp8Nf4RGfn4cEkMC0Q3YJq3gD3/ncQ/MDZobSgmCpPqL//G6MFebl3MDHtGyV+ DZqLymgxCSyQEIWORfBgjwiR91kXhAkcUkDh8AOc+Qr/+0ZsbL6xflDodC7M2QBr yKBCCZgk =FQgc -----END PGP SIGNATURE----- --1y1tiN5hVw5cPBDe--