Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 04CA4C433F5 for ; Mon, 24 Jan 2022 16:53:25 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 577A083056; Mon, 24 Jan 2022 17:53:21 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="l4iDpHfa"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 901B981DF6; Mon, 24 Jan 2022 17:53:17 +0100 (CET) Received: from mail-qt1-x82d.google.com (mail-qt1-x82d.google.com [IPv6:2607:f8b0:4864:20::82d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 6A8D18129F for ; Mon, 24 Jan 2022 17:53:14 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x82d.google.com with SMTP id c15so7726603qtv.1 for ; Mon, 24 Jan 2022 08:53:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=EvNQuP3qGROLsgTb+YgvoXyEHtEI80I0u441yh0GB84=; b=l4iDpHfahZ7CrDRd9sJvGJ/xj3q63C7ceeNam4NkX26/mGONdXRyF+vPg7hAmgU5KN Icb2QkALrqC7eeWe+vW3CJ5NHJQGVpxtaQigFuQuKD3SbJswJOKXwX1YawckuTu/05h8 umiDOmnTHvm6GuFaw3J0gmZwzUgWQqaCJPv1E= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=EvNQuP3qGROLsgTb+YgvoXyEHtEI80I0u441yh0GB84=; b=3cSAokeUxqcYByzG5tcVTImXV3q1x6skI0W8BbL9if8hT3UXIE6V4SGkGjHqSNlKhU /Y9TUAZ1z5Tor+ra2+yHZgRHMp4PxUrfUoo50NZmqoKW7omh4KrbeXyuS/qy2feGYD+q ejkz+xQmK1CqidL1odrd/a9nK4FvD4HMBEhQdkJYcKXVMikRdC65tnUfiqrNzNdaARXh CBEjbQtiGNtRM6WhITEsUFL/3WD0F7W8mOd409qJiLNtqZdBFkOYV4yDF/kWqTIughC4 W913+ish6GIVvzl7PMHBejSm/oGjv1s6ZBug5LV61slzShoKKzXHebae3XguZJG2I6hO w0BA== X-Gm-Message-State: AOAM533Ld7lMzm9AX6TinKGRWOZuXK4JXev4siDgKB4e9Q915fwN4AWN S/ORfejHvFr9qcaSlFBQwwhs1A== X-Google-Smtp-Source: ABdhPJyDDrDzXMZoSEDhtuzKbKhVxZdg5ROu/nMfhz4YxfmLBlE3GXdBelhFRTg0LGV/ZPpS4BgMrw== X-Received: by 2002:a05:622a:58d:: with SMTP id c13mr12249493qtb.284.1643043193249; Mon, 24 Jan 2022 08:53:13 -0800 (PST) Received: from bill-the-cat (2603-6081-7b01-cbda-2ef0-5dff-fedb-a8ba.res6.spectrum.com. [2603:6081:7b01:cbda:2ef0:5dff:fedb:a8ba]) by smtp.gmail.com with ESMTPSA id j14sm7796705qkp.131.2022.01.24.08.53.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Jan 2022 08:53:12 -0800 (PST) Date: Mon, 24 Jan 2022 11:53:10 -0500 From: Tom Rini To: Stefan Eichenberger Cc: devel-sven@geroedel.de, mr.nuke.me@gmail.com, sjg@chromium.org, u-boot@lists.denx.de Subject: Re: [PATCH 2/2] tools/fitimage: make sure dumpimage still works when "@" are detected Message-ID: <20220124165310.GX7515@bill-the-cat> References: <20220110174832.257300-1-eichest@gmail.com> <20220110174832.257300-3-eichest@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="Bzq2cJcN05fcPrs+" Content-Disposition: inline In-Reply-To: <20220110174832.257300-3-eichest@gmail.com> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean --Bzq2cJcN05fcPrs+ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jan 10, 2022 at 06:48:32PM +0100, Stefan Eichenberger wrote: > fit_verify_header fails if it detects unit addresses "@". However, this > will break tools like dumpimage on fit images which worked with previous > versions of the tool (e.g. 2020.04 vs 2021.07). As an example the output > of: > dumpimage -l > is: > FIT description: U-Boot fitImage for Linux Distribution > Created: Thu Jan 1 01:00:00 1970 > Image 0 (kernel@1) > Description: Linux kernel > Created: Thu Jan 1 01:00:00 1970 > Type: Kernel Image > Compression: gzip compressed > Data Size: 6442456 Bytes =3D 6291.46 KiB =3D 6.14 MiB > Architecture: AArch64 > OS: Linux > Load Address: 0x80080000 > Entry Point: 0x80080000 > Hash algo: sha256 > Hash value: ... > Image 1 (fdt@freescale_fsl-s32g274a-evb.dtb) > Description: Flattened Device Tree blob > Created: Thu Jan 1 01:00:00 1970 > Type: Flat Device Tree > Compression: uncompressed > Data Size: 39661 Bytes =3D 38.73 KiB =3D 0.04 MiB > Architecture: AArch64 > Hash algo: sha256 > Hash value: ... > Default Configuration: 'conf@freescale_fsl-s32g274a-evb.dtb' > Configuration 0 (conf@freescale_fsl-s32g274a-evb.dtb) > Description: 1 Linux kernel, FDT blob > Kernel: kernel@1 > FDT: fdt@freescale_fsl-s32g274a-evb.dtb > Hash algo: sha256 > Hash value: unavailable >=20 > But with newer version it shows: > dumpimage -l > GP Header: Size d00dfeed LoadAddr 62f0a4 >=20 > This commit will output a warning that unit addresses were detected but > will not fail: > dumpimage -l > Image contains unit addresses @, this will break signing > ... >=20 > Signed-off-by: Stefan Eichenberger > Reviewed-by: Simon Glass Applied to u-boot/master, thanks! --=20 Tom --Bzq2cJcN05fcPrs+ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmHu2XYACgkQFHw5/5Y0 tyyUpAwAt+f/uqHg/nsHVbSitF6MVqGNWbw8Cu+6XUWO07UvRkYCqs4Xd6anpDIF Jg+2lj0z/RMIS9GD+WnWE55PTP4JQ4qZBLCFqrxSJNhRNK+9Bs+rQVnkeUbcvLuc WeGk2KKArkOxt4tNuUo49j+8QfihRBavTZj1QpLM1L6QykpBfWugoQ+r0Df0bNiv BlBYvaK3xJjpCbsUfrumuq6P7JrekfmV5G/GDCnDoYZyRanvnPFr76bLTJxDVgsD YwHFjfpKhFjpfivSDpPNqEPX7kmxMSBYLJyClqr6ByYX21gXpKjOoviXBYaLlLwQ FD5qypbvluaz514XEjftbmm+Olyg8JS/d898L+ud4iqyvLF5NgqshjM5JfOnpnur TCEfZ/CcBv/8sugBl+oZPJu8M2Al6VZ4haBCuMdSdUFcDe2yq3G1VALfwHsdw5f6 cmLg5Xad6dmZCLwb/E/pbiNyZL9H25HKQcHPJ6sn8c0s1gnKAiTSjuYUDVn9zUX+ R69TmXsx =1+97 -----END PGP SIGNATURE----- --Bzq2cJcN05fcPrs+--