Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 59DE8C433F5 for ; Mon, 24 Jan 2022 16:54:47 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 161CE835EA; Mon, 24 Jan 2022 17:54:20 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="HEVviKWf"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id A3E6982FA3; Mon, 24 Jan 2022 17:54:17 +0100 (CET) Received: from mail-qv1-xf33.google.com (mail-qv1-xf33.google.com [IPv6:2607:f8b0:4864:20::f33]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 56C55832FD for ; Mon, 24 Jan 2022 17:54:14 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qv1-xf33.google.com with SMTP id hu2so21596419qvb.8 for ; Mon, 24 Jan 2022 08:54:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=hsGPyLswvU/Rh1q9rrNRg/UQ1UxuBi2/hN3pHLxgRDY=; b=HEVviKWfyCsC/m212+qibR6sYP+WUpvDEgDYeSr/vTFUaCkbgQl+YJzYRoJWYOQWsF 2m02B+pzLUK/jajWyzU0ue6nSk/5mYZebIs+AiT21qQIX+ubW5rQ1xgqfWc4ElHh3b4S Jw9qVspVajktBOjRlAg+pNPNfrByYBUMPoHM4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=hsGPyLswvU/Rh1q9rrNRg/UQ1UxuBi2/hN3pHLxgRDY=; b=2m3wbZfe6oqqegdVlLie9/NM/i0jk0BtUvgCSfM3yDVYCQG/7SZT0oPYgKLH2aMONC VV2XLfMGZRGSrShC6Kye0XNlQ1nxO+iMlNcoZG7KZbr9armv9JTNtpe/r42+z1tzlO8R BibBqBBGkkS+7U0RxRQRyioTumo4ZG8EVeCklMId+64vuJtDrcEweTEungTSdoTcdNjF cH8h6lPDOZ2J+F+2Gowoaz3/gxU8C5OI07mqNaAisAzczHTlVkiCTY8swckFNYvORrhD gclLw39xw4qc+CFHuuTUbUtVedTVT8AnZS5i8P73p98MyauY8l/vB6ETvKbWN7Xt/BDU iKVQ== X-Gm-Message-State: AOAM532R9yUYkJ7QfCW1gY8RVzfVG2BdATIJJgw3cTBKMWgNGe5tUtmq xR9ldNClNb9R5Yfws5sq3f1yWA== X-Google-Smtp-Source: ABdhPJyeYB3TR3/UKSr8vrtHSctphzoHMiFSNgsu7SjF49fEtf8ZmR7K04M1J+MkwP2uFzFPvuUZnA== X-Received: by 2002:ad4:5748:: with SMTP id q8mr15430580qvx.117.1643043253196; Mon, 24 Jan 2022 08:54:13 -0800 (PST) Received: from bill-the-cat (2603-6081-7b01-cbda-2ef0-5dff-fedb-a8ba.res6.spectrum.com. [2603:6081:7b01:cbda:2ef0:5dff:fedb:a8ba]) by smtp.gmail.com with ESMTPSA id x22sm7987277qkp.120.2022.01.24.08.54.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Jan 2022 08:54:12 -0800 (PST) Date: Mon, 24 Jan 2022 11:54:10 -0500 From: Tom Rini To: Andre Przywara Cc: Linus Walleij , Liviu Dudau , Simon Glass , Marek Vasut , Ross Burton , u-boot@lists.denx.de Subject: Re: [PATCH] vexpress64: semi_defconfig: disable CRC32 support Message-ID: <20220124165410.GF7515@bill-the-cat> References: <20220121163604.2503548-1-andre.przywara@arm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="pnDjx0H/VpusRTEI" Content-Disposition: inline In-Reply-To: <20220121163604.2503548-1-andre.przywara@arm.com> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean --pnDjx0H/VpusRTEI Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jan 21, 2022 at 04:36:04PM +0000, Andre Przywara wrote: > Commit 270f8710f92f ("crc32: Add crc32 implementation using > __builtin_aarch64_crc32b") enabled the usage of ARMv8 CRC instructions > by default, for all arm64 builds. And indeed all Arm Ltd. v8 Cortex-A > cores support the instructions, and they are mandatory starting with > architecture revision v8.1, so realistically every known hardware > implementation should support them. >=20 > The Arm Fastmodel however defaults to the bare minimum ARMv8 feature set > by default, which means v8.0 without the CRC instructions, so U-Boot > hangs very early at the moment, without any output (the boot-wrapper or > TF-A printing the last visible lines). >=20 > Support for those instructions can be enabled on the model command line > by either: > -C cluster0.cpu0.enable_crc32=3D1 (for each core) > or by using a higher architecture revision by default: > -C cluster0.has_arm_v8-1=3D1 (for each cluster) > Of course any arch revision higher than v8.1 would work as well. >=20 > But for the sake of a smooth out-of-the-box experience, let's just > disable the usage of those instructions in the defconfig, to avoid > random hangs without any clues. >=20 > Reported-by: Ross Burton > Signed-off-by: Andre Przywara > Acked-by: Marek Vasut Applied to u-boot/master, thanks! --=20 Tom --pnDjx0H/VpusRTEI Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmHu2bIACgkQFHw5/5Y0 tywe+AwAqph250p305SHnc0P3uShUrZEnAT6HiumvizWPB9aryQKO04sx8YseWgX V1ahWLSUybJOXLYnHLMwHZRNifqInSr3furN8Y6w1KhXlazQiVmCFT9OD9BOHYE0 Te9BWguj4r1H1Ls/j8Vsfl2MrthlbyQFzTvv3AYEIeAs54CGFwIPrOwTCESf0Hns P5r3CLFFCHbPu/InQRBcg07eXvuNb2HAvZP7pQWuwh+73SOQL1Mp1oYhhswVu/Cm SMM4lQuQZMrK/K+AsWEp8V3GxnUgZgdT00Ttr97Aw0wieT7fg1fKexB9R0MFmT8p JSDx+ksnGMh9J7gYRhtpg0m6mHJlkJ5n2KhLkGh1iYve6r57yZB6k79xmzMtz5Ty QctmdMgTu+VZMridE6OCV8I+JfvPtANSAPl87eJa7CAawaqJ1YKh15VEBpYFks4L VcWWr1GUY/XGLetJ1w7W3zkZ0GgtNX0LNCPnLcQA/wJg9dZFyeYIK4O9XG4mQ9bD G7k4BKFm =MbjB -----END PGP SIGNATURE----- --pnDjx0H/VpusRTEI--