Content-Type: multipart/mixed; boundary="===============6675992118958960040==" MIME-Version: 1.0 From: kernel test robot To: kbuild-all@lists.01.org Subject: Re: [PATCH] staging: android: ashmem: Declared file operation with const keyword Date: Mon, 24 Jan 2022 20:27:22 +0800 Message-ID: <202201242027.9RTdyW5P-lkp@intel.com> In-Reply-To: <1643008187-75859-1-git-send-email-me.ratnesh682@gmail.com> List-Id: --===============6675992118958960040== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Hi ratnesh-r1, Thank you for the patch! Yet something to improve: [auto build test ERROR on staging/staging-testing] url: https://github.com/0day-ci/linux/commits/ratnesh-r1/staging-android= -ashmem-Declared-file-operation-with-const-keyword/20220124-151116 base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git = fa783154524a71ab74e293cd8251155e5971952b config: riscv-randconfig-c006-20220124 (https://download.01.org/0day-ci/arc= hive/20220124/202201242027.9RTdyW5P-lkp(a)intel.com/config) compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 2e58a1= 8910867ba6795066e044293e6daf89edf5) reproduce (this is a W=3D1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/= make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install riscv cross compiling tool for clang build # apt-get install binutils-riscv64-linux-gnu # https://github.com/0day-ci/linux/commit/c24fe2afe4abdf6436628abd1= 3a0109ec420f373 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review ratnesh-r1/staging-android-ashmem-= Declared-file-operation-with-const-keyword/20220124-151116 git checkout c24fe2afe4abdf6436628abd13a0109ec420f373 # save the config file to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=3D$HOME/0day COMPILER=3Dclang make.cross W=3D= 1 O=3Dbuild_dir ARCH=3Driscv SHELL=3D/bin/bash drivers/staging/android/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All errors (new ones prefixed by >>): >> drivers/staging/android/ashmem.c:431:16: error: cannot assign to variabl= e 'vmfile_fops' with const-qualified type 'const struct file_operations' vmfile_fops =3D *vmfile->f_op; ~~~~~~~~~~~ ^ drivers/staging/android/ashmem.c:380:38: note: variable 'vmfile_fops' de= clared const here static const struct file_operations vmfile_fops; ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~ drivers/staging/android/ashmem.c:432:21: error: cannot assign to variabl= e 'vmfile_fops' with const-qualified type 'const struct file_operations' vmfile_fops.mmap =3D ashmem_vmfile_mmap; ~~~~~~~~~~~~~~~~ ^ drivers/staging/android/ashmem.c:380:38: note: variable 'vmfile_fops' de= clared const here static const struct file_operations vmfile_fops; ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~ drivers/staging/android/ashmem.c:433:34: error: cannot assign to variabl= e 'vmfile_fops' with const-qualified type 'const struct file_operations' vmfile_fops.get_unmapped_area =3D ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ drivers/staging/android/ashmem.c:380:38: note: variable 'vmfile_fops' de= clared const here static const struct file_operations vmfile_fops; ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~ 3 errors generated. vim +431 drivers/staging/android/ashmem.c 6d67b0290b4b84 Suren Baghdasaryan 2020-01-27 377 = 11980c2ac4ccfa Robert Love 2011-12-20 378 static int ashmem_mmap(s= truct file *file, struct vm_area_struct *vma) 11980c2ac4ccfa Robert Love 2011-12-20 379 { c24fe2afe4abdf ratnesh-r1 2022-01-23 380 static const struct fil= e_operations vmfile_fops; 11980c2ac4ccfa Robert Love 2011-12-20 381 struct ashmem_area *asm= a =3D file->private_data; 11980c2ac4ccfa Robert Love 2011-12-20 382 int ret =3D 0; 11980c2ac4ccfa Robert Love 2011-12-20 383 = 11980c2ac4ccfa Robert Love 2011-12-20 384 mutex_lock(&ashmem_mute= x); 11980c2ac4ccfa Robert Love 2011-12-20 385 = 11980c2ac4ccfa Robert Love 2011-12-20 386 /* user needs to SET_SI= ZE before mapping */ 59848d6aded59a Alistair Strachan 2018-06-19 387 if (!asma->size) { 11980c2ac4ccfa Robert Love 2011-12-20 388 ret =3D -EINVAL; 11980c2ac4ccfa Robert Love 2011-12-20 389 goto out; 11980c2ac4ccfa Robert Love 2011-12-20 390 } 11980c2ac4ccfa Robert Love 2011-12-20 391 = 8632c614565d0c Alistair Strachan 2018-06-19 392 /* requested mapping si= ze larger than object size */ 8632c614565d0c Alistair Strachan 2018-06-19 393 if (vma->vm_end - vma->= vm_start > PAGE_ALIGN(asma->size)) { 11980c2ac4ccfa Robert Love 2011-12-20 394 ret =3D -EINVAL; 11980c2ac4ccfa Robert Love 2011-12-20 395 goto out; 11980c2ac4ccfa Robert Love 2011-12-20 396 } 11980c2ac4ccfa Robert Love 2011-12-20 397 = 11980c2ac4ccfa Robert Love 2011-12-20 398 /* requested protection= bits must match our allowed protection mask */ 59848d6aded59a Alistair Strachan 2018-06-19 399 if ((vma->vm_flags & ~c= alc_vm_prot_bits(asma->prot_mask, 0)) & 59848d6aded59a Alistair Strachan 2018-06-19 400 calc_vm_prot_bits(P= ROT_MASK, 0)) { 11980c2ac4ccfa Robert Love 2011-12-20 401 ret =3D -EPERM; 11980c2ac4ccfa Robert Love 2011-12-20 402 goto out; 11980c2ac4ccfa Robert Love 2011-12-20 403 } 56f76fc68492af Arve Hj=C3=B8nnev=C3=A5g 2011-12-20 404 vma->vm_flags= &=3D ~calc_vm_may_flags(~asma->prot_mask); 11980c2ac4ccfa Robert Love 2011-12-20 405 = 11980c2ac4ccfa Robert Love 2011-12-20 406 if (!asma->file) { 11980c2ac4ccfa Robert Love 2011-12-20 407 char *name =3D ASHMEM_= NAME_DEF; 11980c2ac4ccfa Robert Love 2011-12-20 408 struct file *vmfile; 3e338d3c95c735 Suren Baghdasaryan 2020-07-30 409 struct inode *inode; 11980c2ac4ccfa Robert Love 2011-12-20 410 = 11980c2ac4ccfa Robert Love 2011-12-20 411 if (asma->name[ASHMEM_= NAME_PREFIX_LEN] !=3D '\0') 11980c2ac4ccfa Robert Love 2011-12-20 412 name =3D asma->name; 11980c2ac4ccfa Robert Love 2011-12-20 413 = 11980c2ac4ccfa Robert Love 2011-12-20 414 /* ... and allocate th= e backing shmem file */ 11980c2ac4ccfa Robert Love 2011-12-20 415 vmfile =3D shmem_file_= setup(name, asma->size, vma->vm_flags); 7f44cb0ba88b40 Viresh Kumar 2015-07-31 416 if (IS_ERR(vmfile)) { 11980c2ac4ccfa Robert Love 2011-12-20 417 ret =3D PTR_ERR(vmfil= e); 11980c2ac4ccfa Robert Love 2011-12-20 418 goto out; 11980c2ac4ccfa Robert Love 2011-12-20 419 } 97fbfef6bd5978 Shuxiao Zhang 2017-04-06 420 vmfile->f_mode |=3D FM= ODE_LSEEK; 3e338d3c95c735 Suren Baghdasaryan 2020-07-30 421 inode =3D file_inode(v= mfile); 3e338d3c95c735 Suren Baghdasaryan 2020-07-30 422 lockdep_set_class(&ino= de->i_rwsem, &backing_shmem_inode_class); 11980c2ac4ccfa Robert Love 2011-12-20 423 asma->file =3D vmfile; 6d67b0290b4b84 Suren Baghdasaryan 2020-01-27 424 /* 6d67b0290b4b84 Suren Baghdasaryan 2020-01-27 425 * override mmap opera= tion of the vmfile so that it can't be 6d67b0290b4b84 Suren Baghdasaryan 2020-01-27 426 * remapped which woul= d lead to creation of a new vma with no 6d67b0290b4b84 Suren Baghdasaryan 2020-01-27 427 * asma permission che= cks. Have to override get_unmapped_area 6d67b0290b4b84 Suren Baghdasaryan 2020-01-27 428 * as well to prevent = VM_BUG_ON check for f_ops modification. 6d67b0290b4b84 Suren Baghdasaryan 2020-01-27 429 */ 6d67b0290b4b84 Suren Baghdasaryan 2020-01-27 430 if (!vmfile_fops.mmap)= { 6d67b0290b4b84 Suren Baghdasaryan 2020-01-27 @431 vmfile_fops =3D *vmfi= le->f_op; 6d67b0290b4b84 Suren Baghdasaryan 2020-01-27 432 vmfile_fops.mmap =3D = ashmem_vmfile_mmap; 6d67b0290b4b84 Suren Baghdasaryan 2020-01-27 433 vmfile_fops.get_unmap= ped_area =3D 6d67b0290b4b84 Suren Baghdasaryan 2020-01-27 434 ashmem_vmfile_get_u= nmapped_area; 6d67b0290b4b84 Suren Baghdasaryan 2020-01-27 435 } 6d67b0290b4b84 Suren Baghdasaryan 2020-01-27 436 vmfile->f_op =3D &vmfi= le_fops; 11980c2ac4ccfa Robert Love 2011-12-20 437 } 11980c2ac4ccfa Robert Love 2011-12-20 438 get_file(asma->file); 11980c2ac4ccfa Robert Love 2011-12-20 439 = 11980c2ac4ccfa Robert Love 2011-12-20 440 /* 11980c2ac4ccfa Robert Love 2011-12-20 441 * XXX - Reworked to us= e shmem_zero_setup() instead of 11980c2ac4ccfa Robert Love 2011-12-20 442 * shmem_set_file while= we're in staging. -jstultz 11980c2ac4ccfa Robert Love 2011-12-20 443 */ 11980c2ac4ccfa Robert Love 2011-12-20 444 if (vma->vm_flags & VM_= SHARED) { 11980c2ac4ccfa Robert Love 2011-12-20 445 ret =3D shmem_zero_set= up(vma); 11980c2ac4ccfa Robert Love 2011-12-20 446 if (ret) { 11980c2ac4ccfa Robert Love 2011-12-20 447 fput(asma->file); 11980c2ac4ccfa Robert Love 2011-12-20 448 goto out; 11980c2ac4ccfa Robert Love 2011-12-20 449 } 44960f2a7b63e2 John Stultz 2018-07-31 450 } else { 44960f2a7b63e2 John Stultz 2018-07-31 451 vma_set_anonymous(vma); 11980c2ac4ccfa Robert Love 2011-12-20 452 } 11980c2ac4ccfa Robert Love 2011-12-20 453 = 295992fb815e79 Christian K=C3=B6nig 2020-09-14 454 vma_set_file(vma, = asma->file); 295992fb815e79 Christian K=C3=B6nig 2020-09-14 455 /* XXX: merge this= with the get_file() above if possible */ 295992fb815e79 Christian K=C3=B6nig 2020-09-14 456 fput(asma->file); 11980c2ac4ccfa Robert Love 2011-12-20 457 = 11980c2ac4ccfa Robert Love 2011-12-20 458 out: 11980c2ac4ccfa Robert Love 2011-12-20 459 mutex_unlock(&ashmem_mu= tex); 11980c2ac4ccfa Robert Love 2011-12-20 460 return ret; 11980c2ac4ccfa Robert Love 2011-12-20 461 } 11980c2ac4ccfa Robert Love 2011-12-20 462 = --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org --===============6675992118958960040==--