Content-Type: multipart/mixed; boundary="===============4556707558873220174==" MIME-Version: 1.0 From: kernel test robot To: kbuild-all@lists.01.org Subject: Re: [PATCH 10/11] serial: make uart_console_write->putchar()'s character a char Date: Tue, 25 Jan 2022 00:23:52 +0800 Message-ID: <202201250004.SHBbOjs3-lkp@intel.com> In-Reply-To: <20220124071430.14907-11-jslaby@suse.cz> List-Id: --===============4556707558873220174== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Hi Jiri, I love your patch! Yet something to improve: [auto build test ERROR on tty/tty-testing] [also build test ERROR on v5.17-rc1 next-20220124] [cannot apply to shawnguo/for-next davem-sparc/master] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Jiri-Slaby/TTY-patches-for= -5-18/20220124-151758 base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git tty-= testing config: arc-randconfig-r043-20220124 (https://download.01.org/0day-ci/archi= ve/20220125/202201250004.SHBbOjs3-lkp(a)intel.com/config) compiler: arc-elf-gcc (GCC) 11.2.0 reproduce (this is a W=3D1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/= make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/45520d4f6db241db0b77f4116= 2adba4a9977956c git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Jiri-Slaby/TTY-patches-for-5-18/20= 220124-151758 git checkout 45520d4f6db241db0b77f41162adba4a9977956c # save the config file to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=3D$HOME/0day COMPILER=3Dgcc-11.2.0 make.cross= O=3Dbuild_dir ARCH=3Darc SHELL=3D/bin/bash drivers/tty/serial/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All errors (new ones prefixed by >>): drivers/tty/serial/omap-serial.c: In function 'serial_omap_console_write= ': >> drivers/tty/serial/omap-serial.c:1272:49: error: passing argument 4 of '= uart_console_write' from incompatible pointer type [-Werror=3Dincompatible-= pointer-types] 1272 | uart_console_write(&up->port, s, count, serial_omap_cons= ole_putchar); | ^~~~~~~~~~~~~~~~= ~~~~~~~~~~~ | | | void (*)(struct = uart_port *, int) In file included from drivers/tty/serial/omap-serial.c:30: include/linux/serial_core.h:402:32: note: expected 'void (*)(struct uart= _port *, char)' but argument is of type 'void (*)(struct uart_port *, int)' 402 | void (*putchar)(struct uart_port *, char= )); | ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ cc1: some warnings being treated as errors vim +/uart_console_write +1272 drivers/tty/serial/omap-serial.c b612633b592807 drivers/serial/omap-serial.c Govindraj.R 2010-09-27 1248 = b612633b592807 drivers/serial/omap-serial.c Govindraj.R 2010-09-27 1249 s= tatic void b612633b592807 drivers/serial/omap-serial.c Govindraj.R 2010-09-27 1250 s= erial_omap_console_write(struct console *co, const char *s, b612633b592807 drivers/serial/omap-serial.c Govindraj.R 2010-09-27 1251 = unsigned int count) b612633b592807 drivers/serial/omap-serial.c Govindraj.R 2010-09-27 1252 { b612633b592807 drivers/serial/omap-serial.c Govindraj.R 2010-09-27 1253 = struct uart_omap_port *up =3D serial_omap_console_ports[co->index]; b612633b592807 drivers/serial/omap-serial.c Govindraj.R 2010-09-27 1254 = unsigned long flags; b612633b592807 drivers/serial/omap-serial.c Govindraj.R 2010-09-27 1255 = unsigned int ier; b612633b592807 drivers/serial/omap-serial.c Govindraj.R 2010-09-27 1256 = int locked =3D 1; b612633b592807 drivers/serial/omap-serial.c Govindraj.R 2010-09-27 1257 = b612633b592807 drivers/serial/omap-serial.c Govindraj.R 2010-09-27 1258 = local_irq_save(flags); b612633b592807 drivers/serial/omap-serial.c Govindraj.R 2010-09-27 1259 = if (up->port.sysrq) b612633b592807 drivers/serial/omap-serial.c Govindraj.R 2010-09-27 1260 = locked =3D 0; b612633b592807 drivers/serial/omap-serial.c Govindraj.R 2010-09-27 1261 = else if (oops_in_progress) b612633b592807 drivers/serial/omap-serial.c Govindraj.R 2010-09-27 1262 = locked =3D spin_trylock(&up->port.lock); b612633b592807 drivers/serial/omap-serial.c Govindraj.R 2010-09-27 1263 = else b612633b592807 drivers/serial/omap-serial.c Govindraj.R 2010-09-27 1264 = spin_lock(&up->port.lock); b612633b592807 drivers/serial/omap-serial.c Govindraj.R 2010-09-27 1265 = b612633b592807 drivers/serial/omap-serial.c Govindraj.R 2010-09-27 1266 = /* b612633b592807 drivers/serial/omap-serial.c Govindraj.R 2010-09-27 1267 = * First save the IER then disable the interrupts b612633b592807 drivers/serial/omap-serial.c Govindraj.R 2010-09-27 1268 = */ b612633b592807 drivers/serial/omap-serial.c Govindraj.R 2010-09-27 1269 = ier =3D serial_in(up, UART_IER); b612633b592807 drivers/serial/omap-serial.c Govindraj.R 2010-09-27 1270 = serial_out(up, UART_IER, 0); b612633b592807 drivers/serial/omap-serial.c Govindraj.R 2010-09-27 1271 = b612633b592807 drivers/serial/omap-serial.c Govindraj.R 2010-09-27 @1272 = uart_console_write(&up->port, s, count, serial_omap_console_putchar); b612633b592807 drivers/serial/omap-serial.c Govindraj.R 2010-09-27 1273 = b612633b592807 drivers/serial/omap-serial.c Govindraj.R 2010-09-27 1274 = /* b612633b592807 drivers/serial/omap-serial.c Govindraj.R 2010-09-27 1275 = * Finally, wait for transmitter to become empty b612633b592807 drivers/serial/omap-serial.c Govindraj.R 2010-09-27 1276 = * and restore the IER b612633b592807 drivers/serial/omap-serial.c Govindraj.R 2010-09-27 1277 = */ b612633b592807 drivers/serial/omap-serial.c Govindraj.R 2010-09-27 1278 = wait_for_xmitr(up); b612633b592807 drivers/serial/omap-serial.c Govindraj.R 2010-09-27 1279 = serial_out(up, UART_IER, ier); b612633b592807 drivers/serial/omap-serial.c Govindraj.R 2010-09-27 1280 = /* b612633b592807 drivers/serial/omap-serial.c Govindraj.R 2010-09-27 1281 = * The receive handling will happen properly because the b612633b592807 drivers/serial/omap-serial.c Govindraj.R 2010-09-27 1282 = * receive ready bit will still be set; it is not cleared b612633b592807 drivers/serial/omap-serial.c Govindraj.R 2010-09-27 1283 = * on read. However, modem control will not, we must b612633b592807 drivers/serial/omap-serial.c Govindraj.R 2010-09-27 1284 = * call it if we have saved something in the saved flags b612633b592807 drivers/serial/omap-serial.c Govindraj.R 2010-09-27 1285 = * while processing with interrupts off. b612633b592807 drivers/serial/omap-serial.c Govindraj.R 2010-09-27 1286 = */ b612633b592807 drivers/serial/omap-serial.c Govindraj.R 2010-09-27 1287 = if (up->msr_saved_flags) b612633b592807 drivers/serial/omap-serial.c Govindraj.R 2010-09-27 1288 = check_modem_status(up); b612633b592807 drivers/serial/omap-serial.c Govindraj.R 2010-09-27 1289 = b612633b592807 drivers/serial/omap-serial.c Govindraj.R 2010-09-27 1290 = if (locked) b612633b592807 drivers/serial/omap-serial.c Govindraj.R 2010-09-27 1291 = spin_unlock(&up->port.lock); b612633b592807 drivers/serial/omap-serial.c Govindraj.R 2010-09-27 1292 = local_irq_restore(flags); b612633b592807 drivers/serial/omap-serial.c Govindraj.R 2010-09-27 1293 } b612633b592807 drivers/serial/omap-serial.c Govindraj.R 2010-09-27 1294 = --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org --===============4556707558873220174==--