Content-Type: multipart/mixed; boundary="===============3674100760539556085==" MIME-Version: 1.0 From: kernel test robot To: kbuild-all@lists.01.org Subject: Re: [PATCH v3 2/2] PCI: rcar: Return all Fs from read which triggered an exception Date: Fri, 28 Jan 2022 10:47:10 +0800 Message-ID: <202201281037.40i8elct-lkp@intel.com> In-Reply-To: <20220122221554.196311-2-marek.vasut@gmail.com> List-Id: --===============3674100760539556085== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Hi, I love your patch! Yet something to improve: [auto build test ERROR on helgaas-pci/next] [also build test ERROR on v5.17-rc1 next-20220127] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/marek-vasut-gmail-com/PCI-= rcar-Finish-transition-to-L1-state-in-rcar_pcie_config_access/20220123-0617= 42 base: https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git next config: arm-buildonly-randconfig-r002-20220127 (https://download.01.org/0da= y-ci/archive/20220128/202201281037.40i8elct-lkp(a)intel.com/config) compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project f400a6= 012c668dfaa73462caf067ceb074e66c47) reproduce (this is a W=3D1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/= make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install arm cross compiling tool for clang build # apt-get install binutils-arm-linux-gnueabi # https://github.com/0day-ci/linux/commit/1eeb0cd756244c956c8b0fa80= 9f2d4e5bee530b4 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review marek-vasut-gmail-com/PCI-rcar-Fin= ish-transition-to-L1-state-in-rcar_pcie_config_access/20220123-061742 git checkout 1eeb0cd756244c956c8b0fa809f2d4e5bee530b4 # save the config file to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=3D$HOME/0day COMPILER=3Dclang make.cross W=3D= 1 O=3Dbuild_dir ARCH=3Darm SHELL=3D/bin/bash If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All errors (new ones prefixed by >>): drivers/pci/controller/pcie-rcar-host.c:133:5: warning: no previous prot= otype for function 'rcar_pci_write_reg_workaround' [-Wmissing-prototypes] int rcar_pci_write_reg_workaround(struct rcar_pcie *pcie, u32 val, unsig= ned int reg) ^ drivers/pci/controller/pcie-rcar-host.c:133:1: note: declare 'static' if= the function is not intended to be used outside of this translation unit int rcar_pci_write_reg_workaround(struct rcar_pcie *pcie, u32 val, unsig= ned int reg) ^ static = drivers/pci/controller/pcie-rcar-host.c:146:5: warning: no previous prot= otype for function 'rcar_pci_read_reg_workaround' [-Wmissing-prototypes] int rcar_pci_read_reg_workaround(struct rcar_pcie *pcie, u32 *val, unsig= ned int reg) ^ drivers/pci/controller/pcie-rcar-host.c:146:1: note: declare 'static' if= the function is not intended to be used outside of this translation unit int rcar_pci_read_reg_workaround(struct rcar_pcie *pcie, u32 *val, unsig= ned int reg) ^ static = >> drivers/pci/controller/pcie-rcar-host.c:138:3: error: instruction requir= es: data-barriers __rcar_pci_rw_reg_workaround("str") ^ drivers/pci/controller/pcie-rcar-host.c:120:4: note: expanded from macro= '__rcar_pci_rw_reg_workaround' "2: isb\n" \ ^ :2:4: note: instantiated into assembly here 2: isb ^ drivers/pci/controller/pcie-rcar-host.c:151:3: error: instruction requir= es: data-barriers __rcar_pci_rw_reg_workaround("ldr") ^ drivers/pci/controller/pcie-rcar-host.c:120:4: note: expanded from macro= '__rcar_pci_rw_reg_workaround' "2: isb\n" \ ^ :2:4: note: instantiated into assembly here 2: isb ^ >> drivers/pci/controller/pcie-rcar-host.c:138:3: error: instruction requir= es: data-barriers __rcar_pci_rw_reg_workaround("str") ^ drivers/pci/controller/pcie-rcar-host.c:120:4: note: expanded from macro= '__rcar_pci_rw_reg_workaround' "2: isb\n" \ ^ :2:4: note: instantiated into assembly here 2: isb ^ drivers/pci/controller/pcie-rcar-host.c:151:3: error: instruction requir= es: data-barriers __rcar_pci_rw_reg_workaround("ldr") ^ drivers/pci/controller/pcie-rcar-host.c:120:4: note: expanded from macro= '__rcar_pci_rw_reg_workaround' "2: isb\n" \ ^ :2:4: note: instantiated into assembly here 2: isb ^ 2 warnings and 4 errors generated. vim +138 drivers/pci/controller/pcie-rcar-host.c 132 = 133 int rcar_pci_write_reg_workaround(struct rcar_pcie *pcie, u32 val, u= nsigned int reg) 134 { 135 int error =3D PCIBIOS_SUCCESSFUL; 136 #ifdef CONFIG_ARM 137 asm volatile( > 138 __rcar_pci_rw_reg_workaround("str") 139 : "+r"(error):"r"(val), "r"(pcie->base + reg) : "memory"); 140 #else 141 rcar_pci_write_reg(pcie, val, reg); 142 #endif 143 return error; 144 } 145 = --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org --===============3674100760539556085==--