Content-Type: multipart/mixed; boundary="===============0832333539332021809==" MIME-Version: 1.0 From: kernel test robot To: kbuild-all@lists.01.org Subject: Re: [PATCH] net/switchdev: use struct_size over open coded arithmetic Date: Fri, 28 Jan 2022 20:40:48 +0800 Message-ID: <202201282035.8dNEcULs-lkp@intel.com> In-Reply-To: <20220128075729.1211352-1-chi.minghao@zte.com.cn> List-Id: --===============0832333539332021809== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Hi, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v5.17-rc1 next-20220128] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/cgel-zte-gmail-com/net-swi= tchdev-use-struct_size-over-open-coded-arithmetic/20220128-155848 base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git = 23a46422c56144939c091c76cf389aa863ce9c18 config: arm-orion5x_defconfig (https://download.01.org/0day-ci/archive/2022= 0128/202201282035.8dNEcULs-lkp(a)intel.com/config) compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 33b45e= e44b1f32ffdbc995e6fec806271b4b3ba4) reproduce (this is a W=3D1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/= make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install arm cross compiling tool for clang build # apt-get install binutils-arm-linux-gnueabi # https://github.com/0day-ci/linux/commit/bf0e33a8c3deb700b95173a37= dd16754341ba70e git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review cgel-zte-gmail-com/net-switchdev-u= se-struct_size-over-open-coded-arithmetic/20220128-155848 git checkout bf0e33a8c3deb700b95173a37dd16754341ba70e # save the config file to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=3D$HOME/0day COMPILER=3Dclang make.cross W=3D= 1 O=3Dbuild_dir ARCH=3Darm SHELL=3D/bin/bash If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All errors (new ones prefixed by >>): >> net/switchdev/switchdev.c:88:19: error: member reference type 'struct sw= itchdev_deferred_item' is not a pointer; did you mean to use '.'? dfitem =3D kmalloc(struct_size(*dfitem, data, data_len), GFP_ATO= MIC); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/overflow.h:194:18: note: expanded from macro 'struct_size' sizeof(*(p)->member) + __must_be_array((p)->member),\ ~~~^ >> net/switchdev/switchdev.c:88:19: error: indirection requires pointer ope= rand ('unsigned long[]' invalid) dfitem =3D kmalloc(struct_size(*dfitem, data, data_len), GFP_ATO= MIC); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/overflow.h:194:14: note: expanded from macro 'struct_size' sizeof(*(p)->member) + __must_be_array((p)->member),\ ^~~~~~~~~~~~ >> net/switchdev/switchdev.c:88:19: error: member reference type 'struct sw= itchdev_deferred_item' is not a pointer; did you mean to use '.'? dfitem =3D kmalloc(struct_size(*dfitem, data, data_len), GFP_ATO= MIC); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/overflow.h:194:49: note: expanded from macro 'struct_size' sizeof(*(p)->member) + __must_be_array((p)->member),\ ~~~~~~~~~~~~~~~~~~~^~~~~~~~~ include/linux/compiler.h:258:59: note: expanded from macro '__must_be_ar= ray' #define __must_be_array(a) BUILD_BUG_ON_ZERO(__same_type((a), &(a)[= 0])) ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~= ~~~~ include/linux/compiler_types.h:287:63: note: expanded from macro '__same= _type' #define __same_type(a, b) __builtin_types_compatible_p(typeof(a), typeof= (b)) ^ include/linux/build_bug.h:16:62: note: expanded from macro 'BUILD_BUG_ON= _ZERO' #define BUILD_BUG_ON_ZERO(e) ((int)(sizeof(struct { int:(-!!(e)); }))) ^ >> net/switchdev/switchdev.c:88:19: error: member reference type 'struct sw= itchdev_deferred_item' is not a pointer; did you mean to use '.'? dfitem =3D kmalloc(struct_size(*dfitem, data, data_len), GFP_ATO= MIC); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/overflow.h:194:49: note: expanded from macro 'struct_size' sizeof(*(p)->member) + __must_be_array((p)->member),\ ~~~~~~~~~~~~~~~~~~~^~~~~~~~~ include/linux/compiler.h:258:65: note: expanded from macro '__must_be_ar= ray' #define __must_be_array(a) BUILD_BUG_ON_ZERO(__same_type((a), &(a)[= 0])) ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~= ~~~~ include/linux/compiler_types.h:287:74: note: expanded from macro '__same= _type' #define __same_type(a, b) __builtin_types_compatible_p(typeof(a), typeof= (b)) = ^ include/linux/build_bug.h:16:62: note: expanded from macro 'BUILD_BUG_ON= _ZERO' #define BUILD_BUG_ON_ZERO(e) ((int)(sizeof(struct { int:(-!!(e)); }))) ^ >> net/switchdev/switchdev.c:88:19: error: indirection requires pointer ope= rand ('struct switchdev_deferred_item' invalid) dfitem =3D kmalloc(struct_size(*dfitem, data, data_len), GFP_ATO= MIC); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/overflow.h:195:14: note: expanded from macro 'struct_size' sizeof(*(p))) ^~~~ 5 errors generated. vim +88 net/switchdev/switchdev.c 81 = 82 static int switchdev_deferred_enqueue(struct net_device *dev, 83 const void *data, size_t data_len, 84 switchdev_deferred_func_t *func) 85 { 86 struct switchdev_deferred_item *dfitem; 87 = > 88 dfitem =3D kmalloc(struct_size(*dfitem, data, data_len), GFP_ATOMIC= ); 89 if (!dfitem) 90 return -ENOMEM; 91 dfitem->dev =3D dev; 92 dfitem->func =3D func; 93 memcpy(dfitem->data, data, data_len); 94 dev_hold_track(dev, &dfitem->dev_tracker, GFP_ATOMIC); 95 spin_lock_bh(&deferred_lock); 96 list_add_tail(&dfitem->list, &deferred); 97 spin_unlock_bh(&deferred_lock); 98 schedule_work(&deferred_process_work); 99 return 0; 100 } 101 = --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org --===============0832333539332021809==--