Content-Type: multipart/mixed; boundary="===============4092913394314008400==" MIME-Version: 1.0 From: kernel test robot To: kbuild-all@lists.01.org Subject: Re: [PATCH] net/switchdev: use struct_size over open coded arithmetic Date: Sat, 29 Jan 2022 01:06:21 +0800 Message-ID: <202201290005.GR1IxnQb-lkp@intel.com> In-Reply-To: <20220128075729.1211352-1-chi.minghao@zte.com.cn> List-Id: --===============4092913394314008400== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Hi, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v5.17-rc1 next-20220128] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/cgel-zte-gmail-com/net-swi= tchdev-use-struct_size-over-open-coded-arithmetic/20220128-155848 base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git = 23a46422c56144939c091c76cf389aa863ce9c18 config: i386-randconfig-a005 (https://download.01.org/0day-ci/archive/20220= 129/202201290005.GR1IxnQb-lkp(a)intel.com/config) compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 reproduce (this is a W=3D1 build): # https://github.com/0day-ci/linux/commit/bf0e33a8c3deb700b95173a37= dd16754341ba70e git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review cgel-zte-gmail-com/net-switchdev-u= se-struct_size-over-open-coded-arithmetic/20220128-155848 git checkout bf0e33a8c3deb700b95173a37dd16754341ba70e # save the config file to linux build tree mkdir build_dir make W=3D1 O=3Dbuild_dir ARCH=3Di386 SHELL=3D/bin/bash net/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All errors (new ones prefixed by >>): In file included from include/linux/mm.h:30, from arch/x86/include/asm/cacheflush.h:5, from include/linux/cacheflush.h:5, from include/linux/highmem.h:8, from include/linux/bvec.h:10, from include/linux/skbuff.h:17, from include/net/net_namespace.h:40, from include/linux/netdevice.h:37, from net/switchdev/switchdev.c:13: net/switchdev/switchdev.c: In function 'switchdev_deferred_enqueue': >> include/linux/overflow.h:194:18: error: invalid type argument of '->' (h= ave 'struct switchdev_deferred_item') 194 | sizeof(*(p)->member) + __must_be_array((p)->member),\ | ^~ net/switchdev/switchdev.c:88:19: note: in expansion of macro 'struct_siz= e' 88 | dfitem =3D kmalloc(struct_size(*dfitem, data, data_len), GFP_AT= OMIC); | ^~~~~~~~~~~ In file included from include/linux/container_of.h:5, from include/linux/kernel.h:21, from net/switchdev/switchdev.c:8: include/linux/overflow.h:194:49: error: invalid type argument of '->' (h= ave 'struct switchdev_deferred_item') 194 | sizeof(*(p)->member) + __must_be_array((p)->member),\ | ^~ include/linux/build_bug.h:16:62: note: in definition of macro 'BUILD_BUG= _ON_ZERO' 16 | #define BUILD_BUG_ON_ZERO(e) ((int)(sizeof(struct { int:(-!!(e))= ; }))) | ^ include/linux/compiler.h:258:46: note: in expansion of macro '__same_typ= e' 258 | #define __must_be_array(a) BUILD_BUG_ON_ZERO(__same_type((a), &(= a)[0])) | ^~~~~~~~~~~ include/linux/overflow.h:194:30: note: in expansion of macro '__must_be_= array' 194 | sizeof(*(p)->member) + __must_be_array((p)->member),\ | ^~~~~~~~~~~~~~~ net/switchdev/switchdev.c:88:19: note: in expansion of macro 'struct_siz= e' 88 | dfitem =3D kmalloc(struct_size(*dfitem, data, data_len), GFP_AT= OMIC); | ^~~~~~~~~~~ include/linux/overflow.h:194:49: error: invalid type argument of '->' (h= ave 'struct switchdev_deferred_item') 194 | sizeof(*(p)->member) + __must_be_array((p)->member),\ | ^~ include/linux/build_bug.h:16:62: note: in definition of macro 'BUILD_BUG= _ON_ZERO' 16 | #define BUILD_BUG_ON_ZERO(e) ((int)(sizeof(struct { int:(-!!(e))= ; }))) | ^ include/linux/compiler.h:258:46: note: in expansion of macro '__same_typ= e' 258 | #define __must_be_array(a) BUILD_BUG_ON_ZERO(__same_type((a), &(= a)[0])) | ^~~~~~~~~~~ include/linux/overflow.h:194:30: note: in expansion of macro '__must_be_= array' 194 | sizeof(*(p)->member) + __must_be_array((p)->member),\ | ^~~~~~~~~~~~~~~ net/switchdev/switchdev.c:88:19: note: in expansion of macro 'struct_siz= e' 88 | dfitem =3D kmalloc(struct_size(*dfitem, data, data_len), GFP_AT= OMIC); | ^~~~~~~~~~~ include/linux/build_bug.h:16:51: error: bit-field '' width no= t an integer constant 16 | #define BUILD_BUG_ON_ZERO(e) ((int)(sizeof(struct { int:(-!!(e))= ; }))) | ^ include/linux/compiler.h:258:28: note: in expansion of macro 'BUILD_BUG_= ON_ZERO' 258 | #define __must_be_array(a) BUILD_BUG_ON_ZERO(__same_type((a), &(= a)[0])) | ^~~~~~~~~~~~~~~~~ include/linux/overflow.h:194:30: note: in expansion of macro '__must_be_= array' 194 | sizeof(*(p)->member) + __must_be_array((p)->member),\ | ^~~~~~~~~~~~~~~ net/switchdev/switchdev.c:88:19: note: in expansion of macro 'struct_siz= e' 88 | dfitem =3D kmalloc(struct_size(*dfitem, data, data_len), GFP_AT= OMIC); | ^~~~~~~~~~~ In file included from include/linux/mm.h:30, from arch/x86/include/asm/cacheflush.h:5, from include/linux/cacheflush.h:5, from include/linux/highmem.h:8, from include/linux/bvec.h:10, from include/linux/skbuff.h:17, from include/net/net_namespace.h:40, from include/linux/netdevice.h:37, from net/switchdev/switchdev.c:13: >> include/linux/overflow.h:195:14: error: invalid type argument of unary '= *' (have 'struct switchdev_deferred_item') 195 | sizeof(*(p))) | ^~~~ net/switchdev/switchdev.c:88:19: note: in expansion of macro 'struct_siz= e' 88 | dfitem =3D kmalloc(struct_size(*dfitem, data, data_len), GFP_AT= OMIC); | ^~~~~~~~~~~ vim +194 include/linux/overflow.h 610b15c50e86eb Kees Cook 2018-05-07 180 = 610b15c50e86eb Kees Cook 2018-05-07 181 /** 610b15c50e86eb Kees Cook 2018-05-07 182 * struct_size() - Calc= ulate size of structure with trailing array. 610b15c50e86eb Kees Cook 2018-05-07 183 * @p: Pointer to the s= tructure. 610b15c50e86eb Kees Cook 2018-05-07 184 * @member: Name of the= array member. b19d57d0f3cc6f Gustavo A. R. Silva 2020-06-08 185 * @count: Number of el= ements in the array. 610b15c50e86eb Kees Cook 2018-05-07 186 * 610b15c50e86eb Kees Cook 2018-05-07 187 * Calculates size of m= emory needed for structure @p followed by an b19d57d0f3cc6f Gustavo A. R. Silva 2020-06-08 188 * array of @count numb= er of @member elements. 610b15c50e86eb Kees Cook 2018-05-07 189 * 610b15c50e86eb Kees Cook 2018-05-07 190 * Return: number of by= tes needed or SIZE_MAX on overflow. 610b15c50e86eb Kees Cook 2018-05-07 191 */ b19d57d0f3cc6f Gustavo A. R. Silva 2020-06-08 192 #define struct_size(p, = member, count) \ b19d57d0f3cc6f Gustavo A. R. Silva 2020-06-08 193 __ab_c_size(count, = \ 610b15c50e86eb Kees Cook 2018-05-07 @194 sizeof(*(p)->memb= er) + __must_be_array((p)->member),\ 610b15c50e86eb Kees Cook 2018-05-07 @195 sizeof(*(p))) 610b15c50e86eb Kees Cook 2018-05-07 196 = --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org --===============4092913394314008400==--