Content-Type: multipart/mixed; boundary="===============6901120080597198779==" MIME-Version: 1.0 From: kernel test robot To: kbuild-all@lists.01.org Subject: Re: [PATCH v4 2/4] Watchdog: sp5100_tco: Refactor MMIO base address initialization Date: Mon, 31 Jan 2022 11:13:29 +0800 Message-ID: <202201311102.xyggUF8Z-lkp@intel.com> In-Reply-To: <20220130191225.303115-3-terry.bowman@amd.com> List-Id: --===============6901120080597198779== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Hi Terry, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on groeck-staging/hwmon-next] [also build test WARNING on linux/master linus/master v5.17-rc2 next-202201= 28] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Terry-Bowman/Watchdog-sp51= 00_tco-Replace-cd6h-cd7h-port-I-O-accesses-with-MMIO-accesses/20220131-0315= 25 base: https://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-stagin= g.git hwmon-next config: x86_64-randconfig-a013-20220131 (https://download.01.org/0day-ci/ar= chive/20220131/202201311102.xyggUF8Z-lkp(a)intel.com/config) compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project f1c18a= cb07aa40f42b87b70462a6d1ab77a4825c) reproduce (this is a W=3D1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/= make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/e6855f66e7e915cd09a8f8dae= 411997df8a7c641 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Terry-Bowman/Watchdog-sp5100_tco-R= eplace-cd6h-cd7h-port-I-O-accesses-with-MMIO-accesses/20220131-031525 git checkout e6855f66e7e915cd09a8f8dae411997df8a7c641 # save the config file to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=3D$HOME/0day COMPILER=3Dclang make.cross W=3D= 1 O=3Dbuild_dir ARCH=3Dx86_64 SHELL=3D/bin/bash drivers/watchdog/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All warnings (new ones prefixed by >>): >> drivers/watchdog/sp5100_tco.c:270:60: warning: format specifies type 'un= signed int' but the argument has type 'void *' [-Wformat] dev_info(dev, "Using 0x%08x for watchdog MMIO address\n", tco->t= cobase); ~~~~ ^~~~~~= ~~~~~~ include/linux/dev_printk.h:150:67: note: expanded from macro 'dev_info' dev_printk_index_wrap(_dev_info, KERN_INFO, dev, dev_fmt(fmt), #= #__VA_ARGS__) ~~~ = ^~~~~~~~~~~ include/linux/dev_printk.h:110:23: note: expanded from macro 'dev_printk= _index_wrap' _p_func(dev, fmt, ##__VA_ARGS__); \ ~~~ ^~~~~~~~~~~ 1 warning generated. vim +270 drivers/watchdog/sp5100_tco.c 238 = 239 static u32 sp5100_tco_prepare_base(struct sp5100_tco *tco, 240 u32 mmio_addr, 241 u32 alt_mmio_addr, 242 const char *dev_name) 243 { 244 struct device *dev =3D tco->wdd.parent; 245 = 246 dev_dbg(dev, "Got 0x%08x from SBResource_MMIO register\n", mmio_add= r); 247 = 248 if (!mmio_addr && !alt_mmio_addr) 249 return -ENODEV; 250 = 251 /* Check for MMIO address and alternate MMIO address conflicts */ 252 if (mmio_addr) 253 mmio_addr =3D sp5100_tco_request_region(dev, mmio_addr, dev_name); 254 = 255 if (!mmio_addr && alt_mmio_addr) 256 mmio_addr =3D sp5100_tco_request_region(dev, alt_mmio_addr, dev_na= me); 257 = 258 if (!mmio_addr) { 259 dev_err(dev, "Failed to reserve MMIO or alternate MMIO region\n"); 260 return -EBUSY; 261 } 262 = 263 tco->tcobase =3D devm_ioremap(dev, mmio_addr, SP5100_WDT_MEM_MAP_SI= ZE); 264 if (!tco->tcobase) { 265 dev_err(dev, "MMIO address 0x%08x failed mapping\n", mmio_addr); 266 devm_release_mem_region(dev, mmio_addr, SP5100_WDT_MEM_MAP_SIZE); 267 return -ENOMEM; 268 } 269 = > 270 dev_info(dev, "Using 0x%08x for watchdog MMIO address\n", tco->tcob= ase); 271 = 272 return 0; 273 } 274 = --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org --===============6901120080597198779==--