Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4873C433F5 for ; Mon, 31 Jan 2022 13:36:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1F5516B0092; Mon, 31 Jan 2022 08:36:16 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 189B46B0093; Mon, 31 Jan 2022 08:36:16 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 06C7F6B0095; Mon, 31 Jan 2022 08:36:16 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0090.hostedemail.com [216.40.44.90]) by kanga.kvack.org (Postfix) with ESMTP id E7A5E6B0092 for ; Mon, 31 Jan 2022 08:36:15 -0500 (EST) Received: from smtpin27.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id AA029824C420 for ; Mon, 31 Jan 2022 13:36:15 +0000 (UTC) X-FDA: 79090681110.27.4AAA56D Received: from mail-qt1-f180.google.com (mail-qt1-f180.google.com [209.85.160.180]) by imf31.hostedemail.com (Postfix) with ESMTP id B6FFD20005 for ; Mon, 31 Jan 2022 13:36:14 +0000 (UTC) Received: by mail-qt1-f180.google.com with SMTP id h8so5353446qtk.13 for ; Mon, 31 Jan 2022 05:36:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=PEer8tHTGOMBB45BNBliWIb1NwPck3iboeLwpq12AUQ=; b=GAZFseV/rySaS1H2s/o7SLuHE6htq36AAAz2Gg5dLp+rLpPCZJ8owShGHKizWzYrfK lj4d2iowhMaamMT6sMCIyVDaAvAYhVAOwKj9VoTMWDbf7fYPRcekJyVouJgxocp4hSyN ASGbJDEm6ZyQgGb7g1OiLCdKOXrscvCkhaLtDsLYVCdER06z5XbrCJYLJ7/C1Tcadi6j lSI4ACyvSzq0dpW/CdWeg4yMIDOE6QdCcEfHuYZWS4U58Ig3Dr3IKuEWAHiSyBa20eRD j93VpppgeW+YfpZxFPoyFc141sSMloI9rS+8prqata9kfhkNfBWkZf3xkKNuFX2rJYNL cvmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=PEer8tHTGOMBB45BNBliWIb1NwPck3iboeLwpq12AUQ=; b=vcKRTk8T4lzMQVPWdE44nN/Wx/aeJd/AqCIA1zl3nm+/ufE9wiYzaecNSBxgPfhS5w 0joOGBGzrYRlKTl6spoDx8d+53V9MyfRHrCNWsdso8deFQrt4eR2S6BW/haiT7mrs6+r 2wax2htJifmyGQOtofW9POMLpzYU32eeIUBrM6w5uTkyedXxcOTac21w9iowWT88Oi7k So7rbkol2JqJoboMJQxfAuw0vZZNkZsK82cizDyQ9Nssq7EOME+XY5MIgAhh+FN3QC0R wQf2hfVWMgeFSNdQNSE01rVLbUIT638s7nkU1l6YR4doY2zuNEBM8Uq9dojWGw1iLlVx qYig== X-Gm-Message-State: AOAM531RsuYqTxP4QM7mO0VaOQNC4prxFjYbVltoBF1BLdP9/QbYCObh tzBX3eMm3xzECnfwArD3zTqlFw== X-Google-Smtp-Source: ABdhPJwF3X98hpIKB/fiNvdtbcy0R31qGPlzKjuu4Xpol+RF/9z+GewqMbOrv/sUSLPFKbaWj56Kxw== X-Received: by 2002:a05:622a:13ca:: with SMTP id p10mr14925312qtk.294.1643636173870; Mon, 31 Jan 2022 05:36:13 -0800 (PST) Received: from ziepe.ca (hlfxns017vw-142-162-113-129.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.162.113.129]) by smtp.gmail.com with ESMTPSA id 22sm8132398qtw.75.2022.01.31.05.36.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 31 Jan 2022 05:36:13 -0800 (PST) Received: from jgg by mlx with local (Exim 4.94) (envelope-from ) id 1nEWqq-009WAO-6O; Mon, 31 Jan 2022 09:36:12 -0400 Date: Mon, 31 Jan 2022 09:36:12 -0400 From: Jason Gunthorpe To: John Hubbard Cc: Andrew Morton , Peter Xu , Jan Kara , Claudio Imbrenda , "Kirill A . Shutemov" , Alex Williamson , Andrea Arcangeli , =?utf-8?B?SsOpcsO0bWU=?= Glisse , LKML , linux-mm@kvack.org Subject: Re: [PATCH 4/4] mm/gup: remove get_user_pages_locked() Message-ID: <20220131133612.GW8034@ziepe.ca> References: <20220131051752.447699-1-jhubbard@nvidia.com> <20220131051752.447699-5-jhubbard@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220131051752.447699-5-jhubbard@nvidia.com> Authentication-Results: imf31.hostedemail.com; dkim=pass header.d=ziepe.ca header.s=google header.b="GAZFseV/"; spf=pass (imf31.hostedemail.com: domain of jgg@ziepe.ca designates 209.85.160.180 as permitted sender) smtp.mailfrom=jgg@ziepe.ca; dmarc=none X-Rspam-User: nil X-Rspamd-Queue-Id: B6FFD20005 X-Stat-Signature: fnqj7c7g35baxghkcjiniecb83yc7zid X-Rspamd-Server: rspam12 X-HE-Tag: 1643636174-973154 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Jan 30, 2022 at 09:17:52PM -0800, John Hubbard wrote: > diff --git a/mm/mempolicy.c b/mm/mempolicy.c > index 028e8dd82b44..040d88354cfa 100644 > +++ b/mm/mempolicy.c > @@ -907,17 +907,15 @@ static void get_policy_nodemask(struct mempolicy *p, nodemask_t *nodes) > static int lookup_node(struct mm_struct *mm, unsigned long addr) > { > struct page *p = NULL; > - int err; > + int ret; > > - int locked = 1; > - err = get_user_pages_locked(addr & PAGE_MASK, 1, 0, &p, &locked); > - if (err > 0) { > - err = page_to_nid(p); > + mmap_assert_locked(mm); > + ret = get_user_pages(addr & PAGE_MASK, 1, 0, &p, NULL); > + if (ret > 0) { > + ret = page_to_nid(p); > put_page(p); > } > - if (locked) > - mmap_read_unlock(mm); > - return err; > + return ret; > } > > /* Retrieve NUMA policy */ > @@ -968,15 +966,15 @@ static long do_get_mempolicy(int *policy, nodemask_t *nmask, > if (flags & MPOL_F_NODE) { > if (flags & MPOL_F_ADDR) { > /* > - * Take a refcount on the mpol, lookup_node() > - * will drop the mmap_lock, so after calling > - * lookup_node() only "pol" remains valid, "vma" > - * is stale. > + * Take a refcount on the mpol, because we are about to > + * drop the mmap_lock, after which only "pol" remains > + * valid, "vma" is stale. > */ > pol_refcount = pol; > vma = NULL; > mpol_get(pol); > err = lookup_node(mm, addr); > + mmap_read_unlock(mm); How about move the mmap_read_unlock up one line and then use get_user_pages_fast() I'm guessing in most cases here the PTE will be present so that should be a net win? Jason