Content-Type: multipart/mixed; boundary="===============7512311640386217897==" MIME-Version: 1.0 From: kernel test robot To: kbuild-all@lists.01.org Subject: Re: [PATCH] memcg: add per-memcg total kernel memory stat Date: Wed, 02 Feb 2022 08:47:14 +0800 Message-ID: <202202020822.IjosSkm5-lkp@intel.com> In-Reply-To: <20220201200823.3283171-1-yosryahmed@google.com> List-Id: --===============7512311640386217897== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Hi Yosry, Thank you for the patch! Yet something to improve: [auto build test ERROR on linux/master] [also build test ERROR on linus/master v5.17-rc2 next-20220201] [cannot apply to tj-cgroup/for-next hnaz-mm/master] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Yosry-Ahmed/memcg-add-per-= memcg-total-kernel-memory-stat/20220202-041007 base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git = 2c271fe77d52a0555161926c232cd5bc07178b39 config: x86_64-randconfig-a006-20220131 (https://download.01.org/0day-ci/ar= chive/20220202/202202020822.IjosSkm5-lkp(a)intel.com/config) compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 reproduce (this is a W=3D1 build): # https://github.com/0day-ci/linux/commit/c956773fbdc99f19a2f194275= 95473fd591ccdc3 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Yosry-Ahmed/memcg-add-per-memcg-to= tal-kernel-memory-stat/20220202-041007 git checkout c956773fbdc99f19a2f19427595473fd591ccdc3 # save the config file to linux build tree mkdir build_dir make W=3D1 O=3Dbuild_dir ARCH=3Dx86_64 SHELL=3D/bin/bash If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All errors (new ones prefixed by >>): mm/memcontrol.c: In function 'uncharge_batch': >> mm/memcontrol.c:6817:4: error: implicit declaration of function 'mem_cgr= oup_kmem_record'; did you mean 'mem_cgroup_id_remove'? [-Werror=3Dimplicit-= function-declaration] 6817 | mem_cgroup_kmem_record(ug->memcg, -ug->nr_kmem); | ^~~~~~~~~~~~~~~~~~~~~~ | mem_cgroup_id_remove cc1: some warnings being treated as errors vim +6817 mm/memcontrol.c 6807 = 6808 static void uncharge_batch(const struct uncharge_gather *ug) 6809 { 6810 unsigned long flags; 6811 = 6812 if (ug->nr_memory) { 6813 page_counter_uncharge(&ug->memcg->memory, ug->nr_memory); 6814 if (do_memsw_account()) 6815 page_counter_uncharge(&ug->memcg->memsw, ug->nr_memory); 6816 if (ug->nr_kmem) > 6817 mem_cgroup_kmem_record(ug->memcg, -ug->nr_kmem); 6818 memcg_oom_recover(ug->memcg); 6819 } 6820 = 6821 local_irq_save(flags); 6822 __count_memcg_events(ug->memcg, PGPGOUT, ug->pgpgout); 6823 __this_cpu_add(ug->memcg->vmstats_percpu->nr_page_events, ug->nr_me= mory); 6824 memcg_check_events(ug->memcg, ug->nid); 6825 local_irq_restore(flags); 6826 = 6827 /* drop reference from uncharge_folio */ 6828 css_put(&ug->memcg->css); 6829 } 6830 = --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org --===============7512311640386217897==--