Date: Wed, 2 Feb 2022 14:39:10 +0100 (CET) Message-Id: <202202021339.212DdAQh030711@...2054...> From: Gert Doering In-Reply-To: <20220101162532.2251835-5-arne@...1227...> References: <20220101162532.2251835-5-arne@...1227...> Subject: [Openvpn-devel] [PATCH applied] Re: Fix datagram_overhead and assorted functions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: Arne Schwabe Cc: openvpn-devel@lists.sourceforge.net Acked-by: Gert Doering For reference, this was 12/21 in the first patch series, and got an ACK from Frank Lichtenheld there. Stared at the code. Looks bigger than it really is :-) - what it really does is pass on the socket address family down the call chain to the "datagram_overhead()" function, which will then know if it's v4 or v6. Should we ever support SCTP, we'll only have to adjust a single function here, no mixture of functions and tables... :-) Tested client and server side. P2P NCP is still broken (waiting for 13/14), Rest works. Your patch has been applied to the master branch. commit a63a727b020ef42c475bd861b960200686359b2d Author: Arne Schwabe Date: Sat Jan 1 17:25:22 2022 +0100 Fix datagram_overhead and assorted functions Signed-off-by: Arne Schwabe Acked-by: Frank Lichtenheld Acked-by: Gert Doering Message-Id: <20220101162532.2251835-5-arne@...1227...> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg23504.html Signed-off-by: Gert Doering -- kind regards, Gert Doering