Content-Type: multipart/mixed; boundary="===============0728203044751941108==" MIME-Version: 1.0 From: kernel test robot To: kbuild-all@lists.01.org Subject: Re: [PATCH v1 1/1] iio: frequency: adf4350: Make use of device properties Date: Thu, 03 Feb 2022 14:55:24 +0800 Message-ID: <202202031457.yUDGy1we-lkp@intel.com> In-Reply-To: <20220202202936.56475-1-andriy.shevchenko@linux.intel.com> List-Id: --===============0728203044751941108== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Hi Andy, I love your patch! Yet something to improve: [auto build test ERROR on jic23-iio/togreg] [also build test ERROR on v5.17-rc2 next-20220203] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Andy-Shevchenko/iio-freque= ncy-adf4350-Make-use-of-device-properties/20220203-042942 base: https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git togreg config: arm64-randconfig-r031-20220130 (https://download.01.org/0day-ci/arc= hive/20220203/202202031457.yUDGy1we-lkp(a)intel.com/config) compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project a73e4c= e6a59b01f0e37037761c1e6889d539d233) reproduce (this is a W=3D1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/= make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install arm64 cross compiling tool for clang build # apt-get install binutils-aarch64-linux-gnu # https://github.com/0day-ci/linux/commit/45963437d849912f2763fe06c= 25f9e30c383b0f5 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Andy-Shevchenko/iio-frequency-adf4= 350-Make-use-of-device-properties/20220203-042942 git checkout 45963437d849912f2763fe06c25f9e30c383b0f5 # save the config file to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=3D$HOME/0day COMPILER=3Dclang make.cross W=3D= 1 O=3Dbuild_dir ARCH=3Darm64 SHELL=3D/bin/bash drivers/iio/frequency/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All errors (new ones prefixed by >>): >> drivers/iio/frequency/adf4350.c:413:6: error: implicit declaration of fu= nction 'deivice_property_read_bool' [-Werror,-Wimplicit-function-declaratio= n] if (deivice_property_read_bool(dev, "adi,phase-detector-polarity= -positive-enable")) ^ drivers/iio/frequency/adf4350.c:413:6: note: did you mean 'device_proper= ty_read_bool'? include/linux/property.h:129:20: note: 'device_property_read_bool' decla= red here static inline bool device_property_read_bool(struct device *dev, ^ 1 error generated. vim +/deivice_property_read_bool +413 drivers/iio/frequency/adf4350.c 384 = 385 static struct adf4350_platform_data *adf4350_parse_dt(struct device = *dev) 386 { 387 struct adf4350_platform_data *pdata; 388 unsigned int tmp; 389 = 390 pdata =3D devm_kzalloc(dev, sizeof(*pdata), GFP_KERNEL); 391 if (!pdata) 392 return NULL; 393 = 394 snprintf(pdata->name, sizeof(pdata->name), "%pfw", dev_fwnode(dev)); 395 = 396 tmp =3D 10000; 397 device_property_read_u32(dev, "adi,channel-spacing", &tmp); 398 pdata->channel_spacing =3D tmp; 399 = 400 tmp =3D 0; 401 device_property_read_u32(dev, "adi,power-up-frequency", &tmp); 402 pdata->power_up_frequency =3D tmp; 403 = 404 tmp =3D 0; 405 device_property_read_u32(dev, "adi,reference-div-factor", &tmp); 406 pdata->ref_div_factor =3D tmp; 407 = 408 pdata->ref_doubler_en =3D device_property_read_bool(dev, "adi,refer= ence-doubler-enable"); 409 pdata->ref_div2_en =3D device_property_read_bool(dev, "adi,referenc= e-div2-enable"); 410 = 411 /* r2_user_settings */ 412 pdata->r2_user_settings =3D 0; > 413 if (deivice_property_read_bool(dev, "adi,phase-detector-polarity-po= sitive-enable")) 414 pdata->r2_user_settings |=3D ADF4350_REG2_PD_POLARITY_POS; 415 if (device_property_read_bool(dev, "adi,lock-detect-precision-6ns-e= nable")) 416 pdata->r2_user_settings |=3D ADF4350_REG2_LDP_6ns; 417 if (device_property_read_bool(dev, "adi,lock-detect-function-intege= r-n-enable")) 418 pdata->r2_user_settings |=3D ADF4350_REG2_LDF_INT_N; 419 = 420 tmp =3D 2500; 421 device_property_read_u32(dev, "adi,charge-pump-current", &tmp); 422 pdata->r2_user_settings |=3D ADF4350_REG2_CHARGE_PUMP_CURR_uA(tmp); 423 = 424 tmp =3D 0; 425 device_property_read_u32(dev, "adi,muxout-select", &tmp); 426 pdata->r2_user_settings |=3D ADF4350_REG2_MUXOUT(tmp); 427 = 428 if (device_property_read_bool(dev, "adi,low-spur-mode-enable")) 429 pdata->r2_user_settings |=3D ADF4350_REG2_NOISE_MODE(0x3); 430 = 431 /* r3_user_settings */ 432 = 433 pdata->r3_user_settings =3D 0; 434 if (device_property_read_bool(dev, "adi,cycle-slip-reduction-enable= ")) 435 pdata->r3_user_settings |=3D ADF4350_REG3_12BIT_CSR_EN; 436 if (device_property_read_bool(dev, "adi,charge-cancellation-enable"= )) 437 pdata->r3_user_settings |=3D ADF4351_REG3_CHARGE_CANCELLATION_EN; 438 if (device_property_read_bool(dev, "adi,anti-backlash-3ns-enable")) 439 pdata->r3_user_settings |=3D ADF4351_REG3_ANTI_BACKLASH_3ns_EN; 440 if (device_property_read_bool(dev, "adi,band-select-clock-mode-high= -enable")) 441 pdata->r3_user_settings |=3D ADF4351_REG3_BAND_SEL_CLOCK_MODE_HIGH; 442 = 443 tmp =3D 0; 444 device_property_read_u32(dev, "adi,12bit-clk-divider", &tmp); 445 pdata->r3_user_settings |=3D ADF4350_REG3_12BIT_CLKDIV(tmp); 446 = 447 tmp =3D 0; 448 device_property_read_u32(dev, "adi,clk-divider-mode", &tmp); 449 pdata->r3_user_settings |=3D ADF4350_REG3_12BIT_CLKDIV_MODE(tmp); 450 = 451 /* r4_user_settings */ 452 = 453 pdata->r4_user_settings =3D 0; 454 if (device_property_read_bool(dev, "adi,aux-output-enable")) 455 pdata->r4_user_settings |=3D ADF4350_REG4_AUX_OUTPUT_EN; 456 if (device_property_read_bool(dev, "adi,aux-output-fundamental-enab= le")) 457 pdata->r4_user_settings |=3D ADF4350_REG4_AUX_OUTPUT_FUND; 458 if (device_property_read_bool(dev, "adi,mute-till-lock-enable")) 459 pdata->r4_user_settings |=3D ADF4350_REG4_MUTE_TILL_LOCK_EN; 460 = 461 tmp =3D 0; 462 device_property_read_u32(dev, "adi,output-power", &tmp); 463 pdata->r4_user_settings |=3D ADF4350_REG4_OUTPUT_PWR(tmp); 464 = 465 tmp =3D 0; 466 device_property_read_u32(dev, "adi,aux-output-power", &tmp); 467 pdata->r4_user_settings |=3D ADF4350_REG4_AUX_OUTPUT_PWR(tmp); 468 = 469 return pdata; 470 } 471 = --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org --===============0728203044751941108==--