Content-Type: multipart/mixed; boundary="===============0993971403491150687==" MIME-Version: 1.0 From: kernel test robot To: kbuild-all@lists.01.org Subject: Re: [PATCH] mm/damon: Add option to monitor only writes Date: Fri, 04 Feb 2022 09:29:58 +0800 Message-ID: <202202040414.4fF2j3mp-lkp@intel.com> In-Reply-To: <20220203131237.298090-1-pedrodemargomes@gmail.com> List-Id: --===============0993971403491150687== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Hi Pedro, Thank you for the patch! Yet something to improve: [auto build test ERROR on hnaz-mm/master] url: https://github.com/0day-ci/linux/commits/Pedro-Demarchi-Gomes/mm-da= mon-Add-option-to-monitor-only-writes/20220203-211407 base: https://github.com/hnaz/linux-mm master config: hexagon-randconfig-r041-20220130 (https://download.01.org/0day-ci/a= rchive/20220204/202202040414.4fF2j3mp-lkp(a)intel.com/config) compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project a73e4c= e6a59b01f0e37037761c1e6889d539d233) reproduce (this is a W=3D1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/= make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/0958bb7e2514b62f174b8e5cc= fdcff07ce2a2b6b git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Pedro-Demarchi-Gomes/mm-damon-Add-= option-to-monitor-only-writes/20220203-211407 git checkout 0958bb7e2514b62f174b8e5ccfdcff07ce2a2b6b # save the config file to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=3D$HOME/0day COMPILER=3Dclang make.cross W=3D= 1 O=3Dbuild_dir ARCH=3Dhexagon SHELL=3D/bin/bash If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All errors (new ones prefixed by >>): >> mm/damon/prmtv-common.c:87:7: error: implicit declaration of function 'p= md_dirty' [-Werror,-Wimplicit-function-declaration] if (pmd_dirty(old)) ^ mm/damon/prmtv-common.c:87:7: note: did you mean 'pte_dirty'? arch/hexagon/include/asm/pgtable.h:301:19: note: 'pte_dirty' declared he= re static inline int pte_dirty(pte_t pte) ^ >> mm/damon/prmtv-common.c:88:10: error: implicit declaration of function '= pmd_mkdirty' [-Werror,-Wimplicit-function-declaration] pmd =3D pmd_mkdirty(pmd); ^ >> mm/damon/prmtv-common.c:88:8: error: assigning to 'pmd_t' from incompati= ble type 'int' pmd =3D pmd_mkdirty(pmd); ^ ~~~~~~~~~~~~~~~~ >> mm/damon/prmtv-common.c:89:7: error: implicit declaration of function 'p= md_young' [-Werror,-Wimplicit-function-declaration] if (pmd_young(old)) ^ mm/damon/prmtv-common.c:89:7: note: did you mean 'pte_young'? arch/hexagon/include/asm/pgtable.h:295:19: note: 'pte_young' declared he= re static inline int pte_young(pte_t pte) ^ >> mm/damon/prmtv-common.c:90:10: error: implicit declaration of function '= pmd_mkyoung' [-Werror,-Wimplicit-function-declaration] pmd =3D pmd_mkyoung(pmd); ^ mm/damon/prmtv-common.c:90:8: error: assigning to 'pmd_t' from incompati= ble type 'int' pmd =3D pmd_mkyoung(pmd); ^ ~~~~~~~~~~~~~~~~ >> mm/damon/prmtv-common.c:92:9: error: implicit declaration of function 'p= md_wrprotect' [-Werror,-Wimplicit-function-declaration] pmd =3D pmd_wrprotect(pmd); ^ mm/damon/prmtv-common.c:92:9: note: did you mean 'pte_wrprotect'? arch/hexagon/include/asm/pgtable.h:315:21: note: 'pte_wrprotect' declare= d here static inline pte_t pte_wrprotect(pte_t pte) ^ mm/damon/prmtv-common.c:92:7: error: assigning to 'pmd_t' from incompati= ble type 'int' pmd =3D pmd_wrprotect(pmd); ^ ~~~~~~~~~~~~~~~~~~ >> mm/damon/prmtv-common.c:95:3: error: implicit declaration of function 's= et_pmd_at' [-Werror,-Wimplicit-function-declaration] set_pmd_at(vma->vm_mm, addr, pmdp, pmd); ^ mm/damon/prmtv-common.c:98:3: error: implicit declaration of function 's= et_pmd_at' [-Werror,-Wimplicit-function-declaration] set_pmd_at(vma->vm_mm, addr, pmdp, pmd); ^ 10 errors generated. vim +/pmd_dirty +87 mm/damon/prmtv-common.c 78 = 79 static inline void clear_soft_dirty_pmd(struct vm_area_struct *vma, 80 unsigned long addr, pmd_t *pmdp) 81 { 82 pmd_t old, pmd =3D *pmdp; 83 = 84 if (pmd_present(pmd)) { 85 /* See comment in change_huge_pmd() */ 86 old =3D pmdp_invalidate(vma, addr, pmdp); > 87 if (pmd_dirty(old)) > 88 pmd =3D pmd_mkdirty(pmd); > 89 if (pmd_young(old)) > 90 pmd =3D pmd_mkyoung(pmd); 91 = > 92 pmd =3D pmd_wrprotect(pmd); 93 pmd =3D pmd_clear_soft_dirty(pmd); 94 = > 95 set_pmd_at(vma->vm_mm, addr, pmdp, pmd); 96 } else if (is_migration_entry(pmd_to_swp_entry(pmd))) { 97 pmd =3D pmd_swp_clear_soft_dirty(pmd); 98 set_pmd_at(vma->vm_mm, addr, pmdp, pmd); 99 } 100 } 101 = --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org --===============0993971403491150687==--