Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 62014C433F5 for ; Fri, 4 Feb 2022 08:06:15 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 862F080FF1; Fri, 4 Feb 2022 09:06:13 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=bootlin.com header.i=@bootlin.com header.b="QE1IBrJl"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 504B481F50; Fri, 4 Feb 2022 09:06:12 +0100 (CET) Received: from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::229]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 48A2C8009D for ; Fri, 4 Feb 2022 09:06:09 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=clement.leger@bootlin.com Received: (Authenticated sender: clement.leger@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 754BAFF807; Fri, 4 Feb 2022 08:06:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1643961968; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LHN8B5aQQ6Q4faQlHTbZ3rEeGRA5HED9bbr85rQyDo0=; b=QE1IBrJlEvXVNeSoxAMAm06OPyzdNC/J2CMDMVhcwHGttWHth2eUEtE1DGOqPbd9yz064e lU2jVBoZL4G0lKYzcghIQfCfdvxnjUMXQZIk+KPYqo459AIjelNfUePk9MNsa0jYp0tgoX hEF409HglBPQmWkoL0P1UaFOZ/QkvSx74yBIGJO9Tbj0qPo3SBR7LkLV3ACjlSBnS8+EFF 8sD0/lXt5GFpLvdyQCJQaU2+Hz/mjklVIj6o6Cs+XhGE3FdxFSidJC8X/MNk7OM/1SjI+P O8UE8Iv5FK+D9tWLjb1BiNW7TR+l+ZNo1EQKJEocSxEvpkjqA4AqsxHpF1xwfw== Date: Fri, 4 Feb 2022 09:04:54 +0100 From: =?UTF-8?B?Q2zDqW1lbnQgTMOpZ2Vy?= To: Cc: , , Subject: Re: [PATCH v2 2/3] dts: sama5d2: add TCB node Message-ID: <20220204090454.70865678@fixe.home> In-Reply-To: References: <20220202144301.3871490-1-clement.leger@bootlin.com> <20220202144301.3871490-3-clement.leger@bootlin.com> Organization: Bootlin X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean Le Fri, 4 Feb 2022 07:52:26 +0000, a =C3=A9crit : > Hello Clement, >=20 > Subject should be ARM: dts: [at91:] sama5d2: ... >=20 > On 2/2/22 4:43 PM, Cl=C3=A9ment L=C3=A9ger wrote: > > Add the device-tree node to describe the TCB timer. > >=20 > > Signed-off-by: Cl=C3=A9ment L=C3=A9ger > > --- > > arch/arm/dts/sama5d2.dtsi | 15 +++++++++++++++ > > 1 file changed, 15 insertions(+) > >=20 > > diff --git a/arch/arm/dts/sama5d2.dtsi b/arch/arm/dts/sama5d2.dtsi > > index 038cd73c03..fc6a4fbe4d 100644 > > --- a/arch/arm/dts/sama5d2.dtsi > > +++ b/arch/arm/dts/sama5d2.dtsi > > @@ -700,6 +700,21 @@ > > clocks =3D <&h32ck>; > > }; > >=20 > > + tcb0: timer@f800c000 { > > + compatible =3D "atmel,sama5d2-tcb", "si= mple-mfd"; =20 >=20 > syscon ? Hi Eugen, Yes I might add it if needed but in my case, there is no need for it. >=20 > > + reg =3D <0xf800c000 0x100>; > > + > > + clocks =3D <&tcb0_clk>, <&tcb0_gclk>, <= &clk32k>; > > + clock-names =3D "t0_clk", "gclk", "slow= _clk"; > > + #address-cells =3D <1>; > > + #size-cells =3D <0>; > > + > > + timer0: timer@0 { > > + compatible =3D "atmel,tcb-timer= "; > > + reg =3D <0>, <1>; > > + }; > > + }; > > + =20 >=20 > I am not happy that the original binding has the interrupts as=20 > 'mandatory'. Maybe the binding author did not have more use cases in mind. > Anyway I think that it can go to u-boot without this interrupts property= =20 > as it's surely unused and there is no interrupt controller at the moment= =20 > in the DT. I checked the other nodes and indeed, I did not found any 'interrupts' property so i guess it 'could' be left out... But I can add it for sure. > If nobody has another opinion that is... >=20 > Eugen >=20 > > watchdog@f8048040 { > > compatible =3D "atmel,sama5d4-wdt"; > > reg =3D <0xf8048040 0x10>; > > -- > > 2.34.1 > > =20 >=20 --=20 Cl=C3=A9ment L=C3=A9ger, Embedded Linux and Kernel engineer at Bootlin https://bootlin.com