Content-Type: multipart/mixed; boundary="===============4018969961444623987==" MIME-Version: 1.0 From: kernel test robot To: kbuild-all@lists.01.org Subject: Re: [PATCH v7 10/17] KVM: s390: pv: add mmu_notifier Date: Sat, 05 Feb 2022 05:22:47 +0800 Message-ID: <202202050519.HMLLILGz-lkp@intel.com> In-Reply-To: <20220204155349.63238-11-imbrenda@linux.ibm.com> List-Id: --===============4018969961444623987== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Hi Claudio, I love your patch! Yet something to improve: [auto build test ERROR on kvm/queue] [also build test ERROR on v5.17-rc2 next-20220204] [cannot apply to kvms390/next s390/features] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Claudio-Imbrenda/KVM-s390-= pv-implement-lazy-destroy-for-reboot/20220204-235609 base: https://git.kernel.org/pub/scm/virt/kvm/kvm.git queue config: s390-randconfig-r044-20220203 (https://download.01.org/0day-ci/arch= ive/20220205/202202050519.HMLLILGz-lkp(a)intel.com/config) compiler: s390-linux-gcc (GCC) 11.2.0 reproduce (this is a W=3D1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/= make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/9ee65f25ad996d38f6935360c= 99a89e72024174b git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Claudio-Imbrenda/KVM-s390-pv-imple= ment-lazy-destroy-for-reboot/20220204-235609 git checkout 9ee65f25ad996d38f6935360c99a89e72024174b # save the config file to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=3D$HOME/0day COMPILER=3Dgcc-11.2.0 make.cross= O=3Dbuild_dir ARCH=3Ds390 SHELL=3D/bin/bash arch/s390/kvm/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All errors (new ones prefixed by >>): arch/s390/kvm/pv.c: In function 'kvm_s390_pv_init_vm': >> arch/s390/kvm/pv.c:255:17: error: implicit declaration of function 'mmu_= notifier_register'; did you mean 'mmu_notifier_release'? [-Werror=3Dimplici= t-function-declaration] 255 | mmu_notifier_register(&kvm->arch.pv.mmu_notifier= , kvm->mm); | ^~~~~~~~~~~~~~~~~~~~~ | mmu_notifier_release cc1: some warnings being treated as errors vim +255 arch/s390/kvm/pv.c 210 = 211 int kvm_s390_pv_init_vm(struct kvm *kvm, u16 *rc, u16 *rrc) 212 { 213 struct uv_cb_cgc uvcb =3D { 214 .header.cmd =3D UVC_CMD_CREATE_SEC_CONF, 215 .header.len =3D sizeof(uvcb) 216 }; 217 int cc, ret; 218 u16 dummy; 219 = 220 ret =3D kvm_s390_pv_alloc_vm(kvm); 221 if (ret) 222 return ret; 223 = 224 /* Inputs */ 225 uvcb.guest_stor_origin =3D 0; /* MSO is 0 for KVM */ 226 uvcb.guest_stor_len =3D kvm->arch.pv.guest_len; 227 uvcb.guest_asce =3D kvm->arch.gmap->asce; 228 uvcb.guest_sca =3D (unsigned long)kvm->arch.sca; 229 uvcb.conf_base_stor_origin =3D (u64)kvm->arch.pv.stor_base; 230 uvcb.conf_virt_stor_origin =3D (u64)kvm->arch.pv.stor_var; 231 = 232 cc =3D uv_call_sched(0, (u64)&uvcb); 233 *rc =3D uvcb.header.rc; 234 *rrc =3D uvcb.header.rrc; 235 KVM_UV_EVENT(kvm, 3, "PROTVIRT CREATE VM: handle %llx len %llx rc %= x rrc %x", 236 uvcb.guest_handle, uvcb.guest_stor_len, *rc, *rrc); 237 = 238 /* Outputs */ 239 kvm->arch.pv.handle =3D uvcb.guest_handle; 240 = 241 atomic_inc(&kvm->mm->context.protected_count); 242 if (cc) { 243 if (uvcb.header.rc & UVC_RC_NEED_DESTROY) { 244 kvm_s390_pv_deinit_vm(kvm, &dummy, &dummy); 245 } else { 246 atomic_dec(&kvm->mm->context.protected_count); 247 kvm_s390_pv_dealloc_vm(kvm); 248 } 249 return -EIO; 250 } 251 kvm->arch.gmap->guest_handle =3D uvcb.guest_handle; 252 /* Add the notifier only once. No races because we hold kvm->lock */ 253 if (kvm->arch.pv.mmu_notifier.ops !=3D &kvm_s390_pv_mmu_notifier_op= s) { 254 kvm->arch.pv.mmu_notifier.ops =3D &kvm_s390_pv_mmu_notifier_ops; > 255 mmu_notifier_register(&kvm->arch.pv.mmu_notifier, kvm->mm); 256 } 257 return 0; 258 } 259 = --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org --===============4018969961444623987==--