Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE722C433F5 for ; Sun, 6 Feb 2022 16:57:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237346AbiBFQ5i (ORCPT ); Sun, 6 Feb 2022 11:57:38 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51344 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232591AbiBFQ5h (ORCPT ); Sun, 6 Feb 2022 11:57:37 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id B185EC043184 for ; Sun, 6 Feb 2022 08:57:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1644166655; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=nj8ZhaWyrNgsbixCTI1WPw5NYTJpZ/GvO+OBOf7Xfj8=; b=b5KRWbuKRP3SJDY7FrwIiv7cNaw3lMbfdeu+tMLFtF4XjzCe/UUC1Ra4iGluQHIVHEcJ/y zDWjRls8YYnit/dcp+4UiRTSCVoGIg49oBw3eu7+mcg34YNIUmfOF123855kLDru+o4isa xScOfcIcAGbP7B9hC9imrLeiZdyVwqk= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-620-PPDtNRZENrWpP380_Ui3BQ-1; Sun, 06 Feb 2022 11:57:34 -0500 X-MC-Unique: PPDtNRZENrWpP380_Ui3BQ-1 Received: by mail-wm1-f69.google.com with SMTP id l20-20020a05600c1d1400b0035153bf34c3so10803757wms.2 for ; Sun, 06 Feb 2022 08:57:34 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=nj8ZhaWyrNgsbixCTI1WPw5NYTJpZ/GvO+OBOf7Xfj8=; b=M9YrRtzi2fQsZjryxeK/AuP1XeX/67B7j4HbLNS6kdDUpVpNBINfuLQgJq0rfnNv7p JHOJOgQQKItUjoLyAJ2MgPceYlZ1EHfU7l53j6ZRkMQ5K7QEc5Cz6xqvSEmW5faKEsV1 JCby5GfnigOXZlHpGjjE1SWZJFXQ3/qiSgWoHppsNQvPGsAKC36r+MfjuC4A/TufNx8t dbTzolbzQEnnrhLYshb6yHQtf9S3up+yO0sgw8bSgssQS7wFFhzLEpfUjm08byXcf96H 5k/oeb5JMeptCkaAmKrq6Z4CwB0wlp/QwUVpYn+WD9N/uowsMLVSeXahq0jnWVHgF1dD DcKA== X-Gm-Message-State: AOAM533gmYvGo/ZqXCnS7wFdtQa86n6uSkgGQU2HOM9lzSdNqPGDrUgU pjdRCXyjJk6n+anJJWqBJq7IAYhJUyXMsNw7tPJOywkKzPFcsm9U77Mm/wQxc3+6HiPx06XKz+p oCfZEjXljfxCSOm5UMkZCXerm X-Received: by 2002:adf:e196:: with SMTP id az22mr7022613wrb.113.1644166653310; Sun, 06 Feb 2022 08:57:33 -0800 (PST) X-Google-Smtp-Source: ABdhPJzX0n3HHySvpcKHUlPDvRzl6SK5emiCLQSwfdUs9Vi2BoUh+o91qWVC6WJC5r45HbYobbBtFA== X-Received: by 2002:adf:e196:: with SMTP id az22mr7022607wrb.113.1644166653192; Sun, 06 Feb 2022 08:57:33 -0800 (PST) Received: from localhost (cpc111743-lutn13-2-0-cust979.9-3.cable.virginm.net. [82.17.115.212]) by smtp.gmail.com with ESMTPSA id g20sm20634047wmq.9.2022.02.06.08.57.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 06 Feb 2022 08:57:32 -0800 (PST) Date: Sun, 6 Feb 2022 16:57:32 +0000 From: Aaron Tomlin To: Christophe Leroy Cc: Luis Chamberlain , Michal Suchanek , "cl@linux.com" , "pmladek@suse.com" , "mbenes@suse.cz" , "akpm@linux-foundation.org" , "jeyu@kernel.org" , "linux-kernel@vger.kernel.org" , "linux-modules@vger.kernel.org" , "live-patching@vger.kernel.org" , "atomlin@atomlin.com" , "ghalat@redhat.com" , "allen.lkml@gmail.com" , "void@manifault.com" , "joe@perches.com" Subject: Re: [RFC PATCH v4 00/13] module: core code clean up Message-ID: <20220206165732.fjge6teag2hf3cc4@ava.usersys.com> X-PGP-Key: http://pgp.mit.edu/pks/lookup?search=atomlin%40redhat.com X-PGP-Fingerprint: 7906 84EB FA8A 9638 8D1E 6E9B E2DE 9658 19CC 77D6 References: <20220130213214.1042497-1-atomlin@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: On Thu 2022-02-03 18:15 +0000, Christophe Leroy wrote: > I also have the feeling that a lot of stuff like function prototypes you > added in include/linux/module.h should instead go in > kernel/module/internal.h as they are not used outside of kernel/module/ Agreed - this will be reflected in v5. Kind regards, -- Aaron Tomlin