Content-Type: multipart/mixed; boundary="===============0269485080552243469==" MIME-Version: 1.0 From: kernel test robot To: kbuild-all@lists.01.org Subject: Re: [PATCH v1 1/1] ACPI: Switch to use list_entry_is_head() helper Date: Sat, 12 Feb 2022 01:59:07 +0800 Message-ID: <202202120054.idhiETlD-lkp@intel.com> In-Reply-To: <20220211110423.22733-1-andriy.shevchenko@linux.intel.com> List-Id: --===============0269485080552243469== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Hi Andy, I love your patch! Yet something to improve: [auto build test ERROR on rafael-pm/linux-next] [also build test ERROR on nvdimm/libnvdimm-for-next v5.17-rc3 next-20220211] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Andy-Shevchenko/ACPI-Switc= h-to-use-list_entry_is_head-helper/20220211-190438 base: https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git= linux-next config: ia64-allmodconfig (https://download.01.org/0day-ci/archive/20220212= /202202120054.idhiETlD-lkp(a)intel.com/config) compiler: ia64-linux-gcc (GCC) 11.2.0 reproduce (this is a W=3D1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/= make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/95f7c8c71bb18e505f5399a87= cbb192f481c86fe git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Andy-Shevchenko/ACPI-Switch-to-use= -list_entry_is_head-helper/20220211-190438 git checkout 95f7c8c71bb18e505f5399a87cbb192f481c86fe # save the config file to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=3D$HOME/0day COMPILER=3Dgcc-11.2.0 make.cross= O=3Dbuild_dir ARCH=3Dia64 SHELL=3D/bin/bash drivers/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All errors (new ones prefixed by >>): drivers/acpi/acpi_ipmi.c: In function 'ipmi_cancel_tx_msg': >> drivers/acpi/acpi_ipmi.c:369:17: error: expected ')' before 'return' 369 | return; | ^~~~~~ drivers/acpi/acpi_ipmi.c:368:12: note: to match this '(' 368 | if (list_entry_is_head(tx_msg, &ipmi->tx_msg_list, head) | ^ >> drivers/acpi/acpi_ipmi.c:372:1: error: expected expression before '}' to= ken 372 | } | ^ vim +369 drivers/acpi/acpi_ipmi.c 352 = 353 static void ipmi_cancel_tx_msg(struct acpi_ipmi_device *ipmi, 354 struct acpi_ipmi_msg *msg) 355 { 356 struct acpi_ipmi_msg *tx_msg, *temp; 357 unsigned long flags; 358 = 359 spin_lock_irqsave(&ipmi->tx_msg_lock, flags); 360 list_for_each_entry_safe(tx_msg, temp, &ipmi->tx_msg_list, head) { 361 if (msg =3D=3D tx_msg) { 362 list_del(&tx_msg->head); 363 break; 364 } 365 } 366 spin_unlock_irqrestore(&ipmi->tx_msg_lock, flags); 367 = 368 if (list_entry_is_head(tx_msg, &ipmi->tx_msg_list, head) > 369 return; 370 = 371 acpi_ipmi_msg_put(tx_msg); > 372 } 373 = --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org --===============0269485080552243469==--