Content-Type: multipart/mixed; boundary="===============4708186571734388810==" MIME-Version: 1.0 From: kernel test robot To: kbuild-all@lists.01.org Subject: Re: [PATCH v1 05/14] fs: split off __alloc_page_buffers function Date: Tue, 15 Feb 2022 06:46:30 +0800 Message-ID: <202202150646.hLANces3-lkp@intel.com> In-Reply-To: <20220214174403.4147994-6-shr@fb.com> List-Id: --===============4708186571734388810== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Hi Stefan, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on f1baf68e1383f6ed93eb9cff2866d46562607a43] url: https://github.com/0day-ci/linux/commits/Stefan-Roesch/Support-sync= -buffered-writes-for-io-uring/20220215-014908 base: f1baf68e1383f6ed93eb9cff2866d46562607a43 config: i386-randconfig-a016-20220214 (https://download.01.org/0day-ci/arch= ive/20220215/202202150646.hLANces3-lkp(a)intel.com/config) compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 reproduce (this is a W=3D1 build): # https://github.com/0day-ci/linux/commit/e8b24c1ab111c127cbe1daaac= 3b607c626fb03a8 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Stefan-Roesch/Support-sync-buffere= d-writes-for-io-uring/20220215-014908 git checkout e8b24c1ab111c127cbe1daaac3b607c626fb03a8 # save the config file to linux build tree mkdir build_dir make W=3D1 O=3Dbuild_dir ARCH=3Di386 SHELL=3D/bin/bash If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All warnings (new ones prefixed by >>): >> fs/buffer.c:805:21: warning: no previous prototype for '__alloc_page_buf= fers' [-Wmissing-prototypes] 805 | struct buffer_head *__alloc_page_buffers(struct page *page, unsi= gned long size, | ^~~~~~~~~~~~~~~~~~~~ vim +/__alloc_page_buffers +805 fs/buffer.c 804 = > 805 struct buffer_head *__alloc_page_buffers(struct page *page, unsigned= long size, 806 gfp_t gfp) 807 { 808 struct buffer_head *bh, *head; 809 long offset; 810 struct mem_cgroup *memcg, *old_memcg; 811 = 812 /* The page lock pins the memcg */ 813 memcg =3D page_memcg(page); 814 old_memcg =3D set_active_memcg(memcg); 815 = 816 head =3D NULL; 817 offset =3D PAGE_SIZE; 818 while ((offset -=3D size) >=3D 0) { 819 bh =3D alloc_buffer_head(gfp); 820 if (!bh) 821 goto no_grow; 822 = 823 bh->b_this_page =3D head; 824 bh->b_blocknr =3D -1; 825 head =3D bh; 826 = 827 bh->b_size =3D size; 828 = 829 /* Link the buffer to its page */ 830 set_bh_page(bh, page, offset); 831 } 832 out: 833 set_active_memcg(old_memcg); 834 return head; 835 /* 836 * In case anything failed, we just free everything we got. 837 */ 838 no_grow: 839 if (head) { 840 do { 841 bh =3D head; 842 head =3D head->b_this_page; 843 free_buffer_head(bh); 844 } while (head); 845 } 846 = 847 goto out; 848 } 849 = --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org --===============4708186571734388810==--