Content-Type: multipart/mixed; boundary="===============2399621129934568883==" MIME-Version: 1.0 From: kernel test robot To: kbuild-all@lists.01.org Subject: Re: [PATCH V3] scsi: target: tcmu: Make cmd_ring_size changeable via configfs. Date: Tue, 15 Feb 2022 21:05:59 +0800 Message-ID: <202202152052.AEF7jHIH-lkp@intel.com> In-Reply-To: <1644912216-97633-1-git-send-email-kanie@linux.alibaba.com> List-Id: --===============2399621129934568883== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Hi Guixin, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on mkp-scsi/for-next] [also build test WARNING on v5.17-rc4 next-20220215] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Guixin-Liu/scsi-target-tcm= u-Make-cmd_ring_size-changeable-via-configfs/20220215-160505 base: https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git for-ne= xt config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/202202= 15/202202152052.AEF7jHIH-lkp(a)intel.com/config) compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 reproduce (this is a W=3D1 build): # https://github.com/0day-ci/linux/commit/7f77700542b8196c546ef1065= 6dda7a107d8d1ad git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Guixin-Liu/scsi-target-tcmu-Make-c= md_ring_size-changeable-via-configfs/20220215-160505 git checkout 7f77700542b8196c546ef10656dda7a107d8d1ad # save the config file to linux build tree mkdir build_dir make W=3D1 O=3Dbuild_dir ARCH=3Dx86_64 SHELL=3D/bin/bash drivers/ta= rget/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All warnings (new ones prefixed by >>): drivers/target/target_core_user.c: In function 'tcmu_show_configfs_dev_p= arams': >> drivers/target/target_core_user.c:2627:41: warning: format '%u' expects = argument of type 'unsigned int', but argument 3 has type 'long unsigned int= ' [-Wformat=3D] 2627 | bl +=3D sprintf(b + bl, "CmdRingSizeMB: %u\n", | ~^ | | | unsigned int | %lu 2628 | (udev->cmdr_size + CMDR_OFF) >> 20); | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | | | long unsigned int drivers/target/target_core_user.c: In function 'tcmu_cmd_ring_size_mb_sh= ow': drivers/target/target_core_user.c:2743:37: warning: format '%u' expects = argument of type 'unsigned int', but argument 4 has type 'long unsigned int= ' [-Wformat=3D] 2743 | return snprintf(page, PAGE_SIZE, "%u\n", | ~^ | | | unsigned int | %lu 2744 | (udev->cmdr_size + CMDR_OFF) >> 20); | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | | | long unsigned int vim +2627 drivers/target/target_core_user.c 2616 = 2617 static ssize_t tcmu_show_configfs_dev_params(struct se_device *dev, = char *b) 2618 { 2619 struct tcmu_dev *udev =3D TCMU_DEV(dev); 2620 ssize_t bl =3D 0; 2621 = 2622 bl =3D sprintf(b + bl, "Config: %s ", 2623 udev->dev_config[0] ? udev->dev_config : "NULL"); 2624 bl +=3D sprintf(b + bl, "Size: %llu ", udev->dev_size); 2625 bl +=3D sprintf(b + bl, "MaxDataAreaMB: %u ", udev->data_area_mb); 2626 bl +=3D sprintf(b + bl, "DataPagesPerBlk: %u", udev->data_pages_per= _blk); > 2627 bl +=3D sprintf(b + bl, "CmdRingSizeMB: %u\n", 2628 (udev->cmdr_size + CMDR_OFF) >> 20); 2629 = 2630 return bl; 2631 } 2632 = --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org --===============2399621129934568883==--