Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4AEAEC433F5 for ; Thu, 17 Feb 2022 14:10:43 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 5575783B7E; Thu, 17 Feb 2022 15:10:40 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=permerror header.from=nic.cz Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; secure) header.d=nic.cz header.i=@nic.cz header.b="p7FnkppH"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 265D6816A2; Thu, 17 Feb 2022 15:10:37 +0100 (CET) Received: from mail.nic.cz (mail.nic.cz [217.31.204.67]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 2961B83B7E for ; Thu, 17 Feb 2022 15:10:33 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=permerror header.from=nic.cz Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=marek.behun@nic.cz Received: from dellmb (unknown [IPv6:2001:1488:fffe:6:8747:7254:5571:3010]) by mail.nic.cz (Postfix) with ESMTPSA id 97AEC14238C; Thu, 17 Feb 2022 15:10:32 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=nic.cz; s=default; t=1645107032; bh=BuaEN7JU9alObLY1lVmKBuBUMaaY84og+KVtowWcs9U=; h=Date:From:To; b=p7FnkppH9oqZhB8jBGJIrcTPFTB52prgcahRa3yadhfsifZXxIq+lQ7tqdMvBBgKe Rcl08Rlem4sQaWqtYwpLA06VSQK1bqKZDp6yMq/MPrZ7+lYti60dUKDxPoqUd8LX7C A3Cl7onWmhfgJTsCl/98hxghZAdpf1vphijJLUCI= Date: Thu, 17 Feb 2022 15:10:32 +0100 From: Marek =?UTF-8?B?QmVow7pu?= To: Pali =?UTF-8?B?Um9ow6Fy?= Cc: Stefan Roese , Konstantin Porotchkin , Vladimir Vid , u-boot@lists.denx.de Subject: Re: [PATCH u-boot-mvebu 1/5] arm: mvebu: a37xx: Add support for reading NB and SB fuse OTP value Message-ID: <20220217151032.1a6e52f7@dellmb> In-Reply-To: <20220217092619.1445-2-pali@kernel.org> References: <20220217092619.1445-1-pali@kernel.org> <20220217092619.1445-2-pali@kernel.org> X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On Thu, 17 Feb 2022 10:26:15 +0100 Pali Roh=C3=A1r wrote: > Implement it via U-Boot fuse API. nitpick: In commit messages I prefer not to refer to commit title, i.e. instead of Implement it via U-Boot fuse API. I would write Implement reading NB and SB fuses of Armada 37xx SOC via U-Boot fuse API. as the first sentence. >=20 > Banks 0-43 are reserved for accessing Security OTP (not implemented yet). > Bank 44 is used for accessing North Bridge OTP (69 bits via words 0-2). > Bank 45 is used for accessing South Bridge OTP (97 bits via words 0-3). >=20 > Write support is not implemented yet as it looks like that both North ^because/since > and South Bridge OTPs are already burned in factory with some data. Meani= ng ^The mean= ing > of some bits of North Bridge are documented in WTMI source code. Meaning = of ^is (or meaningS are) ^The meaning of > bits in South Bridge is unknown. Otherwise Reviewed-by: Marek Beh=C3=BAn