Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 533D7C433EF for ; Mon, 28 Feb 2022 20:18:54 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 8588783BAC; Mon, 28 Feb 2022 21:18:51 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="Eh8Fy5kM"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id B8D2682A59; Mon, 28 Feb 2022 21:18:49 +0100 (CET) Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id E3FA683C27 for ; Mon, 28 Feb 2022 21:18:45 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=pali@kernel.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9779960B92; Mon, 28 Feb 2022 20:18:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D8575C340F2; Mon, 28 Feb 2022 20:18:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1646079523; bh=eG/mPxB6Cm/njcBVvJuWdg1aFLD32k4yWIaw1HLGsrQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Eh8Fy5kM2FvsA605gjII0ZFW+1s8ZCCHzd3VjiqTdugM/6Yzd0K+scCJ1BIYVmOE0 ACM8OOE1Ll6ol5ef1y3GdE4gnPRzKNFFNo8ssz2nSRphbddVfikVSZQjiK5yh5qz3c Bdvr4iPK6GVK29XAY4xL3rCDQW7WTgR6XuIZLWHu6ihFZtvra/exYn1Caj8Qh37VV8 VxMAPcqttvO6Pc4V8gJX+PqvRCKPTCFFtutoTg8p8/qqTfz3DQDk4sqh+ydbr2jIgK I8fRvneu+3CVcawdoUz6wgSvuV/XN7g0Z1GeIJfDLfF15oU8atPo70+gZycQbCRH6c Lhue1RYSDWeYw== Received: by pali.im (Postfix) id E48DC67D; Mon, 28 Feb 2022 21:18:39 +0100 (CET) Date: Mon, 28 Feb 2022 21:18:39 +0100 From: Pali =?utf-8?B?Um9ow6Fy?= To: Marek =?utf-8?B?QmVow7pu?= Cc: Stefan Roese , "u-boot@lists.denx.de" , Marek =?utf-8?B?QmVow7pu?= Subject: Re: [PATCH u-boot-marvell] arm64: a37xx: pinctrl: Fix PWM pins indexes Message-ID: <20220228201839.3whyuf5hqdy2sedf@pali> References: <20220228145937.15167-1-kabel@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220228145937.15167-1-kabel@kernel.org> User-Agent: NeoMutt/20180716 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On Monday 28 February 2022 15:59:37 Marek Behún wrote: > From: Marek Behún > > Commit 5534fb4f4833 ("arm64: a37xx: pinctrl: Correct PWM pins > definitions") introduced bogus definitions os PWM pins: all 4 pins have > index 11, instead of having indexes 11, 12, 13, 14. > > Fix this. > > Signed-off-by: Marek Behún Reviewed-by: Pali Rohár Fixes: 5534fb4f4833 ("arm64: a37xx: pinctrl: Correct PWM pins definitions") > --- > drivers/pinctrl/mvebu/pinctrl-armada-37xx.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c b/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c > index 1cf1f06f10..e76ef153e6 100644 > --- a/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c > +++ b/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c > @@ -162,11 +162,11 @@ static struct armada_37xx_pin_group armada_37xx_nb_groups[] = { > PIN_GRP_GPIO("emmc_nb", 27, 9, BIT(2), "emmc"), > PIN_GRP_GPIO_3("pwm0", 11, 1, BIT(3) | BIT(20), 0, BIT(20), BIT(3), > "pwm", "led"), > - PIN_GRP_GPIO_3("pwm1", 11, 1, BIT(4) | BIT(21), 0, BIT(21), BIT(4), > + PIN_GRP_GPIO_3("pwm1", 12, 1, BIT(4) | BIT(21), 0, BIT(21), BIT(4), > "pwm", "led"), > - PIN_GRP_GPIO_3("pwm2", 11, 1, BIT(5) | BIT(22), 0, BIT(22), BIT(5), > + PIN_GRP_GPIO_3("pwm2", 13, 1, BIT(5) | BIT(22), 0, BIT(22), BIT(5), > "pwm", "led"), > - PIN_GRP_GPIO_3("pwm3", 11, 1, BIT(6) | BIT(23), 0, BIT(23), BIT(6), > + PIN_GRP_GPIO_3("pwm3", 14, 1, BIT(6) | BIT(23), 0, BIT(23), BIT(6), > "pwm", "led"), > PIN_GRP_GPIO("pmic1", 7, 1, BIT(7), "pmic"), > PIN_GRP_GPIO("pmic0", 6, 1, BIT(8), "pmic"), > -- > 2.34.1 >