Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 45661C433F5 for ; Tue, 1 Mar 2022 13:39:27 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id B97E483B71; Tue, 1 Mar 2022 14:39:24 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id 4DE1C83885; Tue, 1 Mar 2022 14:39:22 +0100 (CET) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by phobos.denx.de (Postfix) with ESMTP id B3F3283A92 for ; Tue, 1 Mar 2022 14:39:18 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=andre.przywara@arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id EBA071042; Tue, 1 Mar 2022 05:39:17 -0800 (PST) Received: from donnerap.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id ADFF43F70D; Tue, 1 Mar 2022 05:39:15 -0800 (PST) Date: Tue, 1 Mar 2022 13:39:01 +0000 From: Andre Przywara To: Jesse Taube Cc: u-boot@lists.denx.de, jagan@amarulasolutions.com, hdegoede@redhat.com, sjg@chromium.org, icenowy@aosc.io, marek.behun@nic.cz, festevam@denx.de, narmstrong@baylibre.com, tharvey@gateworks.com, christianshewitt@gmail.com, pbrobinson@gmail.com, jernej.skrabec@gmail.com, hs@denx.de, samuel@sholland.org, arnaud.ferraris@gmail.com, giulio.benetti@benettiengineering.com, thirtythreeforty@gmail.com Subject: Re: [PATCH v2 0/3] Add SPI boot to SPL on SUNIV/F1C100s Message-ID: <20220301133901.7652c743@donnerap.cambridge.arm.com> In-Reply-To: <8af92e65-cf73-adc7-b407-4f79d3851431@gmail.com> References: <20220212003235.2162334-1-Mr.Bossman075@gmail.com> <8af92e65-cf73-adc7-b407-4f79d3851431@gmail.com> Organization: ARM X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.32; aarch64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On Mon, 28 Feb 2022 23:42:13 -0500 Jesse Taube wrote: Hi, > Hey just checking if you know about this set. Yeah, I saw that, and am planning on taking it ASAP, so still this release. However I wanted to have this tested, which is now easier since I got my LicheePi Nano on Friday. So SPI boot seems to work, but I needed to fix FEL boot in mainline (see the other patch). I am not convinced with the uint32_t part, though. I think "int" is fine, because it's either -1 or the uint8_t returned by readb(), which fits both nicely and correctly into an "int". I will do some more testing and then see what other patches I can pick up (Jernej's PRCM ones, for instance). Cheers, Andre > > This patch adds the ability to detect the BROM's boot source, > > as well as the ability to boot from SPI. > > > > Jesse Taube (3): > > mach-sunxi: Add boot device detection for SUNIV/F1C100s > > mach-sunxi: Add SPL SPI boot for SUNIV > > mach-sunxi: Enable SPI boot for SUNIV and licheepi nano > > > > arch/arm/include/asm/arch-sunxi/gpio.h | 1 + > > arch/arm/include/asm/arch-sunxi/spl.h | 10 +++++ > > arch/arm/mach-sunxi/Kconfig | 2 +- > > arch/arm/mach-sunxi/board.c | 57 +++++++++++++------------- > > arch/arm/mach-sunxi/spl_spi_sunxi.c | 24 +++++++---- > > configs/licheepi_nano_defconfig | 1 + > > 6 files changed, 58 insertions(+), 37 deletions(-) > >