Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id F027110E176 for ; Tue, 1 Mar 2022 21:24:53 +0000 (UTC) From: Ramalingam C To: igt-dev Date: Wed, 2 Mar 2022 02:55:11 +0530 Message-Id: <20220301212513.30772-2-ramalingam.c@intel.com> In-Reply-To: <20220301212513.30772-1-ramalingam.c@intel.com> References: <20220301212513.30772-1-ramalingam.c@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: [igt-dev] [PATCH i-g-t v2 1/3] i915/gem_engine_topology: Only use the main copy engines for XY_BLOCK_COPY List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Melkaveri@freedesktop.org, Chris Wilson Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" List-ID: From: Chris Wilson XY_BLOCK_COPY blt command is used to transfer the ccs data. So, we can only run the tests on those engines which have support for the "block_copy" capability. Signed-off-by: Chris Wilson Signed-off-by: Apoorva Singh Cc: Zbigniew KempczyƄski Cc: Melkaveri, Arjun --- lib/i915/gem_engine_topology.c | 38 ++++++++++++++++++++++++++++++++++ lib/i915/gem_engine_topology.h | 5 +++++ 2 files changed, 43 insertions(+) diff --git a/lib/i915/gem_engine_topology.c b/lib/i915/gem_engine_topology.c index bd12d0bc986d..18fc00ab00e9 100644 --- a/lib/i915/gem_engine_topology.c +++ b/lib/i915/gem_engine_topology.c @@ -534,6 +534,44 @@ void gem_engine_properties_restore(int fd, const struct gem_engine_properties *s } } +static bool +__gem_engine_has_capability(int i915, const char *engine, + const char *attr, const char *cap) +{ + char buf[4096] = {}; + FILE *file; + + file = __open_attr(igt_sysfs_open(i915), "r", + "engine", engine, attr, NULL); + if (file) { + fread(buf, 1, sizeof(buf) - 1, file); + fclose(file); + } + + return strstr(buf, cap); +} + +bool gem_engine_has_capability(int i915, const char *engine, const char *cap) +{ + return __gem_engine_has_capability(i915, engine, "capabilities", cap); +} + +bool gem_engine_has_known_capability(int i915, const char *engine, const char *cap) +{ + return __gem_engine_has_capability(i915, engine, "known_capabilities", cap); +} + +bool gem_engine_can_block_copy(int i915, const struct intel_execution_engine2 *engine) +{ + if (engine->class != I915_ENGINE_CLASS_COPY) + return false; + + if (!gem_engine_has_known_capability(i915, engine->name, "block_copy")) + return intel_gen(intel_get_drm_devid(i915)) >= 12; + + return gem_engine_has_capability(i915, engine->name, "block_copy"); +} + uint32_t gem_engine_mmio_base(int i915, const char *engine) { unsigned int mmio = 0; diff --git a/lib/i915/gem_engine_topology.h b/lib/i915/gem_engine_topology.h index b413aa8aba30..987f2bf9449d 100644 --- a/lib/i915/gem_engine_topology.h +++ b/lib/i915/gem_engine_topology.h @@ -133,6 +133,11 @@ int gem_engine_property_printf(int i915, const char *engine, const char *attr, uint32_t gem_engine_mmio_base(int i915, const char *engine); +bool gem_engine_has_capability(int i915, const char *engine, const char *cap); +bool gem_engine_has_known_capability(int i915, const char *engine, const char *cap); + +bool gem_engine_can_block_copy(int i915, const struct intel_execution_engine2 *engine); + void dyn_sysfs_engines(int i915, int engines, const char *file, void (*test)(int i915, int engine)); -- 2.20.1